Changeset 205499 in webkit

Timestamp:

Sep 6, 2016 12:56:37 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Cannot undo in breakpoint editor
​https://bugs.webkit.org/show_bug.cgi?id=152858

Patch by Devin Rousso <Devin Rousso> on 2016-09-06
Reviewed by Brian Burg.

• UserInterface/Controllers/BreakpointPopoverController.js:

(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorBeforeChange):
Since the breakpoint editor only allows a single line of JavaScript, it attempts to remove
all "\n" characters. During an "undo" action, this is not possible.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/BreakpointPopoverController.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-09-06  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: Cannot undo in breakpoint editor
+        https://bugs.webkit.org/show_bug.cgi?id=152858
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Controllers/BreakpointPopoverController.js:
+        (WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorBeforeChange):
+        Since the breakpoint editor only allows a single line of JavaScript, it attempts to remove
+        all "\n" characters.  During an "undo" action, this is not possible.
+
 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/BreakpointPopoverController.js

@@ -240 +240 @@
     _conditionCodeMirrorBeforeChange(codeMirror, change)
     {
-        let newText = change.text.join("").replace(/\n/g, "");
-        change.update(change.from, change.to, [newText]);
+        if (change.update) {
+            let newText = change.text.join("").replace(/\n/g, "");
+            change.update(change.from, change.to, [newText]);
+        }
+
         return true;
     }