Changeset 205529 in webkit

Timestamp:

Sep 6, 2016 5:31:55 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Avoid linkifying some schemes in console logs
​https://bugs.webkit.org/show_bug.cgi?id=161648
<rdar://problem/16413270>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-06
Reviewed by Brian Burg.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::openInNewTab):
If a javascript: link is passed just ignore it.

Source/WebInspectorUI:

• UserInterface/Base/Main.js:

Don't linkify some kinds of links.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorFrontendHost.cpp (modified) (1 diff)
• WebInspectorUI/ChangeLog (modified) (1 diff)
• WebInspectorUI/UserInterface/Base/Main.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-06  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Avoid linkifying some schemes in console logs
+        https://bugs.webkit.org/show_bug.cgi?id=161648
+        <rdar://problem/16413270>
+
+        Reviewed by Brian Burg.
+
+        * inspector/InspectorFrontendHost.cpp:
+        (WebCore::InspectorFrontendHost::openInNewTab):
+        If a javascript: link is passed just ignore it.
+
 2016-09-06  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp

@@ -289 +289 @@
 void InspectorFrontendHost::openInNewTab(const String& url)
 {
+    if (WebCore::protocolIsJavaScript(url))
+        return;
+
     if (m_client)
         m_client->openInNewTab(url);

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-09-06  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Avoid linkifying some schemes in console logs
+        https://bugs.webkit.org/show_bug.cgi?id=161648
+        <rdar://problem/16413270>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Base/Main.js:
+        Don't linkify some kinds of links.
+
 2016-09-06  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -2231 +2231 @@
         container.append(nonLink);
 
+        if (linkString.startsWith("data:") || linkString.startsWith("javascript:") || linkString.startsWith("mailto:")) {
+            container.append(linkString);
+            string = string.substring(linkIndex + linkString.length, string.length);
+            continue;
+        }
+
         var title = linkString;
         var realURL = linkString.startsWith("www.") ? "http://" + linkString : linkString;