Changeset 205825 in webkit

Timestamp:

Sep 12, 2016 2:42:31 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

AX: WKWebView for macOS does not allow configuration of tabsToLinks
​https://bugs.webkit.org/show_bug.cgi?id=161394

Patch by DAN SAUNDERS <​dasau@microsoft.com> on 2016-09-12
Reviewed by Anders Carlsson.

Source/WebKit2:

• UIProcess/API/Cocoa/WKPreferences.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
(-[WKPreferences tabFocusesLinks]):
(-[WKPreferences setTabFocusesLinks:]):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:

(TEST):

Location:

trunk

Files:

• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h (modified) (1 diff)
• Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (modified) (3 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-12  DAN SAUNDERS  <dasau@microsoft.com>
+
+        AX: WKWebView for macOS does not allow configuration of tabsToLinks
+        https://bugs.webkit.org/show_bug.cgi?id=161394
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/Cocoa/WKPreferences.h:
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences encodeWithCoder:]):
+        (-[WKPreferences initWithCoder:]):
+        (-[WKPreferences tabFocusesLinks]):
+        (-[WKPreferences setTabFocusesLinks:]):
+
 2016-09-12  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h

@@ -64 +64 @@
  */
 @property (nonatomic) BOOL plugInsEnabled;
+
+/*!
+ @property tabFocusesLinks
+ @abstract If tabFocusesLinks is YES, the tab key will focus links and form controls.
+ The option key temporarily reverses this preference.
+ */
+@property (nonatomic) BOOL tabFocusesLinks WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 #endif
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm

@@ -67 +67 @@
     [coder encodeBool:self.javaEnabled forKey:@"javaEnabled"];
     [coder encodeBool:self.plugInsEnabled forKey:@"plugInsEnabled"];
+    [coder encodeBool:self.tabFocusesLinks forKey:@"tabFocusesLinks"];
 #endif
 }
@@ -82 +83 @@
     self.javaEnabled = [coder decodeBoolForKey:@"javaEnabled"];
     self.plugInsEnabled = [coder decodeBoolForKey:@"plugInsEnabled"];
+    self.tabFocusesLinks = [coder decodeBoolForKey:@"tabFocusesLinks"];
 #endif
 
@@ -139 +141 @@
 {
     _preferences->setPluginsEnabled(plugInsEnabled);
+}
+
+- (BOOL)tabFocusesLinks
+{
+    return _preferences->tabsToLinks();
+}
+
+- (void)setTabFocusesLinks:(BOOL)tabFocusesLinks
+{
+    _preferences->setTabsToLinks(tabFocusesLinks);
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2016-09-12  DAN SAUNDERS  <dasau@microsoft.com>
+
+        AX: WKWebView for macOS does not allow configuration of tabsToLinks
+        https://bugs.webkit.org/show_bug.cgi?id=161394
+
+        Reviewed by Anders Carlsson.
+
+        * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
+        (TEST):
+
 2016-09-12  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm

@@ -52 +52 @@
     [a setJavaEnabled:YES];
     [a setPlugInsEnabled:YES];
+    [a setTabFocusesLinks:YES];
 #endif
 
@@ -63 +64 @@
     EXPECT_EQ([a javaEnabled], [b javaEnabled]);
     EXPECT_EQ([a plugInsEnabled], [b plugInsEnabled]);
+    EXPECT_EQ([a tabFocusesLinks], [b tabFocusesLinks]);
 #endif
 }