Changeset 205852 in webkit

Timestamp:

Sep 12, 2016 11:12:42 PM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Crash of WebProcess on the last WebView disconnect (take two)
​https://bugs.webkit.org/show_bug.cgi?id=161842

Reviewed by Michael Catanzaro.

The problem is that when PlatformDisplayX11 is destroyed, the sharing GL context is deleted and its destructor
makes a downcast of PlatformDisplay to get the native X11 display. We could simply keep a pointer to the native
X11 display in GLContextGLX, got at construction time from the PlatformDisplay, and ensure the sharing GL
context is deleted before the native X11 display is closed.

• platform/graphics/PlatformDisplay.h: Make m_sharingGLContext protected.
• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::GLContextGLX): Initialize m_x11Display.
(WebCore::GLContextGLX::~GLContextGLX): Use m_x11Display and remove confusing comment about possible crash with
nviedia closed drivers.
(WebCore::GLContextGLX::defaultFrameBufferSize): Use m_x11Display.
(WebCore::GLContextGLX::makeContextCurrent): Ditto.
(WebCore::GLContextGLX::swapBuffers): Ditto.
(WebCore::GLContextGLX::swapInterval): Ditto.
(WebCore::GLContextGLX::cairoDevice): Ditto.

• platform/graphics/glx/GLContextGLX.h:
• platform/graphics/x11/PlatformDisplayX11.cpp:

(WebCore::PlatformDisplayX11::~PlatformDisplayX11): Delete the sharing GL context before closing the display.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/PlatformDisplay.h (modified) (2 diffs)
• platform/graphics/glx/GLContextGLX.cpp (modified) (9 diffs)
• platform/graphics/glx/GLContextGLX.h (modified) (2 diffs)
• platform/graphics/x11/PlatformDisplayX11.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Crash of WebProcess on the last WebView disconnect (take two)
+        https://bugs.webkit.org/show_bug.cgi?id=161842
+
+        Reviewed by Michael Catanzaro.
+
+        The problem is that when PlatformDisplayX11 is destroyed, the sharing GL context is deleted and its destructor
+        makes a downcast of PlatformDisplay to get the native X11 display. We could simply keep a pointer to the native
+        X11 display in GLContextGLX, got at construction time from the PlatformDisplay, and ensure the sharing GL
+        context is deleted before the native X11 display is closed.
+
+        * platform/graphics/PlatformDisplay.h: Make m_sharingGLContext protected.
+        * platform/graphics/glx/GLContextGLX.cpp:
+        (WebCore::GLContextGLX::GLContextGLX): Initialize m_x11Display.
+        (WebCore::GLContextGLX::~GLContextGLX): Use m_x11Display and remove confusing comment about possible crash with
+        nviedia closed drivers.
+        (WebCore::GLContextGLX::defaultFrameBufferSize): Use m_x11Display.
+        (WebCore::GLContextGLX::makeContextCurrent): Ditto.
+        (WebCore::GLContextGLX::swapBuffers): Ditto.
+        (WebCore::GLContextGLX::swapInterval): Ditto.
+        (WebCore::GLContextGLX::cairoDevice): Ditto.
+        * platform/graphics/glx/GLContextGLX.h:
+        * platform/graphics/x11/PlatformDisplayX11.cpp:
+        (WebCore::PlatformDisplayX11::~PlatformDisplayX11): Delete the sharing GL context before closing the display.
+
 2016-09-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/graphics/PlatformDisplay.h

@@ -81 +81 @@
 #endif
 
+    std::unique_ptr<GLContext> m_sharingGLContext;
+
 private:
     static std::unique_ptr<PlatformDisplay> createPlatformDisplay();
@@ -91 +93 @@
     int m_eglMinorVersion { 0 };
 #endif
-    std::unique_ptr<GLContext> m_sharingGLContext;
 };
 

trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp

@@ -159 +159 @@
 GLContextGLX::GLContextGLX(PlatformDisplay& display, XUniqueGLXContext&& context, XID window)
     : GLContext(display)
+    , m_x11Display(downcast<PlatformDisplayX11>(m_display).native())
     , m_context(WTFMove(context))
     , m_window(window)
@@ -166 +167 @@
 GLContextGLX::GLContextGLX(PlatformDisplay& display, XUniqueGLXContext&& context, XUniqueGLXPbuffer&& pbuffer)
     : GLContext(display)
+    , m_x11Display(downcast<PlatformDisplayX11>(m_display).native())
     , m_context(WTFMove(context))
     , m_pbuffer(WTFMove(pbuffer))
@@ -173 +175 @@
 GLContextGLX::GLContextGLX(PlatformDisplay& display, XUniqueGLXContext&& context, XUniquePixmap&& pixmap, XUniqueGLXPixmap&& glxPixmap)
     : GLContext(display)
+    , m_x11Display(downcast<PlatformDisplayX11>(m_display).native())
     , m_context(WTFMove(context))
     , m_pixmap(WTFMove(pixmap))
@@ -185 +188 @@
 
     if (m_context) {
-        // This may be necessary to prevent crashes with NVidia's closed source drivers. Originally
-        // from Mozilla's 3D canvas implementation at: http://bitbucket.org/ilmari/canvas3d/
         glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, 0);
-        glXMakeCurrent(downcast<PlatformDisplayX11>(m_display).native(), None, None);
+        glXMakeCurrent(m_x11Display, None, None);
     }
 }
@@ -205 +206 @@
     Window rootWindow;
     unsigned int width, height, borderWidth, depth;
-    if (!XGetGeometry(downcast<PlatformDisplayX11>(m_display).native(), m_window, &rootWindow, &x, &y, &width, &height, &borderWidth, &depth))
+    if (!XGetGeometry(m_x11Display, m_window, &rootWindow, &x, &y, &width, &height, &borderWidth, &depth))
         return IntSize();
 
@@ -219 +220 @@
         return true;
 
-    Display* display = downcast<PlatformDisplayX11>(m_display).native();
     if (m_window)
-        return glXMakeCurrent(display, m_window, m_context.get());
+        return glXMakeCurrent(m_x11Display, m_window, m_context.get());
 
     if (m_pbuffer)
-        return glXMakeCurrent(display, m_pbuffer.get(), m_context.get());
-
-    return ::glXMakeCurrent(display, m_glxPixmap.get(), m_context.get());
+        return glXMakeCurrent(m_x11Display, m_pbuffer.get(), m_context.get());
+
+    return ::glXMakeCurrent(m_x11Display, m_glxPixmap.get(), m_context.get());
 }
 
@@ -232 +232 @@
 {
     if (m_window)
-        glXSwapBuffers(downcast<PlatformDisplayX11>(m_display).native(), m_window);
+        glXSwapBuffers(m_x11Display, m_window);
 }
 
@@ -242 +242 @@
 void GLContextGLX::swapInterval(int interval)
 {
-    if (!hasSGISwapControlExtension(downcast<PlatformDisplayX11>(m_display).native()))
+    if (!hasSGISwapControlExtension(m_x11Display))
         return;
     glXSwapIntervalSGI(interval);
@@ -253 +253 @@
 
 #if ENABLE(ACCELERATED_2D_CANVAS) && CAIRO_HAS_GLX_FUNCTIONS
-    m_cairoDevice = cairo_glx_device_create(downcast<PlatformDisplayX11>(m_display).native(), m_context.get());
+    m_cairoDevice = cairo_glx_device_create(m_x11Display, m_context.get());
 #endif
 

trunk/Source/WebCore/platform/graphics/glx/GLContextGLX.h

@@ -30 +30 @@
 typedef unsigned long XID;
 typedef void* ContextKeyType;
+typedef struct _XDisplay Display;
 
 namespace WebCore {
@@ -63 +64 @@
     static std::unique_ptr<GLContextGLX> createPixmapContext(PlatformDisplay&, GLXContext sharingContext = nullptr);
 
+    Display* m_x11Display { nullptr };
     XUniqueGLXContext m_context;
     XID m_window { 0 };

trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp

@@ -36 +36 @@
 #if USE(EGL)
 #include <EGL/egl.h>
+#include <EGL/eglplatform.h>
 #endif
+
+// FIXME: this needs to be here, after eglplatform.h, to avoid EGLNativeDisplayType to be defined as wl_display.
+// Since we support Wayland and X11 to be built at the same time, but eglplatform.h defines are decided at compile time
+// we need to ensure we only include eglplatform.h from X11 or Wayland specific files.
+#include "GLContext.h"
 
 namespace WebCore {
@@ -54 +60 @@
 PlatformDisplayX11::~PlatformDisplayX11()
 {
+    // Clear the sharing context before releasing the display.
+    m_sharingGLContext = nullptr;
     if (m_ownedDisplay)
         XCloseDisplay(m_display);