Changeset 206194 in webkit

Timestamp:

Sep 20, 2016 7:34:14 PM (8 years ago)

Author:

Hunseop Jeong

Message:

[EFL] ewk_context_menu_item_select test have been failed
​https://bugs.webkit.org/show_bug.cgi?id=162143

Reviewed by Gyuyoung Kim.

ewk_context_menu_item_select has been waited until test page loading is finished, but it is
unnecessary to wait the loading is finished. It would be good to pass if *testFinished*
flag is true.

• UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:

(EWK2ContextMenuTest::checkBasicContextMenuItem):
(EWK2ContextMenuTest::testContextMenu):
(TEST_F):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/tests/test_ewk2_context_menu.cpp (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-20  Hunseop Jeong  <hs85.jeong@samsung.com>
+
+        [EFL] ewk_context_menu_item_select test have been failed
+        https://bugs.webkit.org/show_bug.cgi?id=162143
+
+        Reviewed by Gyuyoung Kim.
+
+        ewk_context_menu_item_select has been waited until test page loading is finished, but it is
+        unnecessary to wait the loading is finished. It would be good to pass if *testFinished*
+        flag is true.
+
+        * UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
+        (EWK2ContextMenuTest::checkBasicContextMenuItem):
+        (EWK2ContextMenuTest::testContextMenu):
+        (TEST_F):
+
 2016-09-20  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp

@@ -50 +50 @@
         EXPECT_EQ(action, ewk_context_menu_item_action_get(item));
         EXPECT_STREQ(title, ewk_context_menu_item_title_get(item));
-    EXPECT_EQ(checked, ewk_context_menu_item_checked_get(item));
-    EXPECT_EQ(enabled, ewk_context_menu_item_enabled_get(item));
+        EXPECT_EQ(checked, ewk_context_menu_item_checked_get(item));
+        EXPECT_EQ(enabled, ewk_context_menu_item_enabled_get(item));
     }
 
@@ -94 +94 @@
 
         EXPECT_TRUE(ewk_context_menu_item_select(contextMenu, item));
+
+        ewk_context_menu_hide(contextMenu);
 
         return true;
@@ -196 +198 @@
 
     ewkViewClass()->context_menu_show = testContextMenu;
+    ewkViewClass()->context_menu_hide = finishTest;
 
     ewk_view_html_string_load(webView(), itemSelectHTML, "file:///", 0);
     ASSERT_TRUE(waitUntilLoadFinished());
     showContextMenu();
-    ASSERT_TRUE(waitUntilLoadFinished());
+    testFinished = false;
+    ASSERT_TRUE(waitUntilTrue(testFinished));
 }