Changeset 206702 in webkit

Timestamp:

Sep 30, 2016, 6:27:35 PM (9 years ago)

Author:

mitz@apple.com

Message:

[iOS] Editing menu omits the Share command if the selected text is longer than 200 characters
​https://bugs.webkit.org/show_bug.cgi?id=162821
<rdar://problem/28409828>

Reviewed by Tim Horton.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformAction:withSender:]): Changed to return YES for the _share:

action even if the selection is longer than 200 characters. While Define should not have
been available for longer selections, Share does not have such a limitation.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-30  Dan Bernstein  <mitz@apple.com>
+
+        [iOS] Editing menu omits the Share command if the selected text is longer than 200 characters
+        https://bugs.webkit.org/show_bug.cgi?id=162821
+        <rdar://problem/28409828>
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView canPerformAction:withSender:]): Changed to return YES for the _share:
+          action even if the selection is longer than 200 characters. While Define should not have
+          been available for longer selections, Share does not have such a limitation.
+
 2016-09-30  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm

@@ -1863 +1863 @@
             return NO;
 
-        NSUInteger textLength = _page->editorState().postLayoutData().selectedTextLength;
-        // See FIXME above for _define.
-        if (!textLength || textLength > 200)
-            return NO;
-        
-        return YES;
+        return _page->editorState().postLayoutData().selectedTextLength > 0;
     }