Changeset 20677 in webkit

Timestamp:

Apr 3, 2007 5:51:55 AM (17 years ago)

Author:

bdash

Message:

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13218 <rdar://problem/5095977> Reproducible crash after call to window.close()

• manual-tests/stale-currentEvent.html: Added.
• page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event, just hit-test the last mouse event coordinates and update for hover state changes. This eliminates the use of currentEvent, which can be a non-mouse event or even a stale event.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/stale-currentEvent.html (added)
• page/EventHandler.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-04-03  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13218
+          <rdar://problem/5095977>
+          Reproducible crash after call to window.close()
+
+        * manual-tests/stale-currentEvent.html: Added.
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event,
+        just hit-test the last mouse event coordinates and update for hover state
+        changes. This eliminates the use of currentEvent, which can be a non-mouse
+        event or even a stale event.
+
 2007-04-02  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/page/EventHandler.cpp

@@ -1244 +1244 @@
 {
     m_hoverTimer.stop();
-    prepareMouseEvent(HitTestRequest(false, false, true), PlatformMouseEvent(PlatformMouseEvent::currentEvent));
+
+    ASSERT(m_frame);
+    ASSERT(m_frame->document());
+
+    if (RenderObject* renderer = m_frame->renderer()) {
+        IntPoint documentPoint = m_frame->view()->windowToContents(m_currentMousePosition);
+        HitTestResult result(documentPoint);
+        renderer->layer()->hitTest(HitTestRequest(false, false, true), result);
+        m_frame->document()->updateRendering();
+    }
 }