Changeset 206908 in webkit
- Timestamp:
- Oct 7, 2016 4:57:30 AM (8 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r206907 r206908 1 2016-10-07 Adam Bergkvist <adam.bergkvist@ericsson.com> 2 3 WebRTC: Misc gardening: Use typedefs consistently and remove unused code 4 https://bugs.webkit.org/show_bug.cgi?id=163104 5 6 Reviewed by Philippe Normand. 7 8 Miscellaneous WebRTC gardening. See file list below for details. 9 10 Testing: No change in behavior. 11 12 * Modules/mediastream/MediaEndpointPeerConnection.cpp: 13 * Modules/mediastream/MediaEndpointPeerConnection.h: 14 Move NotImplemented include to cpp-file. 15 * platform/mediastream/MediaEndpoint.h: 16 Use MediaPayloadVector typedef (instead of Vector<RefPtr<MediaPayload>>). 17 * platform/mediastream/PeerMediaDescription.h: 18 (WebCore::PeerMediaDescription::source): Deleted. 19 (WebCore::PeerMediaDescription::setSource): Deleted. 20 Sources are passed to updateSendConfiguration() via a source map and not added to each 21 PeerMediaDescription anymore. Remove unused code. 22 * platform/mock/MockMediaEndpoint.cpp: 23 (WebCore::MockMediaEndpoint::getDefaultAudioPayloads): 24 (WebCore::MockMediaEndpoint::getDefaultVideoPayloads): 25 Use MediaPayloadVector typedef. 26 * platform/mock/MockMediaEndpoint.h: 27 Use MediaPayloadVector typedef. 28 1 29 2016-10-07 Gwang Yoon Hwang <yoon@igalia.com> 2 30 -
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp
r206868 r206908 40 40 #include "MediaStreamEvent.h" 41 41 #include "MediaStreamTrack.h" 42 #include "NotImplemented.h" 42 43 #include "PeerMediaDescription.h" 43 44 #include "RTCConfiguration.h" -
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h
r206868 r206908 36 36 #include "MediaEndpoint.h" 37 37 #include "MediaEndpointSessionDescription.h" 38 #include "NotImplemented.h"39 38 #include "PeerConnectionBackend.h" 40 39 #include <wtf/Function.h> -
trunk/Source/WebCore/platform/mediastream/MediaEndpoint.h
r206868 r206908 67 67 68 68 virtual void generateDtlsInfo() = 0; 69 virtual Vector<RefPtr<MediaPayload>>getDefaultAudioPayloads() = 0;70 virtual Vector<RefPtr<MediaPayload>>getDefaultVideoPayloads() = 0;69 virtual MediaPayloadVector getDefaultAudioPayloads() = 0; 70 virtual MediaPayloadVector getDefaultVideoPayloads() = 0; 71 71 virtual MediaPayloadVector filterPayloads(const MediaPayloadVector& remotePayloads, const MediaPayloadVector& defaultPayloads) = 0; 72 72 -
trunk/Source/WebCore/platform/mediastream/PeerMediaDescription.h
r201728 r206908 110 110 void addIceCandidate(RefPtr<IceCandidate>&& candidate) { m_iceCandidates.append(WTFMove(candidate)); } 111 111 112 RealtimeMediaSource* source() const { return m_source.get(); }113 void setSource(RefPtr<RealtimeMediaSource>&& source) { m_source = source; }114 115 112 RefPtr<PeerMediaDescription> clone() const 116 113 { … … 179 176 String m_icePassword; 180 177 Vector<RefPtr<IceCandidate>> m_iceCandidates; 181 182 RefPtr<RealtimeMediaSource> m_source { nullptr };183 178 }; 184 179 -
trunk/Source/WebCore/platform/mock/MockMediaEndpoint.cpp
r206868 r206908 74 74 } 75 75 76 Vector<RefPtr<MediaPayload>>MockMediaEndpoint::getDefaultAudioPayloads()77 { 78 Vector<RefPtr<MediaPayload>>payloads;76 MediaPayloadVector MockMediaEndpoint::getDefaultAudioPayloads() 77 { 78 MediaPayloadVector payloads; 79 79 80 80 RefPtr<MediaPayload> payload = MediaPayload::create(); … … 102 102 } 103 103 104 Vector<RefPtr<MediaPayload>>MockMediaEndpoint::getDefaultVideoPayloads()105 { 106 Vector<RefPtr<MediaPayload>>payloads;104 MediaPayloadVector MockMediaEndpoint::getDefaultVideoPayloads() 105 { 106 MediaPayloadVector payloads; 107 107 108 108 RefPtr<MediaPayload> payload = MediaPayload::create(); -
trunk/Source/WebCore/platform/mock/MockMediaEndpoint.h
r206868 r206908 49 49 50 50 void generateDtlsInfo() override; 51 Vector<RefPtr<MediaPayload>>getDefaultAudioPayloads() override;52 Vector<RefPtr<MediaPayload>>getDefaultVideoPayloads() override;51 MediaPayloadVector getDefaultAudioPayloads() override; 52 MediaPayloadVector getDefaultVideoPayloads() override; 53 53 MediaPayloadVector filterPayloads(const MediaPayloadVector& remotePayloads, const MediaPayloadVector& defaultPayloads) override; 54 54
Note: See TracChangeset
for help on using the changeset viewer.