Changeset 206921 in webkit


Ignore:
Timestamp:
Oct 7, 2016 10:44:51 AM (8 years ago)
Author:
n_wang@apple.com
Message:

AX: AXRoleDescription for details and summary elements
​https://bugs.webkit.org/show_bug.cgi?id=163094

Reviewed by Chris Fleizach.

Source/WebCore:

details and summary elements should have AXRoleDescription that is consistent with other
elements that have custom AXSubRole.

Test: accessibility/mac/details-summary-role-description.html

  • English.lproj/Localizable.strings:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore::AXDetailsText):
(WebCore::AXSummaryText):

  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXDetailsText):
(WebCore::AXSummaryText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXDetailsText):
(WebCore::AXSummaryText):

LayoutTests:

  • accessibility/mac/details-summary-role-description-expected.txt: Added.
  • accessibility/mac/details-summary-role-description.html: Added.
Location:
trunk
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r206919 r206921  
     12016-10-07  Nan Wang  <n_wang@apple.com>
     2
     3        AX: AXRoleDescription for details and summary elements
     4        https://bugs.webkit.org/show_bug.cgi?id=163094
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/mac/details-summary-role-description-expected.txt: Added.
     9        * accessibility/mac/details-summary-role-description.html: Added.
     10
    1112016-10-07  Ryan Haddad  <ryanhaddad@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r206920 r206921  
     12016-10-07  Nan Wang  <n_wang@apple.com>
     2
     3        AX: AXRoleDescription for details and summary elements
     4        https://bugs.webkit.org/show_bug.cgi?id=163094
     5
     6        Reviewed by Chris Fleizach.
     7
     8        details and summary elements should have AXRoleDescription that is consistent with other
     9        elements that have custom AXSubRole.
     10
     11        Test: accessibility/mac/details-summary-role-description.html
     12
     13        * English.lproj/Localizable.strings:
     14        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
     15        (-[WebAccessibilityObjectWrapper roleDescription]):
     16        * platform/LocalizedStrings.cpp:
     17        (WebCore::AXDetailsText):
     18        (WebCore::AXSummaryText):
     19        * platform/LocalizedStrings.h:
     20        * platform/efl/LocalizedStringsEfl.cpp:
     21        (WebCore::AXDetailsText):
     22        (WebCore::AXSummaryText):
     23        * platform/gtk/LocalizedStringsGtk.cpp:
     24        (WebCore::AXDetailsText):
     25        (WebCore::AXSummaryText):
     26
    1272016-10-07  Ryan Haddad  <ryanhaddad@apple.com>
    228

  • trunk/Source/WebCore/English.lproj/Localizable.strings

    r205184 r206921  
    812812"description list" = "description list";
    813813
     814/* accessibility role description for a details element */
     815"details" = "details";
     816
    814817/* An ARIA accessibility group that acts as a document. */
    815818"document" = "document";
    … …  
    10671070"success" = "success";
    10681071
     1072/* accessibility role description for a summary element */
     1073"summary" = "summary";
     1074
    10691075/* HTTP result code string */
    10701076"switching protocols" = "switching protocols";

  • trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

    r205985 r206921  
    24882488        case DescriptionListDetailRole:
    24892489            return AXDescriptionListDetailText();
     2490        case DetailsRole:
     2491            return AXDetailsText();
    24902492        case FooterRole:
    24912493            return AXFooterRoleDescriptionText();
     2494        case SummaryRole:
     2495            return AXSummaryText();
    24922496        case VideoRole:
    24932497            return localizedMediaControlElementString("VideoElement");

  • trunk/Source/WebCore/platform/LocalizedStrings.cpp

    r205524 r206921  
    604604{
    605605    return WEB_UI_STRING("description", "description detail");
     606}
     607
     608String AXDetailsText()
     609{
     610    return WEB_UI_STRING("details", "accessibility role description for a details element");
     611}
     612
     613String AXSummaryText()
     614{
     615    return WEB_UI_STRING("summary", "accessibility role description for a summary element");
    606616}
    607617

  • trunk/Source/WebCore/platform/LocalizedStrings.h

    r205524 r206921  
    169169    String AXSearchFieldCancelButtonText();
    170170    String AXAttachmentRoleText();
     171    String AXDetailsText();
     172    String AXSummaryText();
    171173   
    172174    String AXButtonActionVerb();

  • trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp

    r205524 r206921  
    397397{
    398398    return String::fromUTF8("description");
     399}
     400
     401String AXDetailsText()
     402{
     403    return String::fromUTF8("details");
     404}
     405
     406String AXSummaryText()
     407{
     408    return String::fromUTF8("summary");
    399409}
    400410

  • trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

    r205524 r206921  
    445445{
    446446    return String::fromUTF8(_("description"));
     447}
     448
     449String AXDetailsText()
     450{
     451    return String::fromUTF8(_("details"));
     452}
     453
     454String AXSummaryText()
     455{
     456    return String::fromUTF8(_("summary"));
    447457}
    448458
Note: See TracChangeset for help on using the changeset viewer.