Changeset 206988 in webkit

Timestamp:

Oct 10, 2016 12:45:52 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

NetworkSession: downloads started by startDownload() can fail before starting from the API point of view
​https://bugs.webkit.org/show_bug.cgi?id=163107

Reviewed by Alex Christensen.

In the network process we use a PendingDownload in this case, but in the UI process we always have a single
download proxy. If an error happens before the pending download is converted inot a real download, the DidFail
messages is received in the download proxy before the DidStart one. This is problematic at least for the GTK+
API, because it's common to connect to the started signal and connect to all other signals from there, but in
this case the started signal is never emitted, and then the failed one is not handled. This is not a problem for
downloads started by convertTaskToDownload, because in that case those loads are not considered a download by
the UI process when those early errors happen, and then the web page handles them.

• NetworkProcess/Downloads/PendingDownload.cpp:

(WebKit::PendingDownload::PendingDownload): Send DidStart message right after the network load starts like the
non network session code does.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::convertTaskToDownload): Send DidStart message now that the normal load has been converted
into a download.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::findPendingDownloadLocation): Do not send DidStart message here.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/Downloads/PendingDownload.cpp (modified) (1 diff)
• NetworkProcess/NetworkLoad.cpp (modified) (2 diffs)
• NetworkProcess/NetworkProcess.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-10-10  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        NetworkSession: downloads started by startDownload() can fail before starting from the API point of view
+        https://bugs.webkit.org/show_bug.cgi?id=163107
+
+        Reviewed by Alex Christensen.
+
+        In the network process we use a PendingDownload in this case, but in the UI process we always have a single
+        download proxy. If an error happens before the pending download is converted inot a real download, the DidFail
+        messages is received in the download proxy before the DidStart one. This is problematic at least for the GTK+
+        API, because it's common to connect to the started signal and connect to all other signals from there, but in
+        this case the started signal is never emitted, and then the failed one is not handled. This is not a problem for
+        downloads started by convertTaskToDownload, because in that case those loads are not considered a download by
+        the UI process when those early errors happen, and then the web page handles them.
+
+        * NetworkProcess/Downloads/PendingDownload.cpp:
+        (WebKit::PendingDownload::PendingDownload): Send DidStart message right after the network load starts like the
+        non network session code does.
+        * NetworkProcess/NetworkLoad.cpp:
+        (WebKit::NetworkLoad::convertTaskToDownload): Send DidStart message now that the normal load has been converted
+        into a download.
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::findPendingDownloadLocation): Do not send DidStart message here.
+
 2016-10-10  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/NetworkProcess/Downloads/PendingDownload.cpp

@@ -45 +45 @@
     m_networkLoad->setPendingDownload(*this);
     m_networkLoad->setSuggestedFilename(suggestedName);
+
+    send(Messages::DownloadProxy::DidStart(m_networkLoad->currentRequest(), suggestedName));
 }
 

trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp

@@ -25 +25 @@
 
 #include "config.h"
-
 #include "NetworkLoad.h"
 
 #include "AuthenticationManager.h"
+#include "DownloadProxyMessages.h"
 #include "NetworkProcess.h"
 #include "SessionTracker.h"
+#include "WebCoreArgumentCoders.h"
 #include "WebErrors.h"
 #include <WebCore/NotImplemented.h>
 #include <WebCore/ResourceHandle.h>
+#include <WebCore/ResourceRequest.h>
 #include <WebCore/SessionID.h>
 #include <WebCore/SharedBuffer.h>
@@ -188 +190 @@
         return;
 
+    NetworkProcess::singleton().downloadManager().downloadProxyConnection()->send(Messages::DownloadProxy::DidStart(updatedRequest, String()), downloadID.downloadID());
     m_task->setPendingDownloadID(downloadID);
     

trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp

@@ -514 +514 @@
 {
     uint64_t destinationID = networkDataTask.pendingDownloadID().downloadID();
-    downloadProxyConnection()->send(Messages::DownloadProxy::DidStart(updatedRequest, String()), destinationID);
     downloadProxyConnection()->send(Messages::DownloadProxy::DidReceiveResponse(response), destinationID);