Changeset 207187 in webkit

Timestamp:

Oct 11, 2016 9:47:00 PM (8 years ago)

Author:

Chris Dumez

Message:

Update DeviceProximityEvent to stop using legacy [ConstructorTemplate=Event]
​https://bugs.webkit.org/show_bug.cgi?id=163311

Reviewed by Ryosuke Niwa.

Update DeviceProximityEvent to stop using legacy [ConstructorTemplate=Event]
and use a regular constructor instead, as in the specification:

• ​https://www.w3.org/TR/2015/WD-proximity-20150903/#deviceproximityevent-interface

• Modules/proximity/DeviceProximityEvent.cpp:

(WebCore::DeviceProximityEvent::DeviceProximityEvent):

• Modules/proximity/DeviceProximityEvent.h:

(WebCore::DeviceProximityEvent::create):
(WebCore::DeviceProximityEventInit::DeviceProximityEventInit): Deleted.

• Modules/proximity/DeviceProximityEvent.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/proximity/DeviceProximityEvent.cpp (modified) (1 diff)
• Modules/proximity/DeviceProximityEvent.h (modified) (3 diffs)
• Modules/proximity/DeviceProximityEvent.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-11  Chris Dumez  <cdumez@apple.com>
+
+        Update DeviceProximityEvent to stop using legacy [ConstructorTemplate=Event]
+        https://bugs.webkit.org/show_bug.cgi?id=163311
+
+        Reviewed by Ryosuke Niwa.
+
+        Update DeviceProximityEvent to stop using legacy [ConstructorTemplate=Event]
+        and use a regular constructor instead, as in the specification:
+        - https://www.w3.org/TR/2015/WD-proximity-20150903/#deviceproximityevent-interface
+
+        * Modules/proximity/DeviceProximityEvent.cpp:
+        (WebCore::DeviceProximityEvent::DeviceProximityEvent):
+        * Modules/proximity/DeviceProximityEvent.h:
+        (WebCore::DeviceProximityEvent::create):
+        (WebCore::DeviceProximityEventInit::DeviceProximityEventInit): Deleted.
+        * Modules/proximity/DeviceProximityEvent.idl:
+
 2016-10-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 

trunk/Source/WebCore/Modules/proximity/DeviceProximityEvent.cpp

@@ -40 +40 @@
 }
 
-DeviceProximityEvent::DeviceProximityEvent(const AtomicString& eventType, const DeviceProximityEventInit& initializer)
-    : Event(eventType, initializer)
-    , m_value(initializer.value)
-    , m_min(initializer.min)
-    , m_max(initializer.max)
+DeviceProximityEvent::DeviceProximityEvent(const AtomicString& eventType, const Init& initializer, IsTrusted isTrusted)
+    : Event(eventType, initializer, isTrusted)
+    , m_value(initializer.value ? *initializer.value : std::numeric_limits<double>::infinity())
+    , m_min(initializer.min ? *initializer.min : -std::numeric_limits<double>::infinity())
+    , m_max(initializer.max ? *initializer.max : std::numeric_limits<double>::infinity())
 {
 }

trunk/Source/WebCore/Modules/proximity/DeviceProximityEvent.h

@@ -27 +27 @@
 namespace WebCore {
 
-struct DeviceProximityEventInit : public EventInit {
-    DeviceProximityEventInit()
-        : value(std::numeric_limits<double>::infinity())
-        , min(-std::numeric_limits<double>::infinity())
-        , max(std::numeric_limits<double>::infinity())
-    {
-        // Default value of bubbles is true by the Proximity Events spec.
-        // http://www.w3.org/TR/proximity/#deviceproximityevent-interface
-        bubbles = true;
-    };
-
-    double value;
-    double min;
-    double max;
-};
-
 class DeviceProximityEvent : public Event {
 public:
@@ -57 +41 @@
     }
 
-    static Ref<DeviceProximityEvent> create(const AtomicString& type, const DeviceProximityEventInit& initializer)
+    struct Init : EventInit {
+        Optional<double> value;
+        Optional<double> min;
+        Optional<double> max;
+    };
+
+    static Ref<DeviceProximityEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
     {
-        return adoptRef(*new DeviceProximityEvent(type, initializer));
+        return adoptRef(*new DeviceProximityEvent(type, initializer, isTrusted));
     }
 
@@ -71 +61 @@
     DeviceProximityEvent();
     DeviceProximityEvent(const AtomicString& eventType, const double value, const double min, const double max);
-    DeviceProximityEvent(const AtomicString& eventType, const DeviceProximityEventInit&);
+    DeviceProximityEvent(const AtomicString& eventType, const Init&, IsTrusted);
 
     double m_value;

trunk/Source/WebCore/Modules/proximity/DeviceProximityEvent.idl

@@ -20 +20 @@
 [
     Conditional=PROXIMITY_EVENTS,
-    ConstructorTemplate=Event,
+    Constructor(DOMString type, optional DeviceProximityEventInit eventInitDict),
 ] interface DeviceProximityEvent : Event {
-    [InitializedByEventConstructor] readonly attribute unrestricted double value;
-    [InitializedByEventConstructor] readonly attribute unrestricted double min;
-    [InitializedByEventConstructor] readonly attribute unrestricted double max;
+    readonly attribute unrestricted double value;
+    readonly attribute unrestricted double min;
+    readonly attribute unrestricted double max;
 };
 
+dictionary DeviceProximityEventInit : EventInit {
+    double value;
+    double min;
+    double max;
+};