Changeset 20737 in webkit

Timestamp:

Apr 5, 2007 3:50:02 PM (17 years ago)

Author:

kjk

Message:

Reviewed by darin.

Coverity fix. Coverity says:
"Event check_after_deref: Pointer "re" dereferenced before NULL check"

• pcre/pcre_study.c: (pcre_study):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• pcre/pcre_study.c (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-04-05  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
+
+        Reviewed by darin.
+
+        Coverity fix. Coverity says:
+        "Event check_after_deref: Pointer "re" dereferenced before NULL check"
+
+        * pcre/pcre_study.c:
+        (pcre_study):
+
 2007-04-05  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
 

trunk/JavaScriptCore/pcre/pcre_study.c

@@ -410 +410 @@
 const uschar *tables;
 const real_pcre *re = (const real_pcre *)external_re;
-uschar *code = (uschar *)re + re->name_table_offset +
-  (re->name_count * re->name_entry_size);
+uschar *code;
 compile_data compile_block;
 
@@ -421 +420 @@
   return NULL;
   }
+
+code = (uschar *)re + re->name_table_offset +
+  (re->name_count * re->name_entry_size);
 
 if ((options & ~PUBLIC_STUDY_OPTIONS) != 0)