Changeset 207394 in webkit

Timestamp:

Oct 16, 2016 11:59:31 AM (8 years ago)

Author:

Simon Fraser

Message:

Implement serializer = { attribute }
​https://bugs.webkit.org/show_bug.cgi?id=163466

Follow-up fix to die if "serializer {...}" lists an attribute not present
on the interface. I don't think this is testable with the current bindings tests.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateSerializerFunction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-16  Simon Fraser  <simon.fraser@apple.com>
+
+        Implement serializer = { attribute }
+        https://bugs.webkit.org/show_bug.cgi?id=163466
+        
+        Follow-up fix to die if "serializer {...}" lists an attribute not present
+        on the interface. I don't think this is testable with the current bindings tests.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateSerializerFunction):
+
 2016-10-16  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -3985 +3985 @@
     my @serializedAttributes = ();
     foreach my $attribute_name (@{$interface->serializable->attributes}) {
+        my $found_attribute = 0;
         foreach my $attribute (@{$interface->attributes}) {
             if ($attribute_name eq $attribute->signature->name) {
                 push @serializedAttributes, $attribute;
+                $found_attribute = 1;
                 last;
             }
         }
+        
+        die "Failed to find \"serializate\" attribute \"$attribute_name\" in $interfaceName" if !$found_attribute;
     }