Changeset 207488 in webkit


Ignore:
Timestamp:
Oct 18, 2016 2:03:03 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Modern media controls don't update their rendering correctly
https://bugs.webkit.org/show_bug.cgi?id=163603
<rdar://problem/28826022>

Patch by Antoine Quint <Antoine Quint> on 2016-10-18
Reviewed by Dean Jackson.

There are rendering issues when we use an absolutely-positioned element
as the top-most element in a media element's shadow root (webkit.org/b/163592).
Since we only need for that element to be positioned, we can use "position: relative"
instead, which removes the rendering issues.

  • Modules/modern-media-controls/controls/media-controls.css:

(.media-controls):
(.media-controls,): Deleted.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r207487 r207488  
     12016-10-18  Antoine Quint  <graouts@apple.com>
     2
     3        Modern media controls don't update their rendering correctly
     4        https://bugs.webkit.org/show_bug.cgi?id=163603
     5        <rdar://problem/28826022>
     6
     7        Reviewed by Dean Jackson.
     8
     9        There are rendering issues when we use an absolutely-positioned element
     10        as the top-most element in a media element's shadow root (webkit.org/b/163592).
     11        Since we only need for that element to be positioned, we can use "position: relative"
     12        instead, which removes the rendering issues.
     13
     14        * Modules/modern-media-controls/controls/media-controls.css:
     15        (.media-controls):
     16        (.media-controls,): Deleted.
     17
    1182016-10-18  Dean Jackson  <dino@apple.com>
    219
  • trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

    r207299 r207488  
    2424 */
    2525
    26 .media-controls,
     26/* We need to use relative positioning due to webkit.org/b/163603 */
     27.media-controls {
     28    position: relative;
     29}
     30
    2731.media-controls > .controls-bar {
    2832    position: absolute;
Note: See TracChangeset for help on using the changeset viewer.