Changeset 207562 in webkit

Timestamp:

Oct 19, 2016 1:29:02 PM (8 years ago)

Author:

Chris Dumez

Message:

Move HTML Interactive Form Validation behind an experimental flag
​https://bugs.webkit.org/show_bug.cgi?id=163673

Reviewed by Daniel Bates.

Source/WebKit/mac:

Re-disable HTML Interactive Form Validation by default on Mac WK1.

• WebView/WebViewData.mm:

(-[WebViewPrivate init]):

Source/WebKit2:

Move HTML Interactive Form Validation behind an experimental feature flag
and disable by default until by have a better UI.

• Shared/WebPreferencesDefinitions.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Location:

trunk/Source

Files:

• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebViewData.mm (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/WebPreferencesDefinitions.h (modified) (2 diffs)
• WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-10-19  Chris Dumez  <cdumez@apple.com>
+
+        Move HTML Interactive Form Validation behind an experimental flag
+        https://bugs.webkit.org/show_bug.cgi?id=163673
+
+        Reviewed by Daniel Bates.
+
+        Re-disable HTML Interactive Form Validation by default on Mac WK1.
+
+        * WebView/WebViewData.mm:
+        (-[WebViewPrivate init]):
+
 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebViewData.mm

@@ -144 +144 @@
     zoomsTextOnly = NO;
 
-    interactiveFormValidationEnabled = YES;
+    interactiveFormValidationEnabled = NO;
     // The default value should be synchronized with WebCore/page/Settings.cpp.
     validationMessageTimerMagnification = 50;

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-10-19  Chris Dumez  <cdumez@apple.com>
+
+        Move HTML Interactive Form Validation behind an experimental flag
+        https://bugs.webkit.org/show_bug.cgi?id=163673
+
+        Reviewed by Daniel Bates.
+
+        Move HTML Interactive Form Validation behind an experimental feature flag
+        and disable by default until by have a better UI.
+
+        * Shared/WebPreferencesDefinitions.h:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
 2016-10-19  Damian Kaleta  <dkaleta@apple.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -180 +180 @@
     macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false, "", "") \
     macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false, "", "") \
-    macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, true, "", "") \
     macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false, "", "") \
     macro(ScrollAnimatorEnabled, scrollAnimatorEnabled, Bool, bool, DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED, "", "") \
@@ -291 +290 @@
     macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, true, "CSS Spring Animations", "CSS Spring Animation prototype") \
     macro(CustomElementsEnabled, customElementsEnabled, Bool, bool, true, "Custom Elements", "HTML Custom Elements prototype") \
+    macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false, "HTML Interactive Form Validation", "HTML interactive form validation prototype") \
     macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, true, "Gamepads", "Web Gamepad API support") \
     macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, false, "Modern Media Controls", "Use modern media controls look") \

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

@@ -208 +208 @@
 #endif
 
+    if (preference == "WebKitInteractiveFormValidationEnabled")
+        RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(enabled);
+
 #if ENABLE(WEBGL2)
     if (preference == "WebKitWebGL2Enabled")