Changeset 20776 in webkit

Timestamp:

Apr 6, 2007 8:05:13 PM (17 years ago)

Author:

kjk

Message:

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 20709)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,13 @@
+2007-04-04 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>
+
+ Reviewed by darin.
+
+ Coverity fix. Coverity says:
+ "Event var_deref_model: Variable "(this)->clientptr" tracked as NULL was passed to a function that dereferences it."
+
+ * platform/image-decoders/gif/GIFImageReader.cpp:
+ (GIFImageReader::read):
+

2007-04-04 Adele Peterson <​adele@apple.com>

Reviewed by Oliver.

Index: WebCore/platform/image-decoders/gif/GIFImageReader.cpp
===================================================================
--- WebCore/platform/image-decoders/gif/GIFImageReader.cpp (revision 20709)
+++ WebCore/platform/image-decoders/gif/GIFImageReader.cpp (working copy)
@@ -760,7 +760,8 @@ bool GIFImageReader::read(const unsigned

if (query == GIFImageDecoder::GIFSizeQuery

haltAtFrame == images_decoded) {

The decoder needs to stop. Hand back the number of bytes we consumed from
buffer minus 9 (the amount we consumed to read the header).

• clientptr->decodingHalted(len + 9);

+ if (clientptr)
+ clientptr->decodingHalted(len + 9);

GETN(9, gif_image_header);
return true;

}

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/image-decoders/gif/GIFImageReader.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-04-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
+
+        Reviewed by darin.
+
+        Coverity fix. Coverity says:
+        "Event var_deref_model: Variable "(this)->clientptr" tracked as NULL was passed to a function that dereferences it."
+
+        * platform/image-decoders/gif/GIFImageReader.cpp:
+        (GIFImageReader::read):
+
 2007-04-06  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/platform/image-decoders/gif/GIFImageReader.cpp

@@ -761 +761 @@
         // The decoder needs to stop.  Hand back the number of bytes we consumed from
         // buffer minus 9 (the amount we consumed to read the header).
-        clientptr->decodingHalted(len + 9);
+        if (clientptr)
+            clientptr->decodingHalted(len + 9);
         GETN(9, gif_image_header);
         return true;