Changeset 207807 in webkit

Timestamp:

Oct 24, 2016 10:22:40 PM (8 years ago)

Author:

mitz@apple.com

Message:

REGRESSION (r206410): Sandbox violations beneath WebProcessProxy::platformIsBeingDebugged
​https://bugs.webkit.org/show_bug.cgi?id=163879
<rdar://problem/28728735>

Reviewed by Darin Adler.

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:

(WebKit::WebProcessProxy::platformIsBeingDebugged): Check if the current process, which is

the UI process, is sandboxed before trying to find out if the Web process is being
debugged.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WebProcessProxyCocoa.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-10-24  Dan Bernstein  <mitz@apple.com>
+
+        REGRESSION (r206410): Sandbox violations beneath WebProcessProxy::platformIsBeingDebugged
+        https://bugs.webkit.org/show_bug.cgi?id=163879
+        <rdar://problem/28728735>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+        (WebKit::WebProcessProxy::platformIsBeingDebugged): Check if the current process, which is
+          the UI process, is sandboxed before trying to find out if the Web process is being
+          debugged.
+
 2016-10-21  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessProxyCocoa.mm

@@ -28 +28 @@
 
 #import "ObjCObjectGraph.h"
+#import "SandboxUtilities.h"
 #import "WKBrowsingContextControllerInternal.h"
 #import "WKBrowsingContextHandleInternal.h"
@@ -124 +125 @@
 bool WebProcessProxy::platformIsBeingDebugged() const
 {
+    // If the UI process is sandboxed, it cannot find out whether other processes are being debugged.
+    if (processIsSandboxed(getpid()))
+        return false;
+
     struct kinfo_proc info;
     int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_PID, processIdentifier() };