Changeset 207826 in webkit

Timestamp:

Oct 25, 2016 10:27:00 AM (7 years ago)

Author:

Konstantin Tokarev

Message:

[cmake] Don't add -fPIC flag when on Windows (MinGW)
​https://bugs.webkit.org/show_bug.cgi?id=163949

Reviewed by Michael Catanzaro.

-fPIC flag does not do anything on Windows and produces warning noise
with MinGW. There is no position independent code in Unix sense on
32-bit Windows, and 64-bit Windows code is always relocatable.

For reference see
​https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html

• Source/cmake/WebKitHelpers.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/WebKitHelpers.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2016-10-25  Konstantin Tokarev  <annulen@yandex.ru>
+
+        [cmake] Don't add -fPIC flag when on Windows (MinGW)
+        https://bugs.webkit.org/show_bug.cgi?id=163949
+
+        Reviewed by Michael Catanzaro.
+
+        -fPIC flag does not do anything on Windows and produces warning noise
+        with MinGW. There is no position independent code in Unix sense on
+        32-bit Windows, and 64-bit Windows code is always relocatable.
+
+        For reference see
+        https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html
+
+        * Source/cmake/WebKitHelpers.cmake:
+
 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/cmake/WebKitHelpers.cmake

@@ -11 +11 @@
         endif ()
 
-        get_target_property(TARGET_TYPE ${_target} TYPE)
-        if (${TARGET_TYPE} STREQUAL "STATIC_LIBRARY") # -fPIC is automatically added to shared libraries
-            set(OLD_COMPILE_FLAGS "-fPIC ${OLD_COMPILE_FLAGS}")
+        if (NOT WIN32)
+            get_target_property(TARGET_TYPE ${_target} TYPE)
+            if (${TARGET_TYPE} STREQUAL "STATIC_LIBRARY") # -fPIC is automatically added to shared libraries
+                set(OLD_COMPILE_FLAGS "-fPIC ${OLD_COMPILE_FLAGS}")
+            endif ()
         endif ()