Changeset 207852 in webkit

Timestamp:

Oct 25, 2016 3:41:09 PM (8 years ago)

Author:

jfbastien@apple.com

Message:

Remove redundant argument count check

Indexing argument out of bounds already returns jsUndefined().

Remove redundant argument count check
​https://bugs.webkit.org/show_bug.cgi?id=163957

Reviewed by Keith Miller.

• runtime/ErrorConstructor.cpp:

(JSC::Interpreter::constructWithErrorConstructor):
(JSC::Interpreter::callErrorConstructor):

• wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::constructJSWebAssemblyRuntimeError):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/ErrorConstructor.cpp (modified) (2 diffs)
• wasm/js/WebAssemblyRuntimeErrorConstructor.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-10-25  JF Bastien  <jfbastien@apple.com>
+
+        Remove redundant argument count check
+
+        Indexing argument out of bounds already returns jsUndefined().
+
+        Remove redundant argument count check
+        https://bugs.webkit.org/show_bug.cgi?id=163957
+
+        Reviewed by Keith Miller.
+
+        * runtime/ErrorConstructor.cpp:
+        (JSC::Interpreter::constructWithErrorConstructor):
+        (JSC::Interpreter::callErrorConstructor):
+        * wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:
+        (JSC::constructJSWebAssemblyRuntimeError):
+
 2016-10-25  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ErrorConstructor.cpp

@@ -53 +53 @@
     VM& vm = exec->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
-    JSValue message = exec->argumentCount() ? exec->argument(0) : jsUndefined();
+    JSValue message = exec->argument(0);
     Structure* errorStructure = InternalFunction::createSubclassStructure(exec, exec->newTarget(), asInternalFunction(exec->callee())->globalObject()->errorStructure());
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
@@ -67 +67 @@
 EncodedJSValue JSC_HOST_CALL Interpreter::callErrorConstructor(ExecState* exec)
 {
-    JSValue message = exec->argumentCount() ? exec->argument(0) : jsUndefined();
+    JSValue message = exec->argument(0);
     Structure* errorStructure = asInternalFunction(exec->callee())->globalObject()->errorStructure();
     return JSValue::encode(ErrorInstance::create(exec, errorStructure, message, nullptr, TypeNothing, false));

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.cpp

@@ -49 +49 @@
     auto& vm = state->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
-    JSValue message = state->argumentCount() ? state->argument(0) : jsUndefined();
+    JSValue message = state->argument(0);
     auto* structure = InternalFunction::createSubclassStructure(state, state->newTarget(), asInternalFunction(state->callee())->globalObject()->WebAssemblyRuntimeErrorStructure());
     RETURN_IF_EXCEPTION(scope, encodedJSValue());