Changeset 207860 in webkit


Ignore:
Timestamp:
Oct 25, 2016 6:15:36 PM (7 years ago)
Author:
n_wang@apple.com
Message:

LayoutTest accessibility/mac/meter-gauge-value-description.html failing
https://bugs.webkit.org/show_bug.cgi?id=163997
<rdar://problem/28948637>

Reviewed by Chris Fleizach.

Source/WebCore:

I hand-edited the Localizable.strings file in a previous patch and my changes
were replaced by running update-webkit-localizable-strings script. Changed the
key to be the same as the value to keep consistency with other entries.

Re-enabled the failing test.

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::AXMeterGaugeRegionOptimumText):
(WebCore::AXMeterGaugeRegionSuboptimalText):
(WebCore::AXMeterGaugeRegionLessGoodText):

LayoutTests:

  • platform/mac/TestExpectations:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r207858 r207860  
     12016-10-25  Nan Wang  <n_wang@apple.com>
     2
     3        LayoutTest accessibility/mac/meter-gauge-value-description.html failing
     4        https://bugs.webkit.org/show_bug.cgi?id=163997
     5        <rdar://problem/28948637>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        * platform/mac/TestExpectations:
     10
    1112016-10-25  Ryan Haddad  <ryanhaddad@apple.com>
    212
  • trunk/LayoutTests/platform/mac/TestExpectations

    r207858 r207860  
    14871487webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size-iframe.html [ Skip ]
    14881488webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size.html [ Skip ]
    1489 
    1490 webkit.org/b/163997 accessibility/mac/meter-gauge-value-description.html [ Failure ]
  • trunk/Source/WebCore/ChangeLog

    r207855 r207860  
     12016-10-25  Nan Wang  <n_wang@apple.com>
     2
     3        LayoutTest accessibility/mac/meter-gauge-value-description.html failing
     4        https://bugs.webkit.org/show_bug.cgi?id=163997
     5        <rdar://problem/28948637>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        I hand-edited the Localizable.strings file in a previous patch and my changes
     10        were replaced by running update-webkit-localizable-strings script. Changed the
     11        key to be the same as the value to keep consistency with other entries.
     12
     13        Re-enabled the failing test.
     14
     15        * English.lproj/Localizable.strings:
     16        * platform/LocalizedStrings.cpp:
     17        (WebCore::AXMeterGaugeRegionOptimumText):
     18        (WebCore::AXMeterGaugeRegionSuboptimalText):
     19        (WebCore::AXMeterGaugeRegionLessGoodText):
     20
    1212016-10-25  Filip Pizlo  <fpizlo@apple.com>
    222
  • trunk/Source/WebCore/English.lproj/Localizable.strings

    r207853 r207860  
    936936
    937937/* The less good value description for a meter element. */
    938 "less good" = "less good";
     938"critical value" = "critical value";
    939939
    940940/* accessibility role description for link */
     
    10231023
    10241024/* The optimum value description for a meter element. */
    1025 "optimum" = "optimum";
     1025"optimal value" = "optimal value";
    10261026
    10271027/* accessibility role description for an output element */
     
    11311131
    11321132/* The suboptimal value description for a meter element. */
    1133 "suboptimal" = "suboptimal";
     1133"suboptimal value" = "suboptimal value";
    11341134
    11351135/* HTTP result code string */
  • trunk/Source/WebCore/platform/LocalizedStrings.cpp

    r207853 r207860  
    790790String AXMeterGaugeRegionOptimumText()
    791791{
    792     return WEB_UI_STRING("optimum", "The optimum value description for a meter element.");
     792    return WEB_UI_STRING("optimal value", "The optimum value description for a meter element.");
    793793}
    794794
    795795String AXMeterGaugeRegionSuboptimalText()
    796796{
    797     return WEB_UI_STRING("suboptimal", "The suboptimal value description for a meter element.");
     797    return WEB_UI_STRING("suboptimal value", "The suboptimal value description for a meter element.");
    798798}
    799799
    800800String AXMeterGaugeRegionLessGoodText()
    801801{
    802     return WEB_UI_STRING("less good", "The less good value description for a meter element.");
     802    return WEB_UI_STRING("critical value", "The less good value description for a meter element.");
    803803}
    804804#endif // ENABLE(METER_ELEMENT)
Note: See TracChangeset for help on using the changeset viewer.