Changeset 208000 in webkit


Ignore:
Timestamp:
Oct 27, 2016 1:08:51 PM (8 years ago)
Author:
Chris Dumez
Message:

Element parameter to CanvasRenderingContext2D.drawFocusIfNeeded() should not be nullable
​https://bugs.webkit.org/show_bug.cgi?id=164062

Reviewed by Darin Adler.

Source/WebCore:

Element parameter to CanvasRenderingContext2D.drawFocusIfNeeded() should not be nullable:

Firefox and Chrome agree with the specification.

Test: fast/canvas/draw-focus-if-needed-null-element.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawFocusIfNeeded):
(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

Add layout test coverage.

  • fast/canvas/draw-focus-if-needed-null-element-expected.txt: Added.
  • fast/canvas/draw-focus-if-needed-null-element.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r207995 r208000  
     12016-10-27  Chris Dumez  <cdumez@apple.com>
     2
     3        Element parameter to CanvasRenderingContext2D.drawFocusIfNeeded() should not be nullable
     4        https://bugs.webkit.org/show_bug.cgi?id=164062
     5
     6        Reviewed by Darin Adler.
     7
     8        Add layout test coverage.
     9
     10        * fast/canvas/draw-focus-if-needed-null-element-expected.txt: Added.
     11        * fast/canvas/draw-focus-if-needed-null-element.html: Added.
     12
    1132016-10-27  Chris Dumez  <cdumez@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r207999 r208000  
     12016-10-27  Chris Dumez  <cdumez@apple.com>
     2
     3        Element parameter to CanvasRenderingContext2D.drawFocusIfNeeded() should not be nullable
     4        https://bugs.webkit.org/show_bug.cgi?id=164062
     5
     6        Reviewed by Darin Adler.
     7
     8        Element parameter to CanvasRenderingContext2D.drawFocusIfNeeded() should not be nullable:
     9        - https://html.spec.whatwg.org/#canvasuserinterface
     10
     11        Firefox and Chrome agree with the specification.
     12
     13        Test: fast/canvas/draw-focus-if-needed-null-element.html
     14
     15        * html/canvas/CanvasRenderingContext2D.cpp:
     16        (WebCore::CanvasRenderingContext2D::drawFocusIfNeeded):
     17        (WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal):
     18        * html/canvas/CanvasRenderingContext2D.h:
     19        * html/canvas/CanvasRenderingContext2D.idl:
     20
    1212016-10-27  Yusuke Suzuki  <utatane.tea@gmail.com>
    222

  • trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp

    r207720 r208000  
    20422042}
    20432043
    2044 void CanvasRenderingContext2D::drawFocusIfNeeded(Element* element)
     2044void CanvasRenderingContext2D::drawFocusIfNeeded(Element& element)
    20452045{
    20462046    drawFocusIfNeededInternal(m_path, element);
    20472047}
    20482048
    2049 void CanvasRenderingContext2D::drawFocusIfNeeded(DOMPath& path, Element* element)
     2049void CanvasRenderingContext2D::drawFocusIfNeeded(DOMPath& path, Element& element)
    20502050{
    20512051    drawFocusIfNeededInternal(path.path(), element);
    20522052}
    20532053
    2054 void CanvasRenderingContext2D::drawFocusIfNeededInternal(const Path& path, Element* element)
     2054void CanvasRenderingContext2D::drawFocusIfNeededInternal(const Path& path, Element& element)
    20552055{
    20562056    GraphicsContext* context = drawingContext();
    20572057
    2058     if (!element || !element->focused() || !state().hasInvertibleTransform || path.isEmpty() || !element->isDescendantOf(canvas()) || !context)
     2058    if (!element.focused() || !state().hasInvertibleTransform || path.isEmpty() || !element.isDescendantOf(canvas()) || !context)
    20592059        return;
    20602060

  • trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h

    r207720 r208000  
    198198    void webkitPutImageDataHD(ImageData&, float dx, float dy, float dirtyX, float dirtyY, float dirtyWidth, float dirtyHeight);
    199199
    200     void drawFocusIfNeeded(Element*);
    201     void drawFocusIfNeeded(DOMPath&, Element*);
     200    void drawFocusIfNeeded(Element&);
     201    void drawFocusIfNeeded(DOMPath&, Element&);
    202202
    203203    float webkitBackingStorePixelRatio() const { return 1; }
    … …  
    354354    bool isPointInStrokeInternal(const Path&, float x, float y);
    355355
    356     void drawFocusIfNeededInternal(const Path&, Element*);
     356    void drawFocusIfNeededInternal(const Path&, Element&);
    357357
    358358    void clearCanvas();

  • trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

    r207720 r208000  
    177177   
    178178    // Focus rings
    179     void drawFocusIfNeeded(Element? element); // FIXME: The element parameter should not be nullable.
    180     void drawFocusIfNeeded(DOMPath path, Element? element); // FIXME: The element parameter should not be nullable.
     179    void drawFocusIfNeeded(Element element);
     180    void drawFocusIfNeeded(DOMPath path, Element element);
    181181
    182182    readonly attribute float webkitBackingStorePixelRatio;
Note: See TracChangeset for help on using the changeset viewer.