Changeset 208039 in webkit

Timestamp:

Oct 27, 2016 11:27:29 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[Fetch API] Fetch ReadableStream should only clone the second branch
​https://bugs.webkit.org/show_bug.cgi?id=164058

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-27
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-clone-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/streams/ReadableStreamInternals.js:

(readableStreamTeePullFunction):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/streams/ReadableStreamInternals.js (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-10-27  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Fetch ReadableStream should only clone the second branch
+        https://bugs.webkit.org/show_bug.cgi?id=164058
+
+        Reviewed by Darin Adler.
+
+        * web-platform-tests/fetch/api/response/response-clone-expected.txt:
+
 2016-10-27  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt

@@ -7 +7 @@
 PASS Cloned responses should provide the same data 
 PASS Cancelling stream should not affect cloned one 
-FAIL Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
-FAIL Check response clone use structureClone for teed ReadableStreams (DataViewchunk) assert_true: Buffer of being-cloned response stream is the same as the original buffer expected true got false
+PASS Check response clone use structureClone for teed ReadableStreams (Int8Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Int16Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Int32Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (ArrayBufferchunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint8ClampedArraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint16Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Uint32Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Float32Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (Float64Arraychunk) 
+PASS Check response clone use structureClone for teed ReadableStreams (DataViewchunk) 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-27  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Fetch ReadableStream should only clone the second branch
+        https://bugs.webkit.org/show_bug.cgi?id=164058
+
+        Reviewed by Darin Adler.
+
+        Covered by rebased tests.
+
+        * Modules/streams/ReadableStreamInternals.js:
+        (readableStreamTeePullFunction):
+
 2016-10-27  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js

@@ -184 +184 @@
                 return;
             if (!teeState.canceled1)
-                @readableStreamDefaultControllerEnqueue(teeState.branch1.@readableStreamController, shouldClone ? @doStructuredClone(result.value) : result.value);
+                @readableStreamDefaultControllerEnqueue(teeState.branch1.@readableStreamController, result.value);
             if (!teeState.canceled2)
                 @readableStreamDefaultControllerEnqueue(teeState.branch2.@readableStreamController, shouldClone ? @doStructuredClone(result.value) : result.value);