Changeset 20814 in webkit

Timestamp:

Apr 9, 2007 5:06:35 PM (17 years ago)

Author:

andersca

Message:

WebCore:

Reviewed by John.

• WebCore.exp: Add ZNK7WebCore11FrameLoader10isCompleteEv.

WebKit:

Reviewed by John.

<rdar://problem/5081860>
REGRESSION: Select All for standalone image has no visible effect but does change state

<rdar://problem/5081840>
REGRESSION: context menu in white space beyond standalone image is different after Select All

Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:

• For full-frame plugins, always return false.
• For images, only return true if the selector is copy: and the image has finished loading.

• WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]):

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebView/WebHTMLView.mm (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-04-09  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by John.
+
+        * WebCore.exp:
+        Add __ZNK7WebCore11FrameLoader10isCompleteEv.
+        
 2007-04-09  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/WebCore.exp

@@ -486 +486 @@
 __ZNK7WebCore11CachedImage5imageEv
 __ZNK7WebCore11ContextMenu19platformDescriptionEv
+__ZNK7WebCore11FrameLoader10isCompleteEv
 __ZNK7WebCore11FrameLoader14documentLoaderEv
 __ZNK7WebCore11FrameLoader15containsPluginsEv

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-04-09  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by John.
+
+        <rdar://problem/5081860>
+        REGRESSION: Select All for standalone image has no visible effect but does change state
+        
+        <rdar://problem/5081840>
+        REGRESSION: context menu in white space beyond standalone image is different after Select All
+        
+        Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:
+        
+        - For full-frame plugins, always return false.
+        - For images, only return true if the selector is copy: and the image has finished loading.
+        
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView validateUserInterfaceItem:]):
+
 2007-04-09  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKit/WebView/WebHTMLView.mm

@@ -82 +82 @@
 #import <WebCore/FocusController.h>
 #import <WebCore/Frame.h>
+#import <WebCore/FrameLoader.h>
 #import <WebCore/HitTestResult.h>
 #import <WebCore/Image.h>
@@ -2117 +2118 @@
     Frame* frame = core([self _frame]);
 
+    if (Document* doc = frame->document()) {
+        if (doc->isPluginDocument())
+            return NO;
+        
+        if (doc->isImageDocument()) {            
+            if (action == @selector(copy:))
+                return frame->loader()->isComplete();
+        
+            return NO;
+        }
+    }
+    
     if (action == @selector(changeSpelling:)
             || action == @selector(_changeSpellingFromMenu:)