Changeset 208969 in webkit

Timestamp:

Nov 22, 2016, 8:05:21 PM (9 years ago)

Author:

mitz@apple.com

Message:

[Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
​https://bugs.webkit.org/show_bug.cgi?id=165036
<rdar://problem/5708580>

Reviewed by Alexey Proskuryakov.

• WebView/WebHTMLView.mm:

(-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,

similarly to what we do in -keyDown: and to what WKWebView does with all key events.

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebHTMLView.mm (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-11-22  Dan Bernstein  <mitz@apple.com>
+
+        [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
+        https://bugs.webkit.org/show_bug.cgi?id=165036
+        <rdar://problem/5708580>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
+          similarly to what we do in -keyDown: and to what WKWebView does with all key events.
+
 2016-11-21  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

@@ -5530 +5530 @@
             ret = frame->eventHandler().keyEvent(event);
 
-    if (!ret)
+    if (ret)
+        [NSCursor setHiddenUntilMouseMoves:YES];
+    else
         ret = [self _handleStyleKeyEquivalent:event] || [super performKeyEquivalent:event];