Changeset 209005 in webkit

Timestamp:

Nov 28, 2016 12:27:39 PM (7 years ago)

Author:

Brent Fulgham

Message:

ImageData does not match specification
​https://bugs.webkit.org/show_bug.cgi?id=164663

Reviewed by Simon Fraser.

The W3C specification ​https://www.w3.org/TR/2dcontext/ clearly states that
the width and height attributes of the ImageData type should be unsigned.
Our current implementation has signed integer values.

In practice, we have enforced the unsigned requirement by throwing a TypeError
if you attempt to construct an ImageData with negative width or height.

This change simply updates the IDL and impelemntation to match the spec.

Test coverage is already provided by fast/canvas/canvas-imageData.html

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readTerminal): Serialize as uint32_t values.

• html/ImageData.idl: Revise width and height to be unsigned long.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/SerializedScriptValue.cpp (modified) (1 diff)
• html/ImageData.idl (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-11-28  Brent Fulgham  <bfulgham@apple.com>
+
+        ImageData does not match specification
+        https://bugs.webkit.org/show_bug.cgi?id=164663
+
+        Reviewed by Simon Fraser.
+
+        The W3C specification https://www.w3.org/TR/2dcontext/ clearly states that
+        the width and height attributes of the ImageData type should be unsigned.
+        Our current implementation has signed integer values.
+
+        In practice, we have enforced the unsigned requirement by throwing a TypeError
+        if you attempt to construct an ImageData with negative width or height.
+
+        This change simply updates the IDL and impelemntation to match the spec.
+
+        Test coverage is already provided by fast/canvas/canvas-imageData.html
+
+        * bindings/js/SerializedScriptValue.cpp:
+        (WebCore::CloneDeserializer::readTerminal): Serialize as uint32_t values.
+        * html/ImageData.idl: Revise width and height to be unsigned long.
+
 2016-11-28  Dave Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp

@@ -2265 +2265 @@
         }
         case ImageDataTag: {
-            int32_t width;
+            uint32_t width;
             if (!read(width))
                 return JSValue();
-            int32_t height;
+            uint32_t height;
             if (!read(height))
                 return JSValue();

trunk/Source/WebCore/html/ImageData.idl

@@ -1 +1 @@
 /*
- * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2009, 2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -35 +35 @@
     ImplementationLacksVTable,
 ] interface ImageData {
-    readonly attribute long width;
-    readonly attribute long height;
+    readonly attribute unsigned long width;
+    readonly attribute unsigned long height;
     readonly attribute Uint8ClampedArray data;
 };