Changeset 209168 in webkit

Timestamp:

Nov 30, 2016 6:42:28 PM (7 years ago)

Author:

beidson@apple.com

Message:

IndexedDB: When doing puts, don't "updateAllIndexesForAddRecord" if there are no indexes.
​https://bugs.webkit.org/show_bug.cgi?id=165215

Reviewed by Alex Christensen.

No new tests (No observable behavior change).

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Don't "updateAllIndexesForAddRecord" if there are no indexes.

Avoiding this saved us some IDBKey serialization and Javascript object manipulation.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-11-30  Brady Eidson  <beidson@apple.com>
+
+        IndexedDB: When doing puts, don't "updateAllIndexesForAddRecord" if there are no indexes.
+        https://bugs.webkit.org/show_bug.cgi?id=165215
+
+        Reviewed by Alex Christensen.
+
+        No new tests (No observable behavior change).
+
+        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
+        (WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Don't "updateAllIndexesForAddRecord" if there are no indexes.
+          Avoiding this saved us some IDBKey serialization and Javascript object manipulation.
+
 2016-11-30  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp

@@ -1661 +1661 @@
     }
 
-    auto error = updateAllIndexesForAddRecord(objectStoreInfo, keyData, value.data());
-
-    if (!error.isNull()) {
-        auto* sql = cachedStatement(SQL::DeleteObjectStoreRecord, ASCIILiteral("DELETE FROM Records WHERE objectStoreID = ? AND key = CAST(? AS TEXT);"));
-        if (!sql
-            || sql->bindInt64(1, objectStoreInfo.identifier()) != SQLITE_OK
-            || sql->bindBlob(2, keyBuffer->data(), keyBuffer->size()) != SQLITE_OK
-            || sql->step() != SQLITE_DONE) {
-            LOG_ERROR("Indexing new object store record failed, but unable to remove the object store record itself");
-            return { IDBDatabaseException::UnknownError, ASCIILiteral("Indexing new object store record failed, but unable to remove the object store record itself") };
-        }
-
-        return error;
+    if (!objectStoreInfo.indexMap().isEmpty()) {
+        auto error = updateAllIndexesForAddRecord(objectStoreInfo, keyData, value.data());
+
+        if (!error.isNull()) {
+            auto* sql = cachedStatement(SQL::DeleteObjectStoreRecord, ASCIILiteral("DELETE FROM Records WHERE objectStoreID = ? AND key = CAST(? AS TEXT);"));
+            if (!sql
+                || sql->bindInt64(1, objectStoreInfo.identifier()) != SQLITE_OK
+                || sql->bindBlob(2, keyBuffer->data(), keyBuffer->size()) != SQLITE_OK
+                || sql->step() != SQLITE_DONE) {
+                LOG_ERROR("Indexing new object store record failed, but unable to remove the object store record itself");
+                return { IDBDatabaseException::UnknownError, ASCIILiteral("Indexing new object store record failed, but unable to remove the object store record itself") };
+            }
+
+            return error;
+        }
     }
 
@@ -1729 +1731 @@
     transaction->notifyCursorsOfChanges(objectStoreInfo.identifier());
 
-    return error;
+    return { };
 }