Changeset 209350 in webkit

Timestamp:

Dec 5, 2016 2:20:08 PM (7 years ago)

Author:

caitp@igalia.com

Message:

[JSC] report unexpected token when "async" is followed by identifier
​https://bugs.webkit.org/show_bug.cgi?id=165091

Reviewed by Mark Lam.

JSTests:

• stress/bug-165091.js:

Source/JavaScriptCore:

Report a SyntaxError, in order to report correct error in contexts
an async ArrowFunction cannot occur. Also corrects errors in comment
describing JSTokenType bitfield, which was added in r209293.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

• parser/ParserTokens.h:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/bug-165091.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (1 diff)
• Source/JavaScriptCore/parser/ParserTokens.h (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2016-12-05  Caitlin Potter  <caitp@igalia.com>
+
+        [JSC] report unexpected token when "async" is followed by identifier 
+        https://bugs.webkit.org/show_bug.cgi?id=165091
+
+        Reviewed by Mark Lam.
+
+        * stress/bug-165091.js:
+
 2016-12-05  Keith Miller  <keith_miller@apple.com>
 

trunk/JSTests/stress/bug-165091.js

@@ -11 +11 @@
 }
 
-shouldThrowSyntaxError("0/-async J", "SyntaxError: Cannot parse member expression.")
+shouldThrowSyntaxError("0/-async J", "Unexpected identifier 'J'")
+

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-12-05  Caitlin Potter  <caitp@igalia.com>
+
+        [JSC] report unexpected token when "async" is followed by identifier 
+        https://bugs.webkit.org/show_bug.cgi?id=165091
+
+        Reviewed by Mark Lam.
+
+        Report a SyntaxError, in order to report correct error in contexts
+        an async ArrowFunction cannot occur. Also corrects errors in comment
+        describing JSTokenType bitfield, which was added in r209293.
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseMemberExpression):
+        * parser/ParserTokens.h:
+
 2016-12-05  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -4477 +4477 @@
                 // AsyncArrowFunction
                 forceClassifyExpressionError(ErrorIndicatesAsyncArrowFunction);
-                return 0;
+                failDueToUnexpectedToken();
             }
             baseIsAsyncKeyword = true;

trunk/Source/JavaScriptCore/parser/ParserTokens.h

@@ -35 +35 @@
 
 enum {
-    // Token Bitfield: 0b000000000RTEIIIIIIIIPPPPKUXXXXXX
+    // Token Bitfield: 0b000000000RTE000IIIIPPPPKUXXXXXXX
     // R = right-associative bit
     // T = unterminated error flag