Changeset 209409 in webkit


Ignore:
Timestamp:
Dec 6, 2016 11:39:32 AM (7 years ago)
Author:
Simon Fraser
Message:

Enable visual viewports by default on Mac, and iOS Wk2
​https://bugs.webkit.org/show_bug.cgi?id=165452

Reviewed by Zalan Bujtas.

Source/WebCore:

Some tests revealed an issue where, during scrollbar updates, the visual viewport would be
15px wider than the layout viewport, which results in the layout viewport shifting 15px to the
right. Prevent this by disallowing viewport updates during the AdjustViewSize phase; we'll
be called again in postLayoutTasks.

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayoutViewport):

Source/WebKit/mac:

Turn visual viewports on by default for WK1 on Mac.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WebKit2:

Turn visual viewports on by default for WK2.

  • Shared/WebPreferencesDefinitions.h:

LayoutTests:

Skip, fix or adjust tests for visual viewports.

  • TestExpectations:
  • animations/trigger-container-scroll-boundaries.html:
  • animations/trigger-container-scroll-empty.html:
  • animations/trigger-container-scroll-simple.html:
  • compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • fast/scrolling/ios/remove-scrolling-role-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed.html:
  • platform/ios-simulator-wk2/compositing/geometry/fixed-in-composited-expected.txt: Removed.
  • platform/ios-simulator-wk2/compositing/geometry/limit-layer-bounds-fixed-expected.txt:
  • platform/ios-simulator-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/ios-simulator-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/ios-simulator-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt:
  • platform/ios-simulator-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/ios-simulator/compositing/absolute-inside-out-of-view-fixed-expected.txt:
  • platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt:
  • scrollingcoordinator/ios/non-stable-viewport-scroll-expected.txt:
  • scrollingcoordinator/ios/ui-scrolling-tree-expected.txt:
  • tiled-drawing/fixed-layout-size-fixed-attachment-cover.html:
  • tiled-drawing/fixed-layout-size-fixed-attachment-local.html:
  • tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt:
  • tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
  • tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
  • tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
  • tiled-drawing/scrolling/fixed/four-bars-expected.txt:
  • tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
  • tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
  • tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
  • tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
  • tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt:
  • tiled-drawing/scrolling/frames/frameset-frame-scrollability-expected.txt:
  • tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt:
  • tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt:
  • tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
  • tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
  • tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt:
  • tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
  • tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
  • tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:
Location:
trunk
Files:
1 deleted
56 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r209406 r209409  
     12016-12-06  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Enable visual viewports by default on Mac, and iOS Wk2
     4        https://bugs.webkit.org/show_bug.cgi?id=165452
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Skip, fix or adjust tests for visual viewports.
     9
     10        * TestExpectations:
     11        * animations/trigger-container-scroll-boundaries.html:
     12        * animations/trigger-container-scroll-empty.html:
     13        * animations/trigger-container-scroll-simple.html:
     14        * compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
     15        * compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
     16        * compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
     17        * fast/scrolling/ios/remove-scrolling-role-expected.txt:
     18        * fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
     19        * fast/zooming/client-rect-in-fixed-zoomed.html:
     20        * platform/ios-simulator-wk2/compositing/geometry/fixed-in-composited-expected.txt: Removed.
     21        * platform/ios-simulator-wk2/compositing/geometry/limit-layer-bounds-fixed-expected.txt:
     22        * platform/ios-simulator-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
     23        * platform/ios-simulator-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
     24        * platform/ios-simulator-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt:
     25        * platform/ios-simulator-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt:
     26        * platform/ios-simulator/compositing/absolute-inside-out-of-view-fixed-expected.txt:
     27        * platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt:
     28        * scrollingcoordinator/ios/non-stable-viewport-scroll-expected.txt:
     29        * scrollingcoordinator/ios/ui-scrolling-tree-expected.txt:
     30        * tiled-drawing/fixed-layout-size-fixed-attachment-cover.html:
     31        * tiled-drawing/fixed-layout-size-fixed-attachment-local.html:
     32        * tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
     33        * tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt:
     34        * tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
     35        * tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
     36        * tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
     37        * tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
     38        * tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
     39        * tiled-drawing/scrolling/fixed/four-bars-expected.txt:
     40        * tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
     41        * tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
     42        * tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
     43        * tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
     44        * tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
     45        * tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
     46        * tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
     47        * tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
     48        * tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
     49        * tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
     50        * tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt:
     51        * tiled-drawing/scrolling/frames/frameset-frame-scrollability-expected.txt:
     52        * tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt:
     53        * tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt:
     54        * tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
     55        * tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
     56        * tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt:
     57        * tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
     58        * tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
     59        * tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:
     60
    1612016-12-06  Ryan Haddad  <ryanhaddad@apple.com>
    262

  • trunk/LayoutTests/TestExpectations

    r209406 r209409  
    10841084webkit.org/b/165195 svg/dom/rgb-color-parser.html [ Pass Failure ]
    10851085
     1086# Visual viewports
     1087webkit.org/b/165460 compositing/repaint/scroll-fixed-layer-no-content.html [ Failure ]
     1088webkit.org/b/165460 compositing/repaint/scroll-fixed-layer-out-of-view.html [ Failure ]
     1089webkit.org/b/165465 tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed.html [ Failure ]

  • trunk/LayoutTests/animations/trigger-container-scroll-boundaries.html

    r181778 r209409  
    4141    window.testRunner.waitUntilDone();
    4242}
     43
     44if (window.internals)
     45    window.internals.settings.setVisualViewportEnabled(false);
    4346
    4447function runTest() {

  • trunk/LayoutTests/animations/trigger-container-scroll-empty.html

    r181778 r209409  
    3939}
    4040
     41if (window.internals)
     42    window.internals.settings.setVisualViewportEnabled(false);
     43
    4144function runTest() {
    4245    results = document.getElementById("results");

  • trunk/LayoutTests/animations/trigger-container-scroll-simple.html

    r181659 r209409  
    3939}
    4040
     41if (window.internals)
     42    window.internals.settings.setVisualViewportEnabled(false);
     43
    4144function runTest() {
    4245    results = document.getElementById("results");

  • trunk/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html

    r138840 r209409  
    2626<script>
    2727  if (window.internals) {
     28    window.internals.settings.setVisualViewportEnabled(false);
    2829    window.internals.settings.setAcceleratedCompositingForFixedPositionEnabled(true);
    2930    window.internals.settings.setFixedPositionCreatesStackingContext(true);

  • trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt

    r180107 r209409  
    3333      (children 2
    3434        (GraphicsLayer
    35           (position 600.00 0.00)
     35          (position 1400.00 600.00)
    3636          (bounds 10.00 10.00)
    3737          (contentsOpaque 1)
    3838        )
    3939        (GraphicsLayer
     40          (position 800.00 600.00)
    4041          (bounds 10.00 10.00)
    4142          (contentsOpaque 1)

  • trunk/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt

    r180107 r209409  
    3434      (children 2
    3535        (GraphicsLayer
    36           (position 600.00 0.00)
     36          (position 1400.00 600.00)
    3737          (bounds 10.00 10.00)
    3838          (contentsOpaque 1)
    3939        )
    4040        (GraphicsLayer
     41          (position 800.00 600.00)
    4142          (bounds 10.00 10.00)
    4243          (contentsOpaque 1)

  • trunk/LayoutTests/fast/scrolling/ios/remove-scrolling-role-expected.txt

    r200636 r209409  
    22  (scrollable area size 800 600)
    33  (contents size 800 2513)
     4  (layout viewport at (0,0) size 800x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,1913))
    47  (children 1
    58    (Overflow scrolling node

  • trunk/LayoutTests/fast/zooming/client-rect-in-fixed-zoomed-expected.txt

    r209297 r209409  
    55
    66PASS internals.pageScaleFactor() is 2
    7 PASS JSON.stringify(clientRect) is JSON.stringify({top: 9.515625, right: 42, bottom: 19.515625, left: 22, width: 20, height: 10})
     7PASS JSON.stringify(clientRect) is JSON.stringify({top: -108, right: 42, bottom: -98, left: 22, width: 20, height: 10})
    88PASS successfullyParsed is true
    99

  • trunk/LayoutTests/fast/zooming/client-rect-in-fixed-zoomed.html

    r209297 r209409  
    4141            clientRect = box.getBoundingClientRect();
    4242           
    43             shouldBe('JSON.stringify(clientRect)', 'JSON.stringify({top: 9.515625, right: 42, bottom: 19.515625, left: 22, width: 20, height: 10})');
     43            shouldBe('JSON.stringify(clientRect)', 'JSON.stringify({top: -108, right: 42, bottom: -98, left: 22, width: 20, height: 10})');
    4444           
    4545            finishJSTest();

  • trunk/LayoutTests/platform/ios-simulator-wk2/compositing/geometry/limit-layer-bounds-fixed-expected.txt

    r177052 r209409  
    1313        )
    1414        (GraphicsLayer
     15          (position 0.00 3000.00)
    1516          (bounds 300.00 200.00)
    1617          (drawsContent 1)

  • trunk/LayoutTests/platform/ios-simulator-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt

    r177052 r209409  
    1818        )
    1919        (GraphicsLayer
    20           (position 0.00 13.00)
     20          (position 0.00 113.00)
    2121          (bounds 150.00 142.00)
    2222          (drawsContent 1)

  • trunk/LayoutTests/platform/ios-simulator-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt

    r177052 r209409  
    1616        )
    1717        (GraphicsLayer
     18          (position 0.00 1000.00)
    1819          (bounds 500.00 500.00)
    1920          (contentsOpaque 1)

  • trunk/LayoutTests/platform/ios-simulator-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt

    r177052 r209409  
    1111      (children 6
    1212        (GraphicsLayer
    13           (position 812.00 61.00)
     13          (position 820.00 61.00)
    1414          (bounds 300.00 60.00)
    1515          (contentsOpaque 1)
    … …  
    1717        )
    1818        (GraphicsLayer
    19           (position 612.00 129.00)
     19          (position 812.00 129.00)
    2020          (bounds 300.00 60.00)
    2121          (contentsOpaque 1)
    … …  
    2323        )
    2424        (GraphicsLayer
    25           (position 812.00 197.00)
     25          (position 960.00 197.00)
    2626          (bounds 300.00 60.00)
    2727          (contentsOpaque 1)
    … …  
    2929        )
    3030        (GraphicsLayer
    31           (position 612.00 265.00)
     31          (position 812.00 265.00)
    3232          (bounds 300.00 60.00)
    3333          (contentsOpaque 1)
    … …  
    3535        )
    3636        (GraphicsLayer
    37           (position 612.00 333.00)
     37          (position 820.00 333.00)
    3838          (bounds 300.00 60.00)
    3939          (contentsOpaque 1)
    … …  
    4141        )
    4242        (GraphicsLayer
    43           (position 612.00 401.00)
     43          (position 960.00 401.00)
    4444          (bounds 300.00 60.00)
    4545          (contentsOpaque 1)

  • trunk/LayoutTests/platform/ios-simulator-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt

    r177430 r209409  
    1212    RenderText {#text} at (0,20) size 248x19
    1313      text run at (0,20) width 248: "Green box should fill the black border."
    14 layer at (0,0) size 404x54 clip at (2,2) size 400x50
     14layer at (0,25) size 404x54 clip at (2,27) size 400x50
    1515  RenderBlock (positioned) {DIV} at (0,0) size 404x54 [border: (2px solid #000000)]
    16 layer at (2,2) size 400x50
     16layer at (2,27) size 400x50
    1717  RenderBlock {DIV} at (2,2) size 400x50 [bgcolor=#008000]
    1818scrolled to 0,25

  • trunk/LayoutTests/platform/ios-simulator/compositing/absolute-inside-out-of-view-fixed-expected.txt

    r176113 r209409  
    88      (children 1
    99        (GraphicsLayer
     10          (position 0.00 200.00)
    1011          (bounds 100.00 100.00)
    1112          (contentsOpaque 1)

  • trunk/LayoutTests/platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt

    r174488 r209409  
    1717layer at (95,145) size 50x50
    1818  RenderBlock (positioned) zI: 1 {DIV} at (95,145) size 50x50
    19 layer at (20,20) size 100x100
     19layer at (70,70) size 100x100
    2020  RenderBlock (positioned) {DIV} at (20,20) size 100x100 [bgcolor=#008000]
    2121layer at (200,100) size 50x50
    … …  
    2929layer at (420,120) size 100x100
    3030  RenderBlock (positioned) {DIV} at (20,20) size 100x100 [bgcolor=#008000]
     31scrolled to 50,50

  • trunk/LayoutTests/scrollingcoordinator/ios/non-stable-viewport-scroll-expected.txt

    r208927 r209409  
    1818        (GraphicsLayer
    1919          (position 10.00 0.00)
    20           (approximate position 10.00 960.75)
     20          (approximate position 10.00 621.34)
    2121          (bounds 100.00 568.00)
    2222          (usingTiledLayer 1)
    2323          (contentsOpaque 1)
    2424          (drawsContent 1)
    25           (visible rect 0.00, 39.25 96.67 x 189.33)
    26           (coverage rect -10.00, -3.42 192.00 x 274.67)
     25          (visible rect 0.00, 378.66 96.67 x 189.33)
     26          (coverage rect -10.00, 335.99 192.00 x 274.67)
    2727          (intersects coverage rect 1)
    2828          (contentsScale 6.00)

  • trunk/LayoutTests/scrollingcoordinator/ios/ui-scrolling-tree-expected.txt

    r208666 r209409  
    88    (fixed node
    99      (fixed constraints
    10         (viewport-rect-at-last-layout (0,0) width=683 height=1212)
     10        (viewport-rect-at-last-layout (0,0) width=320 height=568)
    1111        (layer-position-at-last-layout (12,10)))
    1212      (layer top left (12,10))))

  • trunk/LayoutTests/tiled-drawing/fixed-layout-size-fixed-attachment-cover.html

    r187905 r209409  
    1818      window.internals.setPageScaleFactor(0.5, 0, 0);
    1919      window.internals.setUseFixedLayout(true);
     20      window.internals.settings.setVisualViewportEnabled(false);
    2021    }
    2122  }

  • trunk/LayoutTests/tiled-drawing/fixed-layout-size-fixed-attachment-local.html

    r187905 r209409  
    2121      window.internals.setPageScaleFactor(0.5, 0, 0);
    2222      window.internals.setUseFixedLayout(true);
     23      window.internals.settings.setVisualViewportEnabled(false);
    2324    }
    2425  }

  • trunk/LayoutTests/tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt

    r187905 r209409  
    33  (scrollable area size 785 585)
    44  (contents size 5008 5021)
     5  (layout viewport at (0,0) size 785x585)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (4223,4436))
    58)
    69
    … …  
    912  (scrollable area size 785 585)
    1013  (contents size 5008 5021)
     14  (layout viewport at (0,0) size 785x585)
     15  (min layout viewport origin (0,0))
     16  (max layout viewport origin (4223,4436))
    1117)
    1218
    … …  
    1521  (scrollable area size 785 585)
    1622  (contents size 5008 5021)
     23  (layout viewport at (0,0) size 785x585)
     24  (min layout viewport origin (0,0))
     25  (max layout viewport origin (4223,4436))
    1726)
    1827
    … …  
    2231  (contents size 5008 5021)
    2332  (requested scroll position 4223 0)
     33  (layout viewport at (0,0) size 785x585)
     34  (min layout viewport origin (0,0))
     35  (max layout viewport origin (4223,4436))
    2436)
    2537
    … …  
    2941  (contents size 5008 5021)
    3042  (requested scroll position 0 4436)
     43  (layout viewport at (4223,0) size 785x585)
     44  (min layout viewport origin (0,0))
     45  (max layout viewport origin (4223,4436))
    3146)
    3247
    … …  
    3651  (contents size 5008 5021)
    3752  (requested scroll position 4223 4436)
     53  (layout viewport at (0,4436) size 785x585)
     54  (min layout viewport origin (0,0))
     55  (max layout viewport origin (4223,4436))
    3856)
    3957

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt

    r187905 r209409  
    99      (children 2
    1010        (GraphicsLayer
    11           (position 0.00 154.25)
    1211          (anchor 0.00 0.00)
    1312          (bounds 785.00 585.00)

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt

    r187905 r209409  
    33  (contents size 785 2710)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,2110))
    58  (children 1
    69    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt

    r187905 r209409  
    33  (contents size 785 2513)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1913))
    58  (children 1
    69    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt

    r202408 r209409  
    33  (contents size 785 2213)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1613))
    58  (synchronous event dispatch region for event wheel
    69    at (0,13) size 204x204)

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt

    r187905 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1021)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,421))
    47  (children 1
    58    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt

    r187905 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1021)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,421))
    47  (children 1
    58    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/four-bars-expected.txt

    r187905 r209409  
    33  (contents size 785 2221)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1621))
    58  (children 4
    69    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt

    r187905 r209409  
    33  (contents size 785 2421)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1821))
    58  (children 4
    69    (Fixed node
    710      (anchor edges: AnchorEdgeLeft AnchorEdgeTop)
    8       (viewport rect at last layout: 0.00 100.00 785.00 600.00)
    9       (layer position at last layout 0.00 100.00)
     11      (viewport rect at last layout: 0.00 200.00 785.00 600.00)
     12      (layer position at last layout 0.00 200.00)
    1013    )
    1114    (Fixed node
    1215      (anchor edges: AnchorEdgeLeft AnchorEdgeTop)
    13       (viewport rect at last layout: 0.00 100.00 785.00 600.00)
    14       (layer position at last layout 6.00 296.00)
     16      (viewport rect at last layout: 0.00 200.00 785.00 600.00)
     17      (layer position at last layout 6.00 396.00)
    1518    )
    1619    (Fixed node
    1720      (anchor edges: AnchorEdgeRight AnchorEdgeTop)
    18       (viewport rect at last layout: 0.00 100.00 785.00 600.00)
    19       (layer position at last layout 597.00 296.00)
     21      (viewport rect at last layout: 0.00 200.00 785.00 600.00)
     22      (layer position at last layout 597.00 396.00)
    2023    )
    2124    (Fixed node
    2225      (anchor edges: AnchorEdgeLeft AnchorEdgeBottom)
    23       (viewport rect at last layout: 0.00 100.00 785.00 600.00)
    24       (layer position at last layout 0.00 612.00)
     26      (viewport rect at last layout: 0.00 200.00 785.00 600.00)
     27      (layer position at last layout 0.00 712.00)
    2528    )
    2629  )

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt

    r197594 r209409  
    33  (contents size 1805 5108)
    44  (frame scale factor 2.30)
     5  (layout viewport at (0,0) size 785x585)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1636))
    58  (children 4
    69    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt

    r187905 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 2221)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,1621))
    47  (children 1
    58    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt

    r187905 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 2221)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,1621))
    47  (children 1
    58    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/nested-fixed-expected.txt

    r187905 r209409  
    33  (contents size 785 2213)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1613))
    58  (children 1
    69    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt

    r187905 r209409  
    33  (contents size 785 2513)
    44  (requested scroll position 0 200)
     5  (layout viewport at (0,200) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,1913))
    58  (children 1
    69    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt

    r202408 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1016)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,416))
    47  (synchronous event dispatch region for event wheel
    58    at (45,47) size 404x304)
    … …  
    811      (scrollable area size 485 300)
    912      (contents size 485 420)
     13      (layout viewport at (500,300) size 485x300)
     14      (min layout viewport origin (0,0))
     15      (max layout viewport origin (0,120))
    1016      (children 1
    1117        (Sticky node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt

    r202408 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1016)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,416))
    47  (synchronous event dispatch region for event wheel
    58    at (45,47) size 404x304)
    … …  
    1316          (scrollable area size 500 300)
    1417          (contents size 500 420)
     18          (layout viewport at (500,300) size 500x300)
     19          (min layout viewport origin (0,0))
     20          (max layout viewport origin (0,120))
    1521          (children 1
    1622            (Sticky node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt

    r202408 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1016)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,416))
    47  (synchronous event dispatch region for event wheel
    58    at (45,37) size 404x304)
    … …  
    1316          (scrollable area size 485 300)
    1417          (contents size 485 420)
     18          (layout viewport at (500,300) size 485x300)
     19          (min layout viewport origin (0,0))
     20          (max layout viewport origin (0,120))
    1521          (children 1
    1622            (Sticky node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt

    r202408 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1016)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,416))
    47  (synchronous event dispatch region for event wheel
    58    at (45,47) size 404x304)
    … …  
    811      (scrollable area size 500 300)
    912      (contents size 500 420)
     13      (layout viewport at (500,300) size 500x300)
     14      (min layout viewport origin (0,0))
     15      (max layout viewport origin (0,120))
    1016      (children 1
    1117        (Sticky node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt

    r187905 r209409  
    33  (scrollable area size 785 600)
    44  (contents size 785 657)
     5  (layout viewport at (0,0) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,57))
    58  (children 1
    69    (Frame scrolling node
    … …  
    811      (contents size 465 1016)
    912      (requested scroll position 0 120)
     13      (layout viewport at (0,120) size 465x400)
     14      (min layout viewport origin (0,0))
     15      (max layout viewport origin (0,616))
    1016      (children 1
    1117        (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/frameset-frame-scrollability-expected.txt

    r202408 r209409  
    22  (scrollable area size 800 600)
    33  (contents size 800 600)
     4  (layout viewport at (0,0) size 800x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,0))
    47  (synchronous event dispatch region for event wheel
    58    at (0,0) size 800x594)

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt

    r202408 r209409  
    22  (scrollable area size 800 600)
    33  (contents size 800 600)
     4  (layout viewport at (0,0) size 800x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,0))
    47  (synchronous event dispatch region for event wheel
    58    at (0,166) size 280x434)

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt

    r187905 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 1016)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,416))
    47  (children 1
    58    (Fixed node

  • trunk/LayoutTests/tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt

    r202408 r209409  
    33  (scrollable area size 785 600)
    44  (contents size 785 757)
     5  (layout viewport at (0,0) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,157))
    58  (synchronous event dispatch region for event wheel
    69    at (68,68) size 300x300)

  • trunk/LayoutTests/tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt

    r187905 r209409  
    33  (contents size 785 5021)
    44  (requested scroll position 0 3000)
     5  (layout viewport at (0,0) size 785x600)
     6  (min layout viewport origin (0,0))
     7  (max layout viewport origin (0,4421))
    58)
    69

  • trunk/LayoutTests/tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt

    r187905 r209409  
    22  (scrollable area size 800 600)
    33  (contents size 800 600)
     4  (layout viewport at (0,0) size 800x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,0))
    47  (Scrolling on main thread because: Has slow repaint objects)
    58)

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt

    r187905 r209409  
    22  (scrollable area size 785 600)
    33  (contents size 785 2216)
     4  (layout viewport at (0,0) size 785x600)
     5  (min layout viewport origin (0,0))
     6  (max layout viewport origin (0,1616))
    47  (children 1
    58    (Sticky node

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt

    r187905 r209409  
    44  (contents size 2008 585)
    55  (requested scroll position 800 0)
     6  (layout viewport at (800,0) size 800x585)
     7  (min layout viewport origin (0,0))
     8  (max layout viewport origin (1208,0))
    69  (children 6
    710    (Sticky node

  • trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt

    r187905 r209409  
    88  (contents size 785 2908)
    99  (requested scroll position 0 580)
     10  (layout viewport at (0,580) size 785x600)
     11  (min layout viewport origin (0,0))
     12  (max layout viewport origin (0,2308))
    1013  (children 6
    1114    (Sticky node

  • trunk/Source/WebCore/ChangeLog

    r209403 r209409  
     12016-12-06  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Enable visual viewports by default on Mac, and iOS Wk2
     4        https://bugs.webkit.org/show_bug.cgi?id=165452
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Some tests revealed an issue where, during scrollbar updates, the visual viewport would be
     9        15px wider than the layout viewport, which results in the layout viewport shifting 15px to the
     10        right. Prevent this by disallowing viewport updates during the AdjustViewSize phase; we'll
     11        be called again in postLayoutTasks.
     12
     13        * page/FrameView.cpp:
     14        (WebCore::FrameView::updateLayoutViewport):
     15
    1162016-12-06  Daniel Bates  <dabates@apple.com>
    217

  • trunk/Source/WebCore/page/FrameView.cpp

    r209348 r209409  
    18571857        return;
    18581858   
     1859    // Don't update the layout viewport if we're in the middle of adjusting scrollbars. We'll get another call
     1860    // as a post-layout task.
     1861    if (m_layoutPhase == InViewSizeAdjust)
     1862        return;
     1863   
    18591864    if (m_layoutViewportOverrideRect) {
    18601865        LOG_WITH_STREAM(Scrolling, stream << "\nFrameView " << this << " updateLayoutViewport() - has layoutViewportOverrideRect" << m_layoutViewportOverrideRect.value());

  • trunk/Source/WebKit/mac/ChangeLog

    r209364 r209409  
     12016-12-06  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Enable visual viewports by default on Mac, and iOS Wk2
     4        https://bugs.webkit.org/show_bug.cgi?id=165452
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Turn visual viewports on by default for WK1 on Mac.
     9
     10        * WebView/WebPreferences.mm:
     11        (+[WebPreferences initialize]):
     12
    1132016-12-05  Dean Jackson  <dino@apple.com>
    214

  • trunk/Source/WebKit/mac/WebView/WebPreferences.mm

    r209230 r209409  
    629629        [NSNumber numberWithBool:NO], WebKitWebAnimationsEnabledPreferenceKey,
    630630#endif
     631
     632#if PLATFORM(IOS)
    631633        [NSNumber numberWithBool:NO], WebKitVisualViewportEnabledPreferenceKey,
     634#else
     635        [NSNumber numberWithBool:YES], WebKitVisualViewportEnabledPreferenceKey,
     636#endif
     637
    632638        [NSNumber numberWithBool:YES], WebKitNeedsStorageAccessFromFileURLsQuirkKey,
    633639#if ENABLE(SUBTLE_CRYPTO)

  • trunk/Source/WebKit2/ChangeLog

    r209408 r209409  
     12016-12-06  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Enable visual viewports by default on Mac, and iOS Wk2
     4        https://bugs.webkit.org/show_bug.cgi?id=165452
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Turn visual viewports on by default for WK2.
     9
     10        * Shared/WebPreferencesDefinitions.h:
     11
    1122016-12-06  Daniel Bates  <dabates@apple.com>
    213

  • trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

    r209396 r209409  
    239239    macro(ApplePayEnabled, applePayEnabled, Bool, bool, false, "", "") \
    240240    macro(ApplePayCapabilityDisclosureAllowed, applePayCapabilityDisclosureAllowed, Bool, bool, true, "", "") \
    241     macro(VisualViewportEnabled, visualViewportEnabled, Bool, bool, false, "", "") \
     241    macro(VisualViewportEnabled, visualViewportEnabled, Bool, bool, true, "", "") \
    242242    macro(NeedsStorageAccessFromFileURLsQuirk, needsStorageAccessFromFileURLsQuirk, Bool, bool, true, "", "") \
    243243    macro(LargeImageAsyncDecodingEnabled, largeImageAsyncDecodingEnabled, Bool, bool, true, "", "") \
Note: See TracChangeset for help on using the changeset viewer.