Changeset 209717 in webkit

Timestamp:

Dec 12, 2016, 11:49:56 AM (9 years ago)

Author:

Antti Koivisto

Message:

Enable network cache speculative revalidation in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=165616

Reviewed by Darin Adler.

Match Safari. Also add a menu item to disable it.

• MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration):

• MiniBrowser/mac/SettingsController.h:
• MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
(-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/mac/AppDelegate.m (modified) (1 diff)
• MiniBrowser/mac/SettingsController.h (modified) (1 diff)
• MiniBrowser/mac/SettingsController.m (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-12-08  Antti Koivisto  <antti@apple.com>
+
+        Enable network cache speculative revalidation in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=165616
+
+        Reviewed by Darin Adler.
+
+        Match Safari. Also add a menu item to disable it.
+
+        * MiniBrowser/mac/AppDelegate.m:
+        (defaultConfiguration):
+        * MiniBrowser/mac/SettingsController.h:
+        * MiniBrowser/mac/SettingsController.m:
+        (-[SettingsController _populateMenu]):
+        (-[SettingsController validateMenuItem:]):
+        (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
+        (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
+
 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/MiniBrowser/mac/AppDelegate.m

@@ -93 +93 @@
         configuration.preferences._developerExtrasEnabled = YES;
 
-        if ([SettingsController shared].perWindowWebProcessesDisabled) {
-            _WKProcessPoolConfiguration *singleProcessConfiguration = [[_WKProcessPoolConfiguration alloc] init];
-            singleProcessConfiguration.maximumProcessCount = 1;
-            configuration.processPool = [[[WKProcessPool alloc] _initWithConfiguration:singleProcessConfiguration] autorelease];
-            [singleProcessConfiguration release];
-        }
+        _WKProcessPoolConfiguration *processConfiguration = [[[_WKProcessPoolConfiguration alloc] init] autorelease];
+        processConfiguration.diskCacheSpeculativeValidationEnabled = ![SettingsController shared].networkCacheSpeculativeRevalidationDisabled;
+        if ([SettingsController shared].perWindowWebProcessesDisabled)
+            processConfiguration.maximumProcessCount = 1;
+        
+        configuration.processPool = [[[WKProcessPool alloc] _initWithConfiguration:processConfiguration] autorelease];
 
 #if WK_API_ENABLED

trunk/Tools/MiniBrowser/mac/SettingsController.h

@@ -55 +55 @@
 @property (nonatomic, readonly) BOOL loadsAllSiteIcons;
 @property (nonatomic, readonly) BOOL usesGameControllerFramework;
+@property (nonatomic, readonly) BOOL networkCacheSpeculativeRevalidationDisabled;
 
 @property (nonatomic, readonly) NSString *defaultURL;

trunk/Tools/MiniBrowser/mac/SettingsController.m

@@ -64 +64 @@
 
 static NSString * const PerWindowWebProcessesDisabledKey = @"PerWindowWebProcessesDisabled";
+static NSString * const NetworkCacheSpeculativeRevalidationDisabledKey = @"NetworkCacheSpeculativeRevalidationDisabled";
 
 typedef NS_ENUM(NSInteger, DebugOverylayMenuItemTag) {
@@ -141 +142 @@
     [self _addItemWithTitle:@"Load All Site Icons Per-Page" action:@selector(toggleLoadsAllSiteIcons:) indented:YES];
     [self _addItemWithTitle:@"Use GameController.framework on macOS (Restart required)" action:@selector(toggleUsesGameControllerFramework:) indented:YES];
+    [self _addItemWithTitle:@"Disable network cache speculative revalidation" action:@selector(toggleNetworkCacheSpeculativeRevalidationDisabled:) indented:YES];
 
     NSMenuItem *debugOverlaysSubmenuItem = [[NSMenuItem alloc] initWithTitle:@"Debug Overlays" action:nil keyEquivalent:@""];
@@ -220 +222 @@
     else if (action == @selector(toggleUsesGameControllerFramework:))
         [menuItem setState:[self usesGameControllerFramework] ? NSOnState : NSOffState];
+    else if (action == @selector(toggleNetworkCacheSpeculativeRevalidationDisabled:))
+        [menuItem setState:[self networkCacheSpeculativeRevalidationDisabled] ? NSOnState : NSOffState];
     else if (action == @selector(toggleUseUISideCompositing:))
         [menuItem setState:[self useUISideCompositing] ? NSOnState : NSOffState];
@@ -387 +391 @@
 }
 
+- (BOOL)networkCacheSpeculativeRevalidationDisabled
+{
+    return [[NSUserDefaults standardUserDefaults] boolForKey:NetworkCacheSpeculativeRevalidationDisabledKey];
+}
+
+- (void)toggleNetworkCacheSpeculativeRevalidationDisabled:(id)sender
+{
+    [self _toggleBooleanDefault:NetworkCacheSpeculativeRevalidationDisabledKey];
+}
+
 - (BOOL)tiledScrollingIndicatorVisible
 {