Changeset 209887 in webkit

Timestamp:

Dec 15, 2016 4:46:27 PM (7 years ago)

Author:

Simon Fraser

Message:

Fix flakiness of fast/visual-viewport/ios/zoomed-focus-in-fixed.html
​https://bugs.webkit.org/show_bug.cgi?id=165930

Reviewed by Tim Horton.

The test zooms when focussing the input, which completes after the keyboard shows,
so we need to wait for zooming to finish using the uiController.didEndZoomingCallback.

• fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
• fast/visual-viewport/ios/zoomed-focus-in-fixed.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt (modified) (1 diff)
• fast/visual-viewport/ios/zoomed-focus-in-fixed.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-12-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix flakiness of fast/visual-viewport/ios/zoomed-focus-in-fixed.html
+        https://bugs.webkit.org/show_bug.cgi?id=165930
+
+        Reviewed by Tim Horton.
+
+        The test zooms when focussing the input, which completes after the keyboard shows,
+        so we need to wait for zooming to finish using the uiController.didEndZoomingCallback.
+
+        * fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
+        * fast/visual-viewport/ios/zoomed-focus-in-fixed.html:
+
 2016-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt

@@ -1 @@
-Layout viewport: {"top":746.703125,"right":320,"bottom":1314.703125,"left":0,"width":320,"height":568}
-Visual viewport: {"top":747,"right":220,"bottom":1138,"left":0,"width":220,"height":391}
+Layout viewport: {"top":659.734375,"right":320,"bottom":1227.734375,"left":0,"width":320,"height":568}
+Visual viewport: {"top":660,"right":220,"bottom":1051,"left":0,"width":220,"height":391}
 

trunk/LayoutTests/fast/visual-viewport/ios/zoomed-focus-in-fixed.html

@@ -32 +32 @@
         {
             return `(function() {
-                uiController.didShowKeyboardCallback = function() {
+                uiController.didEndZoomingCallback = function() {
                     uiController.uiScriptComplete();
                 }