Changeset 209933 in webkit

Timestamp:

Dec 16, 2016 1:20:53 PM (7 years ago)

Author:

Matt Baker

Message:

Web Inspector: REGRESSION (r209882): Opening find banner in editor causes UI to hang
​https://bugs.webkit.org/show_bug.cgi?id=165967

Reviewed by Timothy Hatcher.

• UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype._findBannerDidShow):
Showing the find banner should cause search results to be refreshed only
if it contains query text.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ContentBrowser.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-12-16  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: REGRESSION (r209882): Opening find banner in editor causes UI to hang
+        https://bugs.webkit.org/show_bug.cgi?id=165967
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ContentBrowser.js:
+        (WebInspector.ContentBrowser.prototype._findBannerDidShow):
+        Showing the find banner should cause search results to be refreshed only
+        if it contains query text.
+
 2016-12-16  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js

@@ -295 +295 @@
 
         currentContentView.automaticallyRevealFirstSearchResult = true;
-        currentContentView.performSearch(this._findBanner.searchQuery);
+        if (this._findBanner.searchQuery !== "")
+            currentContentView.performSearch(this._findBanner.searchQuery);
     }