Changeset 209941 in webkit


Ignore:
Timestamp:
Dec 16, 2016 3:00:48 PM (7 years ago)
Author:
Chris Dumez
Message:

HTML form validation bubble should be dismissed on navigation
​https://bugs.webkit.org/show_bug.cgi?id=165960
<rdar://problem/29668086>

Reviewed by Simon Fraser.

Source/WebKit/mac:

Dismiss HTML form validation bubble on top-level navigation on Mac WK1.

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]):

Source/WebKit2:

Dismiss HTML form validation bubble on top-level navigation on WK2.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

LayoutTests:

Add layout test coverage.

  • http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt: Added.
  • http/tests/navigation/navigation-dismisses-validation-bubbles.html: Added.
  • http/tests/navigation/resources/check-validation-bubble-not-visible.html: Added.
Location:
trunk
Files:
3 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r209935 r209941  
     12016-12-16  Chris Dumez  <cdumez@apple.com>
     2
     3        HTML form validation bubble should be dismissed on navigation
     4        https://bugs.webkit.org/show_bug.cgi?id=165960
     5        <rdar://problem/29668086>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Add layout test coverage.
     10
     11        * http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt: Added.
     12        * http/tests/navigation/navigation-dismisses-validation-bubbles.html: Added.
     13        * http/tests/navigation/resources/check-validation-bubble-not-visible.html: Added.
     14
    1152016-12-16  Ryan Haddad  <ryanhaddad@apple.com>
    216

  • trunk/Source/WebKit/mac/ChangeLog

    r209906 r209941  
     12016-12-16  Chris Dumez  <cdumez@apple.com>
     2
     3        HTML form validation bubble should be dismissed on navigation
     4        https://bugs.webkit.org/show_bug.cgi?id=165960
     5        <rdar://problem/29668086>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
     10
     11        * WebView/WebView.mm:
     12        (-[WebView _didStartProvisionalLoadForFrame:]):
     13
    1142016-12-15  Darin Adler  <darin@apple.com>
    215

  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r209906 r209941  
    32873287
    32883288        [self _willChangeValueForKey: _WebMainFrameURLKey];
     3289
     3290        [self hideFormValidationMessage];
    32893291    }
    32903292

  • trunk/Source/WebKit2/ChangeLog

    r209937 r209941  
     12016-12-16  Chris Dumez  <cdumez@apple.com>
     2
     3        HTML form validation bubble should be dismissed on navigation
     4        https://bugs.webkit.org/show_bug.cgi?id=165960
     5        <rdar://problem/29668086>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Dismiss HTML form validation bubble on top-level navigation on WK2.
     10
     11        * UIProcess/WebPageProxy.cpp:
     12        (WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
     13
    1142016-12-16  Jer Noble  <jer.noble@apple.com>
    215

  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r209845 r209941  
    31703170        navigation = &navigationState().navigation(navigationID);
    31713171
    3172     if (frame->isMainFrame())
     3172    if (frame->isMainFrame()) {
    31733173        m_pageLoadState.didStartProvisionalLoad(transaction, url, unreachableURL);
     3174        hideValidationMessage();
     3175    }
    31743176
    31753177    frame->setUnreachableURL(unreachableURL);
Note: See TracChangeset for help on using the changeset viewer.