Changeset 209987 in webkit

Timestamp:

Dec 19, 2016 9:53:00 AM (7 years ago)

Author:

weinig@apple.com

Message:

[WebIDL] Remove custom binding for the named Image constructor
​https://bugs.webkit.org/show_bug.cgi?id=166023

Reviewed by Alex Christensen.

• bindings/js/JSBindingsAllInOne.cpp:
• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

Remove JSImageConstructor.

• bindings/js/JSImageConstructor.cpp: Removed.
• bindings/js/JSImageConstructor.h: Removed.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::image): Deleted.

• page/DOMWindow.idl:

Remove custom getter for the constructor.

• html/HTMLImageElement.idl:

Add NamedConstructor annotation.

Location:

trunk/Source/WebCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• WebCore.xcodeproj/project.pbxproj (modified) (5 diffs)
• bindings/js/JSBindingsAllInOne.cpp (modified) (1 diff)
• bindings/js/JSDOMWindowCustom.cpp (modified) (2 diffs)
• bindings/js/JSImageConstructor.cpp (deleted)
• bindings/js/JSImageConstructor.h (deleted)
• html/HTMLImageElement.idl (modified) (1 diff)
• page/DOMWindow.idl (modified) (1 diff)

trunk/Source/WebCore/CMakeLists.txt

@@ -1158 +1158 @@
     bindings/js/JSIDBRequestCustom.cpp
     bindings/js/JSIDBTransactionCustom.cpp
-    bindings/js/JSImageConstructor.cpp
     bindings/js/JSImageDataCustom.cpp
     bindings/js/JSInspectorFrontendHostCustom.cpp

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-12-19  Sam Weinig  <sam@webkit.org>
+
+        [WebIDL] Remove custom binding for the named Image constructor
+        https://bugs.webkit.org/show_bug.cgi?id=166023
+
+        Reviewed by Alex Christensen.
+
+        * bindings/js/JSBindingsAllInOne.cpp:
+        * CMakeLists.txt:
+        * WebCore.xcodeproj/project.pbxproj:
+        Remove JSImageConstructor.
+
+        * bindings/js/JSImageConstructor.cpp: Removed.
+        * bindings/js/JSImageConstructor.h: Removed.
+        
+        * bindings/js/JSDOMWindowCustom.cpp:
+        (WebCore::JSDOMWindow::image): Deleted.
+        * page/DOMWindow.idl:
+        Remove custom getter for the constructor.
+
+        * html/HTMLImageElement.idl:
+        Add NamedConstructor annotation.
+
 2016-12-19  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

@@ -5348 +5348 @@
                 BC6932730D7E293900AE44D1 /* JSDOMWindowBase.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC6932710D7E293900AE44D1 /* JSDOMWindowBase.cpp */; };
                 BC6932740D7E293900AE44D1 /* JSDOMWindowBase.h in Headers */ = {isa = PBXBuildFile; fileRef = BC6932720D7E293900AE44D1 /* JSDOMWindowBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
-                BC6C49F30D7DBA0500FFA558 /* JSImageConstructor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC6C49F10D7DBA0500FFA558 /* JSImageConstructor.cpp */; };
-                BC6C49F40D7DBA0500FFA558 /* JSImageConstructor.h in Headers */ = {isa = PBXBuildFile; fileRef = BC6C49F20D7DBA0500FFA558 /* JSImageConstructor.h */; };
                 BC6D44BE0C07EFB60072D2C9 /* JSHTMLEmbedElementCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC6D44BD0C07EFB60072D2C9 /* JSHTMLEmbedElementCustom.cpp */; };
                 BC6D44EC0C07F2ED0072D2C9 /* JSHTMLEmbedElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC6D44EA0C07F2ED0072D2C9 /* JSHTMLEmbedElement.cpp */; };
@@ -13249 +13247 @@
                 BC6932710D7E293900AE44D1 /* JSDOMWindowBase.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMWindowBase.cpp; sourceTree = "<group>"; };
                 BC6932720D7E293900AE44D1 /* JSDOMWindowBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMWindowBase.h; sourceTree = "<group>"; };
-                BC6C49F10D7DBA0500FFA558 /* JSImageConstructor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSImageConstructor.cpp; sourceTree = "<group>"; };
-                BC6C49F20D7DBA0500FFA558 /* JSImageConstructor.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSImageConstructor.h; sourceTree = "<group>"; };
                 BC6D44BD0C07EFB60072D2C9 /* JSHTMLEmbedElementCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLEmbedElementCustom.cpp; sourceTree = "<group>"; };
                 BC6D44EA0C07F2ED0072D2C9 /* JSHTMLEmbedElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLEmbedElement.cpp; sourceTree = "<group>"; };
@@ -22511 +22507 @@
                         children = (
                                 CE261694187E6469007955F3 /* ios */,
-                                BC6C49F10D7DBA0500FFA558 /* JSImageConstructor.cpp */,
-                                BC6C49F20D7DBA0500FFA558 /* JSImageConstructor.h */,
                         );
                         name = Constructors;
@@ -26349 +26343 @@
                                 838EF53C1DC14A7C008F0C39 /* JSIDBTransactionMode.h in Headers */,
                                 269239961505E1AA009E57FC /* JSIDBVersionChangeEvent.h in Headers */,
-                                BC6C49F40D7DBA0500FFA558 /* JSImageConstructor.h in Headers */,
                                 A77979290D6B9E64003851B9 /* JSImageData.h in Headers */,
                                 A86629D309DA2B48009633A6 /* JSInputEvent.h in Headers */,
@@ -30130 +30123 @@
                                 838EF53B1DC14A7C008F0C39 /* JSIDBTransactionMode.cpp in Sources */,
                                 511EF2CB17F0FD3500E4FA16 /* JSIDBVersionChangeEvent.cpp in Sources */,
-                                BC6C49F30D7DBA0500FFA558 /* JSImageConstructor.cpp in Sources */,
                                 A77979280D6B9E64003851B9 /* JSImageData.cpp in Sources */,
                                 A7D0318E0E93540300E24ACD /* JSImageDataCustom.cpp in Sources */,

trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp

@@ -92 +92 @@
 #include "JSHTMLTemplateElementCustom.cpp"
 #include "JSHistoryCustom.cpp"
-#include "JSImageConstructor.cpp"
 #include "JSImageDataCustom.cpp"
 #include "JSInspectorFrontendHostCustom.cpp"

trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp

@@ -32 +32 @@
 #include "JSHTMLOptionElement.h"
 #include "JSIDBFactory.h"
-#include "JSImageConstructor.h"
 #include "JSWorker.h"
 #include "Location.h"
@@ -404 +403 @@
 }
 
-JSValue JSDOMWindow::image(ExecState& state) const
-{
-    return createImageConstructor(state.vm(), *this);
-}
-
 // Custom functions
 

trunk/Source/WebCore/html/HTMLImageElement.idl

@@ -22 +22 @@
     ExportMacro=WEBCORE_EXPORT,
     JSGenerateToNativeObject,
+    NamedConstructor=Image(optional unsigned long width, optional unsigned long height)
 ] interface HTMLImageElement : HTMLElement {
     [Reflect] attribute DOMString name;

trunk/Source/WebCore/page/DOMWindow.idl

@@ -168 +168 @@
     void releaseEvents(); // Not implemented. Also not in modern standards. Empty function may help compatibility with legacy content.
 
-    [CustomGetter, CustomConstructor] attribute HTMLImageElementNamedConstructor Image;
     attribute XMLDocumentConstructor SVGDocument;