Changeset 21002 in webkit


Ignore:
Timestamp:
Apr 21, 2007 8:15:17 PM (17 years ago)
Author:
andrew
Message:

LayoutTests:
2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/repaint/control-clip-expected.checksum: Added.
  • fast/repaint/control-clip-expected.png: Added.
  • fast/repaint/control-clip-expected.txt: Added.
  • fast/repaint/control-clip.html: Added.

WebCore:
2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/repaint/control-clip.html

Ignore controls' lightweight clip in repaint rect computation for now.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r20997 r21002  
     12007-04-21  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=13391
     6          REGRESSION (r18819): Incomplete repaint of button text
     7
     8        * fast/repaint/control-clip-expected.checksum: Added.
     9        * fast/repaint/control-clip-expected.png: Added.
     10        * fast/repaint/control-clip-expected.txt: Added.
     11        * fast/repaint/control-clip.html: Added.
     12
    1132007-04-21  Lamar Goddard  <lamargoddard@gmail.com>
    214

  • trunk/WebCore/ChangeLog

    r21001 r21002  
     12007-04-21  Mitz Pettel  <mitz@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=13391
     6          REGRESSION (r18819): Incomplete repaint of button text
     7
     8        Test: fast/repaint/control-clip.html
     9
     10        Ignore controls' lightweight clip in repaint rect computation for now.
     11
     12        * rendering/RenderBox.cpp:
     13        (WebCore::RenderBox::computeAbsoluteRepaintRect):
     14
    1152007-04-21  Darin Adler  <darin@apple.com>
    216

  • trunk/WebCore/rendering/RenderBox.cpp

    r20957 r21002  
    953953        }
    954954
    955         // <body> may not have overflow, since it might be applying its overflow value to the
    956         // scrollbars.
     955        // FIXME: We ignore the lightweight clipping rect that controls use, since if |o| is in mid-layout,
     956        // its controlClipRect will be wrong. For overflow clip we use the values cached by the layer.
    957957        if (o->hasOverflowClip()) {
    958958            // o->height() is inaccurate if we're in the middle of a layout of |o|, so use the
    … …  
    961961            IntRect boxRect(0, 0, o->layer()->width(), o->layer()->height());
    962962            o->layer()->subtractScrollOffset(x, y); // For overflow:auto/scroll/hidden.
    963             IntRect repaintRect(x, y, rect.width(), rect.height());
    964             rect = intersection(repaintRect, boxRect);
    965             if (rect.isEmpty())
    966                 return;
    967         } else if (o->hasControlClip()) {
    968             // Some form controls use a lightweight clipping scheme to avoid the overhead of a layer.
    969             IntRect boxRect(borderLeft(), borderTop(), m_width - borderLeft() - borderRight(), m_height - borderTop() - borderBottom());
    970963            IntRect repaintRect(x, y, rect.width(), rect.height());
    971964            rect = intersection(repaintRect, boxRect);
Note: See TracChangeset for help on using the changeset viewer.