Changeset 210423 in webkit

Timestamp:

Jan 5, 2017 5:55:07 PM (7 years ago)

Author:

Simon Fraser

Message:

Radio buttons have a fixed border radius making them look square when resized
​https://bugs.webkit.org/show_bug.cgi?id=148676
Source/WebCore:

rdar://problem/29889892

Reviewed by Tim Horton.

Change the 8px border-radius of iOS radio buttons to 50% so they remain circular
when the page overrides the size.

Test: fast/forms/ios/large-radio-button-is-round.html

• css/html.css:

(#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS):

LayoutTests:

Reviewed by Tim Horton.

• fast/forms/ios/large-radio-button-is-round-expected.html: Added.
• fast/forms/ios/large-radio-button-is-round.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/ios/large-radio-button-is-round-expected.html (added)
• LayoutTests/fast/forms/ios/large-radio-button-is-round.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/html.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-01-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Radio buttons have a fixed border radius making them look square when resized
+        https://bugs.webkit.org/show_bug.cgi?id=148676
+
+        Reviewed by Tim Horton.
+
+        * fast/forms/ios/large-radio-button-is-round-expected.html: Added.
+        * fast/forms/ios/large-radio-button-is-round.html: Added.
+
 2017-01-05  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Radio buttons have a fixed border radius making them look square when resized
+        https://bugs.webkit.org/show_bug.cgi?id=148676
+        rdar://problem/29889892
+
+        Reviewed by Tim Horton.
+
+        Change the 8px border-radius of iOS radio buttons to 50% so they remain circular
+        when the page overrides the size.
+
+        Test: fast/forms/ios/large-radio-button-is-round.html
+
+        * css/html.css:
+        (#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS):
+
 2017-01-05  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/css/html.css

@@ -796 +796 @@
 input[type="radio"] {
     -webkit-appearance: radio;
-    border-radius: 8px;
+    border-radius: 50%;
     width: 16px;
     height: 16px;