Changeset 210616 in webkit


Ignore:
Timestamp:
Jan 11, 2017 6:44:30 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Remove request.formData property until it gets implemented
​https://bugs.webkit.org/show_bug.cgi?id=166920
<rdar://problem/29971105>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-01-11
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
  • web-platform-tests/fetch/api/request/request-consume-expected.txt:
  • web-platform-tests/fetch/api/request/request-idl-expected.txt:
  • web-platform-tests/fetch/api/request/request-structure-expected.txt:

Source/WebCore:

Covered by rebased tests.

  • Modules/fetch/FetchBody.idl:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r210593 r210616  
     12017-01-11  Youenn Fablet  <youenn@apple.com>
     2
     3        Remove request.formData property until it gets implemented
     4        https://bugs.webkit.org/show_bug.cgi?id=166920
     5        <rdar://problem/29971105>
     6
     7        Reviewed by Chris Dumez.
     8
     9        * web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
     10        * web-platform-tests/fetch/api/request/request-consume-expected.txt:
     11        * web-platform-tests/fetch/api/request/request-idl-expected.txt:
     12        * web-platform-tests/fetch/api/request/request-structure-expected.txt:
     13
    1142017-01-11  Chris Dumez  <cdumez@apple.com>
    215

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt

    r206632 r210616  
    44PASS Consume request's body as arrayBuffer
    55PASS Consume request's body as json
    6 FAIL Consume request's body as formData promise_test: Unhandled rejection with value: undefined
     6FAIL Consume request's body as formData request.formData is not a function. (In 'request.formData()', 'request.formData' is undefined)
    77PASS Consume empty blob request body as arrayBuffer
    88PASS Consume empty text request body as arrayBuffer

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt

    r205115 r210616  
    2424PASS Consume DataView request's body as arrayBuffer
    2525PASS Consume DataView request's body as JSON
    26 FAIL Consume FormData request's body as FormData promise_test: Unhandled rejection with value: undefined
     26FAIL Consume FormData request's body as FormData request.formData is not a function. (In 'request.formData()', 'request.formData' is undefined)
    2727PASS Consume blob response's body as blob
    2828PASS Consume blob response's body as text

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl-expected.txt

    r198888 r210616  
    2121PASS Request interface: operation arrayBuffer()
    2222PASS Request interface: operation blob()
    23 PASS Request interface: operation formData()
     23FAIL Request interface: operation formData() assert_own_property: interface prototype object missing non-static operation expected property "formData" missing
    2424PASS Request interface: operation json()
    2525PASS Request interface: operation text()
    … …  
    4242PASS Request interface: new Request("") must inherit property "arrayBuffer" with the proper type (14)
    4343PASS Request interface: new Request("") must inherit property "blob" with the proper type (15)
    44 PASS Request interface: new Request("") must inherit property "formData" with the proper type (16)
     44FAIL Request interface: new Request("") must inherit property "formData" with the proper type (16) assert_inherits: property "formData" not found in prototype chain
    4545PASS Request interface: new Request("") must inherit property "json" with the proper type (17)
    4646PASS Request interface: new Request("") must inherit property "text" with the proper type (18)

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-structure-expected.txt

    r195954 r210616  
    33PASS Request has arrayBuffer method
    44PASS Request has blob method
    5 PASS Request has formData method
     5FAIL Request has formData method assert_true: request has formData method expected true got false
    66PASS Request has json method
    77PASS Request has text method

  • trunk/Source/WebCore/ChangeLog

    r210612 r210616  
     12017-01-11  Youenn Fablet  <youenn@apple.com>
     2
     3        Remove request.formData property until it gets implemented
     4        https://bugs.webkit.org/show_bug.cgi?id=166920
     5        <rdar://problem/29971105>
     6
     7        Reviewed by Chris Dumez.
     8
     9        Covered by rebased tests.
     10
     11        * Modules/fetch/FetchBody.idl:
     12
    1132017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
    214

  • trunk/Source/WebCore/Modules/fetch/FetchBody.idl

    r208474 r210616  
    3838    [NewObject] Promise<ArrayBuffer> arrayBuffer();
    3939    [NewObject] Promise<Blob> blob();
    40     [NewObject] Promise<Blob> formData();
     40    // FIXME: Add support for form data consumption (https://bugs.webkit.org/show_bug.cgi?id=161190).
     41    //[NewObject] Promise<DOMFormData> formData();
    4142    [NewObject] Promise<any> json();
    4243    [NewObject] Promise<USVString> text();
Note: See TracChangeset for help on using the changeset viewer.