Changeset 210853 in webkit

Timestamp:

Jan 18, 2017 10:37:30 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[Fetch API] Update content-type in case of form data
​https://bugs.webkit.org/show_bug.cgi?id=167143

Patch by Youenn Fablet <​youenn@apple.com> on 2017-01-18
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/basic/request-headers-expected.txt:

Source/WebCore:

Covered by rebased test.

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract): Adding a space to the content-type in case of form data.

LayoutTests:

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (2 diffs)
• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/fetch/FetchBody.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-01-18  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Update content-type in case of form data
+        https://bugs.webkit.org/show_bug.cgi?id=167143
+
+        Reviewed by Alex Christensen.
+
+        * TestExpectations:
+
 2017-01-18  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -312 +312 @@
 webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]
 
-# Flaky tests due to always changing assertion error message
-imported/w3c/web-platform-tests/fetch/api/basic/request-headers.html [ Failure ]
-imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ]
-
 [ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload.html [ Skip ]
 [ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload-worker.html [ Skip ]
@@ -326 +322 @@
 
 webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ]
+
+# Flaky tests due to always changing assertion error message
+imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ]
 
 # New W3C ref tests that are failing.

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2017-01-18  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Update content-type in case of form data
+        https://bugs.webkit.org/show_bug.cgi?id=167143
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/fetch/api/basic/request-headers-expected.txt:
+
 2017-01-17  Youenn Fablet  <youennf@gmail.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt

@@ -6 +6 @@
 PASS Fetch with POST without body 
 PASS Fetch with POST with text body 
-FAIL Fetch with POST with FormData body assert_true: Request should have header content-type starting with multipart/form-data; boundary=, but got multipart/form-data;boundary=----WebKitFormBoundary7HBc13pIcNoBV6R5 expected true got false
+PASS Fetch with POST with FormData body 
 PASS Fetch with POST with URLSearchParams body 
 FAIL Fetch with POST with Blob body assert_equals: Request should have header content-type: null expected (object) null but got (string) ""

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-18  Youenn Fablet  <youenn@apple.com>
+
+        [Fetch API] Update content-type in case of form data
+        https://bugs.webkit.org/show_bug.cgi?id=167143
+
+        Reviewed by Alex Christensen.
+
+        Covered by rebased test.
+
+        * Modules/fetch/FetchBody.cpp:
+        (WebCore::FetchBody::extract): Adding a space to the content-type in case of form data.
+
 2017-01-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/Source/WebCore/Modules/fetch/FetchBody.cpp

@@ -58 +58 @@
         auto& domFormData = *JSDOMFormData::toWrapped(value);
         auto formData = FormData::createMultiPart(domFormData, domFormData.encoding(), &static_cast<Document&>(context));
-        contentType = makeString("multipart/form-data;boundary=", formData->boundary().data());
+        contentType = makeString("multipart/form-data; boundary=", formData->boundary().data());
         return FetchBody(WTFMove(formData));
     }