Changeset 210911 in webkit

Timestamp:

Jan 18, 2017 9:09:49 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: split console should be allowed for Network and Timeline tabs when Inspector is not docked
​https://bugs.webkit.org/show_bug.cgi?id=167075

Patch by Devin Rousso <Devin Rousso> on 2017-01-18
Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WebInspector.dockedConfigurationSupportsSplitContentBrowser):
Helper function to determine if the current docked state supports having the content view
and split console at the same time. Currently set to be true if not docked bottom.

• UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView.prototype.get supportsSplitContentBrowser):

• UserInterface/Views/ContentView.js:

(WebInspector.ContentView.prototype.get supportsSplitContentBrowser):

• UserInterface/Views/NetworkTabContentView.js:

(WebInspector.NetworkTabContentView.prototype.get supportsSplitContentBrowser):

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.get supportsSplitContentBrowser): Deleted.
Update supportsSplitContentBrowser functions to only be true/false based on the return value
of WebInspector.dockedConfigurationSupportsSplitContentBrowser.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (1 diff)
• UserInterface/Views/ClusterContentView.js (modified) (1 diff)
• UserInterface/Views/ContentView.js (modified) (1 diff)
• UserInterface/Views/NetworkTabContentView.js (modified) (1 diff)
• UserInterface/Views/TimelineTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-01-18  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: split console should be allowed for Network and Timeline tabs when Inspector is not docked
+        https://bugs.webkit.org/show_bug.cgi?id=167075
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Base/Main.js:
+        (WebInspector.dockedConfigurationSupportsSplitContentBrowser):
+        Helper function to determine if the current docked state supports having the content view
+        and split console at the same time.  Currently set to be true if not docked bottom.
+
+        * UserInterface/Views/ClusterContentView.js:
+        (WebInspector.ClusterContentView.prototype.get supportsSplitContentBrowser):
+        * UserInterface/Views/ContentView.js:
+        (WebInspector.ContentView.prototype.get supportsSplitContentBrowser):
+        * UserInterface/Views/NetworkTabContentView.js:
+        (WebInspector.NetworkTabContentView.prototype.get supportsSplitContentBrowser):
+        * UserInterface/Views/TimelineTabContentView.js:
+        (WebInspector.TimelineTabContentView.prototype.get supportsSplitContentBrowser): Deleted.
+        Update supportsSplitContentBrowser functions to only be true/false based on the return value
+        of WebInspector.dockedConfigurationSupportsSplitContentBrowser.
+
 2017-01-18  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -889 +889 @@
 };
 
+WebInspector.dockedConfigurationSupportsSplitContentBrowser = function()
+{
+    return this._dockConfiguration !== WebInspector.DockConfiguration.Bottom;
+};
+
 WebInspector.doesCurrentTabSupportSplitContentBrowser = function()
 {

trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js

@@ -58 +58 @@
         if (this._contentViewContainer.currentContentView)
             return this._contentViewContainer.currentContentView.supportsSplitContentBrowser;
-        return true;
+
+        return super.supportsSplitContentBrowser;
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js

@@ -311 +311 @@
     {
         // Implemented by subclasses.
-        return true;
+        return WebInspector.dockedConfigurationSupportsSplitContentBrowser();
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTabContentView.js

@@ -62 +62 @@
     get supportsSplitContentBrowser()
     {
+        // Since the Network tab has a real sidebar, showing the split console would cause items in
+        // the sidebar to be aligned with an item in the datagrid that isn't shown.
         return false;
     }

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

@@ -310 +310 @@
     }
 
-    get supportsSplitContentBrowser()
-    {
-        return false;
-    }
-
     // Protected