Changeset 211083 in webkit

Timestamp:

Jan 24, 2017 6:10:43 AM (7 years ago)

Author:

magomez@igalia.com

Message:

[Coordinated Graphics] Ensure that we're in AC mode before trying to create GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=167365

Reviewed by Carlos Garcia Campos.

When entering AC on demand, the RenderLayerCompositor wants to create the root GraphicsLayer before the
AcceleratedDrawingArea is in AC mode. This means there's no LayerTreeHost to request the GraphicsLayerFactory,
so no layers are created. Ensure that we are in AC mode before requesting the GraphicsLayerFactory.

No behaviour change, no new tests.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::graphicsLayerFactory):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/AcceleratedDrawingArea.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-01-24  Miguel Gomez  <magomez@igalia.com>
+
+        [Coordinated Graphics] Ensure that we're in AC mode before trying to create GraphicsLayers
+        https://bugs.webkit.org/show_bug.cgi?id=167365
+
+        Reviewed by Carlos Garcia Campos.
+
+        When entering AC on demand, the RenderLayerCompositor wants to create the root GraphicsLayer before the
+        AcceleratedDrawingArea is in AC mode. This means there's no LayerTreeHost to request the GraphicsLayerFactory,
+        so no layers are created. Ensure that we are in AC mode before requesting the GraphicsLayerFactory.
+
+        No behaviour change, no new tests.
+
+        * WebProcess/WebPage/AcceleratedDrawingArea.cpp:
+        (WebKit::AcceleratedDrawingArea::graphicsLayerFactory):
+
 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/AcceleratedDrawingArea.cpp

@@ -175 +175 @@
 GraphicsLayerFactory* AcceleratedDrawingArea::graphicsLayerFactory()
 {
+    if (!m_layerTreeHost)
+        enterAcceleratedCompositingMode(nullptr);
     return m_layerTreeHost ? m_layerTreeHost->graphicsLayerFactory() : nullptr;
 }