Changeset 211130 in webkit
- Timestamp:
- Jan 24, 2017 6:56:40 PM (7 years ago)
- Location:
- trunk/LayoutTests
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r211125 r211130 1 2017-01-24 Antoine Quint <graouts@apple.com> 2 3 Work around a crash when running media/modern-media-controls/pip-support/pip-support-enabled.html 4 https://bugs.webkit.org/show_bug.cgi?id=167381 5 6 Reviewed by Dean Jackson. 7 8 The test at media/modern-media-controls/pip-support/pip-support-enabled.html would crash because the test that 9 preceded it, media/modern-media-controls/pip-support/pip-support-click.html, would not exit the PiP presentation mode 10 before exiting the test. We now exit PiP before proceeding to the next test which avoid hitting the assertion 11 and the crash in Debug builds. 12 13 * media/modern-media-controls/pip-support/pip-support-click.html: 14 * platform/mac-wk1/TestExpectations: 15 1 16 2017-01-24 Brent Fulgham <bfulgham@apple.com> 2 17 -
trunk/LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html
r210959 r211130 25 25 description("Testing the <code>PiPSupport</code> behavior when clicking the PiP button."); 26 26 27 iconService.directoryPath = "../../../../Source/WebCore/Modules/modern-media-controls/images";28 29 27 if (window.internals) 30 28 window.internals.settings.setAllowsPictureInPictureMediaPlayback(true); … … 49 47 media.addEventListener("webkitpresentationmodechanged", () => { 50 48 shouldBeEqualToString("media.webkitPresentationMode", "picture-in-picture"); 49 50 // FIXME: We exit PiP so we leave things in a clean state, otherwise the following 51 // test pip-support-enabled.html may crash, see webkit.org/b/164336. 52 media.webkitSetPresentationMode("inline"); 53 51 54 container.remove(); 52 55 media.remove(); -
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r211119 r211130 302 302 webkit.org/b/167253 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html [ Pass Failure ] 303 303 304 webkit.org/b/164336 [ Sierra Debug ] media/modern-media-controls/pip-support/pip-support-enabled.html [ Crash ]305 306 304 webkit.org/b/167320 [ Sierra Release ] media/modern-media-controls/placard-support/placard-support-pip.html [ Pass Crash ] 307 305
Note: See TracChangeset
for help on using the changeset viewer.