Changeset 211376 in webkit
- Timestamp:
- Jan 30, 2017 10:45:21 AM (7 years ago)
- Location:
- trunk/Source
- Files:
-
- 20 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r211375 r211376 1 2017-01-30 Chris Dumez <cdumez@apple.com> 2 3 Update DiagnosticLoggingClient::logDiagnosticMessageWithValue() to take in the value as a double 4 https://bugs.webkit.org/show_bug.cgi?id=167536 5 6 Reviewed by Darin Adler. 7 8 Update DiagnosticLoggingClient::logDiagnosticMessageWithValue() to take in the value as a double 9 instead of a string. The value needs to be numeric and the current API is error-prone. 10 11 * html/HTMLMediaElement.cpp: 12 (WebCore::HTMLMediaElement::mediaPlayerEngineFailedToLoad): 13 * loader/EmptyClients.cpp: 14 * page/DiagnosticLoggingClient.h: 15 1 16 2017-01-30 Ryan Haddad <ryanhaddad@apple.com> 2 17 -
trunk/Source/WebCore/html/HTMLMediaElement.cpp
r211298 r211376 6473 6473 6474 6474 if (auto* page = document().page()) 6475 page->diagnosticLoggingClient().logDiagnosticMessageWithValue(DiagnosticLoggingKeys::engineFailedToLoadKey(), m_player->engineDescription(), String::number(m_player->platformErrorCode()), ShouldSample::No);6475 page->diagnosticLoggingClient().logDiagnosticMessageWithValue(DiagnosticLoggingKeys::engineFailedToLoadKey(), m_player->engineDescription(), m_player->platformErrorCode(), 4, ShouldSample::No); 6476 6476 } 6477 6477 -
trunk/Source/WebCore/loader/EmptyClients.cpp
r211033 r211376 117 117 void logDiagnosticMessage(const String&, const String&, ShouldSample) final { } 118 118 void logDiagnosticMessageWithResult(const String&, const String&, DiagnosticLoggingResultType, ShouldSample) final { } 119 void logDiagnosticMessageWithValue(const String&, const String&, const String&, ShouldSample) final { }119 void logDiagnosticMessageWithValue(const String&, const String&, double, unsigned, ShouldSample) final { } 120 120 }; 121 121 -
trunk/Source/WebCore/page/DiagnosticLoggingClient.h
r211233 r211376 40 40 virtual void logDiagnosticMessage(const String& message, const String& description, ShouldSample) = 0; 41 41 virtual void logDiagnosticMessageWithResult(const String& message, const String& description, DiagnosticLoggingResultType, ShouldSample) = 0; 42 // FIXME: rename this to logDiagnosticMessageWithNumericValue(). 43 virtual void logDiagnosticMessageWithValue(const String& message, const String& description, const String& value, ShouldSample) = 0; 42 virtual void logDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, ShouldSample) = 0; 44 43 45 44 static bool shouldLogAfterSampling(ShouldSample); -
trunk/Source/WebKit2/ChangeLog
r211368 r211376 1 2017-01-30 Chris Dumez <cdumez@apple.com> 2 3 Update DiagnosticLoggingClient::logDiagnosticMessageWithValue() to take in the value as a double 4 https://bugs.webkit.org/show_bug.cgi?id=167536 5 6 Reviewed by Darin Adler. 7 8 Update DiagnosticLoggingClient::logDiagnosticMessageWithValue() to take in the value as a double 9 instead of a string. The value needs to be numeric and the current API is error-prone. 10 11 * NetworkProcess/NetworkProcess.cpp: 12 (WebKit::NetworkProcess::logDiagnosticMessage): 13 (WebKit::NetworkProcess::logDiagnosticMessageWithResult): 14 (WebKit::NetworkProcess::logDiagnosticMessageWithValue): 15 * NetworkProcess/NetworkProcess.h: 16 * Scripts/webkit/messages.py: 17 (headers_for_type): 18 * Shared/WebCoreArgumentCoders.h: 19 * UIProcess/HighPerformanceGraphicsUsageSampler.cpp: 20 (WebKit::HighPerformanceGraphicsUsageSampler::timerFired): 21 * UIProcess/Network/NetworkProcessProxy.cpp: 22 (WebKit::NetworkProcessProxy::logDiagnosticMessage): 23 (WebKit::NetworkProcessProxy::logDiagnosticMessageWithResult): 24 (WebKit::NetworkProcessProxy::logDiagnosticMessageWithValue): 25 * UIProcess/Network/NetworkProcessProxy.h: 26 * UIProcess/Network/NetworkProcessProxy.messages.in: 27 * UIProcess/PerActivityStateCPUUsageSampler.cpp: 28 (WebKit::PerActivityStateCPUUsageSampler::loggingTimerFired): 29 * UIProcess/WebBackForwardList.cpp: 30 (WebKit::WebBackForwardList::goToItem): 31 * UIProcess/WebPageProxy.cpp: 32 (WebKit::WebPageProxy::logDiagnosticMessage): 33 (WebKit::WebPageProxy::logDiagnosticMessageWithResult): 34 (WebKit::WebPageProxy::logDiagnosticMessageWithValue): 35 * UIProcess/WebPageProxy.h: 36 * UIProcess/WebPageProxy.messages.in: 37 * WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp: 38 (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage): 39 (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult): 40 (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue): 41 * WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h: 42 1 43 2017-01-30 Csaba Osztrogonác <ossy@webkit.org> 2 44 -
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
r209498 r211376 586 586 return; 587 587 588 parentProcessConnection()->send(Messages::NetworkProcessProxy::Log SampledDiagnosticMessage(webPageID, message, description), 0);588 parentProcessConnection()->send(Messages::NetworkProcessProxy::LogDiagnosticMessage(webPageID, message, description, ShouldSample::No), 0); 589 589 } 590 590 … … 594 594 return; 595 595 596 parentProcessConnection()->send(Messages::NetworkProcessProxy::Log SampledDiagnosticMessageWithResult(webPageID, message, description, result), 0);597 } 598 599 void NetworkProcess::logDiagnosticMessageWithValue(uint64_t webPageID, const String& message, const String& description, const String& value, ShouldSample shouldSample)596 parentProcessConnection()->send(Messages::NetworkProcessProxy::LogDiagnosticMessageWithResult(webPageID, message, description, result, ShouldSample::No), 0); 597 } 598 599 void NetworkProcess::logDiagnosticMessageWithValue(uint64_t webPageID, const String& message, const String& description, double value, unsigned significantFigures, ShouldSample shouldSample) 600 600 { 601 601 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample)) 602 602 return; 603 603 604 parentProcessConnection()->send(Messages::NetworkProcessProxy::Log SampledDiagnosticMessageWithValue(webPageID, message, description, value), 0);604 parentProcessConnection()->send(Messages::NetworkProcessProxy::LogDiagnosticMessageWithValue(webPageID, message, description, value, significantFigures, ShouldSample::No), 0); 605 605 } 606 606 -
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
r210921 r211376 96 96 void logDiagnosticMessage(uint64_t webPageID, const String& message, const String& description, WebCore::ShouldSample); 97 97 void logDiagnosticMessageWithResult(uint64_t webPageID, const String& message, const String& description, WebCore::DiagnosticLoggingResultType, WebCore::ShouldSample); 98 void logDiagnosticMessageWithValue(uint64_t webPageID, const String& message, const String& description, const String& value, WebCore::ShouldSample);98 void logDiagnosticMessageWithValue(uint64_t webPageID, const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample); 99 99 100 100 #if PLATFORM(COCOA) -
trunk/Source/WebKit2/Scripts/webkit/messages.py
r211356 r211376 361 361 'WebCore::PluginInfo': ['<WebCore/PluginData.h>'], 362 362 'WebCore::RecentSearch': ['<WebCore/SearchPopupMenu.h>'], 363 'WebCore::ShouldSample': ['<WebCore/DiagnosticLoggingClient.h>'], 363 364 'WebCore::TextCheckingRequestData': ['<WebCore/TextChecking.h>'], 364 365 'WebCore::TextCheckingResult': ['<WebCore/TextCheckerClient.h>'], -
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.h
r210921 r211376 28 28 #include "ArgumentCoders.h" 29 29 #include <WebCore/ColorSpace.h> 30 #include <WebCore/DiagnosticLoggingClient.h> 30 31 #include <WebCore/FrameLoaderTypes.h> 31 32 #include <WebCore/IndexedDB.h> … … 645 646 }; 646 647 648 template<> struct EnumTraits<WebCore::ShouldSample> { 649 using values = EnumValues< 650 WebCore::ShouldSample, 651 WebCore::ShouldSample::No, 652 WebCore::ShouldSample::Yes 653 >; 654 }; 655 647 656 #if ENABLE(INDEXED_DATABASE) 648 657 template<> struct EnumTraits<WebCore::IndexedDB::GetAllType> { -
trunk/Source/WebKit2/UIProcess/HighPerformanceGraphicsUsageSampler.cpp
r211229 r211376 73 73 state = DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey(); 74 74 75 firstPage->logDiagnosticMessage(DiagnosticLoggingKeys::webGLStateKey(), state, false);75 firstPage->logDiagnosticMessage(DiagnosticLoggingKeys::webGLStateKey(), state, ShouldSample::No); 76 76 } 77 77 -
trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp
r210887 r211376 317 317 } 318 318 319 void NetworkProcessProxy::log SampledDiagnosticMessage(uint64_t pageID, const String& message, const String& description)319 void NetworkProcessProxy::logDiagnosticMessage(uint64_t pageID, const String& message, const String& description, WebCore::ShouldSample shouldSample) 320 320 { 321 321 WebPageProxy* page = WebProcessProxy::webPage(pageID); … … 325 325 return; 326 326 327 page->log SampledDiagnosticMessage(message, description);328 } 329 330 void NetworkProcessProxy::log SampledDiagnosticMessageWithResult(uint64_t pageID, const String& message, const String& description, uint32_t result)327 page->logDiagnosticMessage(message, description, shouldSample); 328 } 329 330 void NetworkProcessProxy::logDiagnosticMessageWithResult(uint64_t pageID, const String& message, const String& description, uint32_t result, WebCore::ShouldSample shouldSample) 331 331 { 332 332 WebPageProxy* page = WebProcessProxy::webPage(pageID); … … 336 336 return; 337 337 338 page->log SampledDiagnosticMessageWithResult(message, description, result);339 } 340 341 void NetworkProcessProxy::log SampledDiagnosticMessageWithValue(uint64_t pageID, const String& message, const String& description, const String& value)338 page->logDiagnosticMessageWithResult(message, description, result, shouldSample); 339 } 340 341 void NetworkProcessProxy::logDiagnosticMessageWithValue(uint64_t pageID, const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample shouldSample) 342 342 { 343 343 WebPageProxy* page = WebProcessProxy::webPage(pageID); … … 347 347 return; 348 348 349 page->log SampledDiagnosticMessageWithValue(message, description, value);349 page->logDiagnosticMessageWithValue(message, description, value, significantFigures, shouldSample); 350 350 } 351 351 -
trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h
r210887 r211376 40 40 class ProtectionSpace; 41 41 class ResourceRequest; 42 enum class ShouldSample; 42 43 class SecurityOrigin; 43 44 struct SecurityOriginData; … … 110 111 void didDeleteWebsiteDataForOrigins(uint64_t callbackID); 111 112 void grantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t requestID, const Vector<String>& paths); 112 void log SampledDiagnosticMessage(uint64_t pageID, const String& message, const String& description);113 void log SampledDiagnosticMessageWithResult(uint64_t pageID, const String& message, const String& description, uint32_t result);114 void log SampledDiagnosticMessageWithValue(uint64_t pageID, const String& message, const String& description, const String& value);113 void logDiagnosticMessage(uint64_t pageID, const String& message, const String& description, WebCore::ShouldSample); 114 void logDiagnosticMessageWithResult(uint64_t pageID, const String& message, const String& description, uint32_t result, WebCore::ShouldSample); 115 void logDiagnosticMessageWithValue(uint64_t pageID, const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample); 115 116 #if USE(PROTECTION_SPACE_AUTH_CALLBACK) 116 117 void canAuthenticateAgainstProtectionSpace(uint64_t loaderID, uint64_t pageID, uint64_t frameID, const WebCore::ProtectionSpace&); -
trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.messages.in
r202511 r211376 36 36 37 37 # Diagnostic messages logging 38 Log SampledDiagnosticMessage(uint64_t pageID, String message, String description)39 Log SampledDiagnosticMessageWithResult(uint64_t pageID, String message, String description, uint32_t result)40 Log SampledDiagnosticMessageWithValue(uint64_t pageID, String message, String description, String value)38 LogDiagnosticMessage(uint64_t pageID, String message, String description, enum WebCore::ShouldSample shouldSample) 39 LogDiagnosticMessageWithResult(uint64_t pageID, String message, String description, uint32_t result, enum WebCore::ShouldSample shouldSample) 40 LogDiagnosticMessageWithValue(uint64_t pageID, String message, String description, double value, unsigned significantFigures, enum WebCore::ShouldSample shouldSample) 41 41 42 42 #if USE(PROTECTION_SPACE_AUTH_CALLBACK) -
trunk/Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp
r211295 r211376 72 72 } 73 73 74 static String toStringRoundingSignificantFigures(double value, unsigned significantFigures)75 {76 DecimalNumber decimal(value, RoundingSignificantFigures, significantFigures);77 NumberToLStringBuffer buffer;78 unsigned length = decimal.toStringDecimal(buffer, WTF::NumberToStringBufferLength);79 return String(buffer, length);80 }81 82 74 void PerActivityStateCPUUsageSampler::loggingTimerFired() 83 75 { … … 94 86 double cpuUsage = static_cast<double>(pair.value * 100.) / cpuTimeDelta; 95 87 String activityStateKey = loggingKeyForActivityState(pair.key); 96 page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, toStringRoundingSignificantFigures(cpuUsage, 2), false);88 page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, cpuUsage, 2, ShouldSample::No); 97 89 RELEASE_LOG(PerformanceLogging, "WebContent processes used %.1f%% CPU in %s state", cpuUsage, activityStateKey.utf8().data()); 98 90 } -
trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp
r211304 r211376 30 30 #include "SessionState.h" 31 31 #include "WebPageProxy.h" 32 #include <WebCore/DiagnosticLoggingClient.h> 32 33 #include <WebCore/DiagnosticLoggingKeys.h> 33 34 34 35 namespace WebKit { 36 37 using namespace WebCore; 35 38 36 39 // FIXME: Make this static once WebBackForwardListCF.cpp is no longer using it. … … 180 183 unsigned delta = m_entries.size() - targetIndex - 1; 181 184 String deltaValue = delta > 10 ? ASCIILiteral("over10") : String::number(delta); 182 m_page->logDiagnosticMessage(WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey(), deltaValue, false /* shouldSample */);185 m_page->logDiagnosticMessage(WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey(), deltaValue, ShouldSample::No); 183 186 } 184 187 -
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
r211312 r211376 5169 5169 #endif 5170 5170 5171 void WebPageProxy::logDiagnosticMessage(const String& message, const String& description, bool shouldSample) 5172 { 5173 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample ? ShouldSample::Yes : ShouldSample::No)) 5174 return; 5175 5176 logSampledDiagnosticMessage(message, description); 5177 } 5178 5179 void WebPageProxy::logDiagnosticMessageWithResult(const String& message, const String& description, uint32_t result, bool shouldSample) 5180 { 5181 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample ? ShouldSample::Yes : ShouldSample::No)) 5182 return; 5183 5184 logSampledDiagnosticMessageWithResult(message, description, static_cast<WebCore::DiagnosticLoggingResultType>(result)); 5185 } 5186 5187 void WebPageProxy::logDiagnosticMessageWithValue(const String& message, const String& description, const String& value, bool shouldSample) 5188 { 5189 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample ? ShouldSample::Yes : ShouldSample::No)) 5190 return; 5191 5192 logSampledDiagnosticMessageWithValue(message, description, value); 5193 } 5194 5195 void WebPageProxy::logSampledDiagnosticMessage(const String& message, const String& description) 5196 { 5171 void WebPageProxy::logDiagnosticMessage(const String& message, const String& description, WebCore::ShouldSample shouldSample) 5172 { 5173 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample)) 5174 return; 5175 5197 5176 m_diagnosticLoggingClient->logDiagnosticMessage(this, message, description); 5198 5177 } 5199 5178 5200 void WebPageProxy::logSampledDiagnosticMessageWithResult(const String& message, const String& description, uint32_t result) 5201 { 5179 void WebPageProxy::logDiagnosticMessageWithResult(const String& message, const String& description, uint32_t result, WebCore::ShouldSample shouldSample) 5180 { 5181 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample)) 5182 return; 5183 5202 5184 m_diagnosticLoggingClient->logDiagnosticMessageWithResult(this, message, description, static_cast<WebCore::DiagnosticLoggingResultType>(result)); 5203 5185 } 5204 5186 5205 void WebPageProxy::logSampledDiagnosticMessageWithValue(const String& message, const String& description, const String& value) 5206 { 5207 m_diagnosticLoggingClient->logDiagnosticMessageWithValue(this, message, description, value); 5187 void WebPageProxy::logDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, ShouldSample shouldSample) 5188 { 5189 if (!DiagnosticLoggingClient::shouldLogAfterSampling(shouldSample)) 5190 return; 5191 5192 m_diagnosticLoggingClient->logDiagnosticMessageWithValue(this, message, description, String::number(value, significantFigures)); 5208 5193 } 5209 5194 -
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
r211356 r211376 157 157 class TextIndicator; 158 158 class ValidationBubble; 159 enum class HasInsecureContent; 159 160 160 struct DictionaryPopupInfo; 161 161 struct ExceptionDetails; … … 167 167 struct ViewportAttributes; 168 168 struct WindowFeatures; 169 170 enum class HasInsecureContent; 171 enum class ShouldSample; 169 172 } 170 173 … … 1124 1127 1125 1128 // Diagnostic messages logging. 1126 void logDiagnosticMessage(const String& message, const String& description, bool shouldSample); 1127 void logDiagnosticMessageWithResult(const String& message, const String& description, uint32_t result, bool shouldSample); 1128 void logDiagnosticMessageWithValue(const String& message, const String& description, const String& value, bool shouldSample); 1129 void logSampledDiagnosticMessage(const String& message, const String& description); 1130 void logSampledDiagnosticMessageWithResult(const String& message, const String& description, uint32_t result); 1131 void logSampledDiagnosticMessageWithValue(const String& message, const String& description, const String& value); 1129 void logDiagnosticMessage(const String& message, const String& description, WebCore::ShouldSample); 1130 void logDiagnosticMessageWithResult(const String& message, const String& description, uint32_t result, WebCore::ShouldSample); 1131 void logDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample); 1132 1132 1133 1133 // Form validation messages. -
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
r211356 r211376 236 236 237 237 # Diagnostic messages logging 238 Log SampledDiagnosticMessage(String message, String description)239 Log SampledDiagnosticMessageWithResult(String message, String description, uint32_t result)240 Log SampledDiagnosticMessageWithValue(String message, String description, String value)238 LogDiagnosticMessage(String message, String description, enum WebCore::ShouldSample shouldSample) 239 LogDiagnosticMessageWithResult(String message, String description, uint32_t result, enum WebCore::ShouldSample shouldSample) 240 LogDiagnosticMessageWithValue(String message, String description, double value, unsigned significantFigures, enum WebCore::ShouldSample shouldSample) 241 241 242 242 # Editor notifications -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp
r199955 r211376 33 33 namespace WebKit { 34 34 35 using namespace WebCore; 36 35 37 WebDiagnosticLoggingClient::WebDiagnosticLoggingClient(WebPage& page) 36 38 : m_page(page) … … 51 53 // FIXME: Remove this injected bundle API. 52 54 m_page.injectedBundleDiagnosticLoggingClient().logDiagnosticMessage(&m_page, message, description); 53 m_page.send(Messages::WebPageProxy::Log SampledDiagnosticMessage(message, description));55 m_page.send(Messages::WebPageProxy::LogDiagnosticMessage(message, description, ShouldSample::No)); 54 56 } 55 57 … … 63 65 // FIXME: Remove this injected bundle API. 64 66 m_page.injectedBundleDiagnosticLoggingClient().logDiagnosticMessageWithResult(&m_page, message, description, result); 65 m_page.send(Messages::WebPageProxy::Log SampledDiagnosticMessageWithResult(message, description, result));67 m_page.send(Messages::WebPageProxy::LogDiagnosticMessageWithResult(message, description, result, ShouldSample::No)); 66 68 } 67 69 68 void WebDiagnosticLoggingClient::logDiagnosticMessageWithValue(const String& message, const String& description, const String& value, WebCore::ShouldSample shouldSample)70 void WebDiagnosticLoggingClient::logDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample shouldSample) 69 71 { 70 72 ASSERT(!m_page.corePage() || m_page.corePage()->settings().diagnosticLoggingEnabled()); … … 74 76 75 77 // FIXME: Remove this injected bundle API. 76 m_page.injectedBundleDiagnosticLoggingClient().logDiagnosticMessageWithValue(&m_page, message, description, value);77 m_page.send(Messages::WebPageProxy::Log SampledDiagnosticMessageWithValue(message, description, value));78 m_page.injectedBundleDiagnosticLoggingClient().logDiagnosticMessageWithValue(&m_page, message, description, String::number(value, significantFigures)); 79 m_page.send(Messages::WebPageProxy::LogDiagnosticMessageWithValue(message, description, value, significantFigures, ShouldSample::No)); 78 80 } 79 81 -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h
r199955 r211376 42 42 void logDiagnosticMessage(const String& message, const String& description, WebCore::ShouldSample) override; 43 43 void logDiagnosticMessageWithResult(const String& message, const String& description, WebCore::DiagnosticLoggingResultType, WebCore::ShouldSample) override; 44 void logDiagnosticMessageWithValue(const String& message, const String& description, const String& value, WebCore::ShouldSample) override;44 void logDiagnosticMessageWithValue(const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample) override; 45 45 46 46 WebPage& m_page;
Note: See TracChangeset
for help on using the changeset viewer.