Changeset 211377 in webkit

Timestamp:

Jan 30, 2017, 10:59:36 AM (8 years ago)

Author:

Wenson Hsieh

Message:

Web content process crashes when initiating a drag on a very large image
​https://bugs.webkit.org/show_bug.cgi?id=167564

Reviewed by Beth Dakin.

If we begin dragging an image element that is too large to show the cached image for, we will show an image file
icon instead of the cached image. This may return null if createDragImageIconForCachedImageFilename is
unimplemented, so in the meantime, we should not assume that dragImage will always exist before calling into
doSystemDrag in doImageDrag and bail from the drag operation if that is the case.

• page/DragController.cpp:

(WebCore::DragController::doImageDrag):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DragController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Web content process crashes when initiating a drag on a very large image
+        https://bugs.webkit.org/show_bug.cgi?id=167564
+
+        Reviewed by Beth Dakin.
+
+        If we begin dragging an image element that is too large to show the cached image for, we will show an image file
+        icon instead of the cached image. This may return null if createDragImageIconForCachedImageFilename is
+        unimplemented, so in the meantime, we should not assume that dragImage will always exist before calling into
+        doSystemDrag in doImageDrag and bail from the drag operation if that is the case.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::doImageDrag):
+
 2017-01-30  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/DragController.cpp

@@ -978 +978 @@
     }
 
+    if (!dragImage)
+        return;
+
     dragImageOffset = mouseDownPoint + scaledOrigin;
     doSystemDrag(dragImage, dragImageOffset, dragOrigin, dataTransfer, frame, false);