Changeset 211385 in webkit

Timestamp:

Jan 30, 2017 2:01:07 PM (7 years ago)

Author:

Matt Baker

Message:

Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
​https://bugs.webkit.org/show_bug.cgi?id=165633
<rdar://problem/29738502>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch limits the memory used by the Inspector backend to store async
stack trace data.

Asynchronous stack traces are stored as a disjoint set of parent pointer
trees. Tree nodes represent asynchronous operations, and hold a copy of
the stack trace at the time the operation was scheduled. Each tree can
be regarded as a set of stack traces, stored as singly linked lists that
share part of their structure (specifically their tails). Traces belonging
to the same tree will at least share a common root. A stack trace begins
at a leaf node and follows the chain of parent pointers to the root of
of the tree. Leaf nodes always contain pending asynchronous calls.

When an asynchronous operation is scheduled with requestAnimationFrame,
setInterval, etc, a node is created containing the current call stack and
some bookkeeping data for the operation. An unique identifier comprised
of an operation type and callback identifier is mapped to the node. If
scheduling the callback was itself the result of an asynchronous call,
the node becomes a child of the node associated with that call, otherwise
it becomes the root of a new tree.

A node is either pending, active, dispatched, or canceled. Nodes
start out as pending. After a callback for a pending node is dispatched
the node is marked as such, unless it is a repeating callback such as
setInterval, in which case it remains pending. Once a node is no longer
pending it is removed, as long as it has no children. Since nodes are
reference counted, it is a property of the stack trace tree that nodes
that are no longer pending and have no children pointing to them will be
automatically pruned from the tree.

If an async operation is canceled (e.g. cancelTimeout), the associated
node is marked as such. If the callback is not being dispatched at the
time, and has no children, it is removed.

Because async operations can be chained indefinitely, stack traces are
limited to a maximum depth. The depth of a stack trace is equal to the
sum of the depths of its nodes, with a node's depth equal to the number
of frames in its associated call stack. For any stack trace,

S = { s𝟶, s𝟷, …, s𝑘 }, with endpoints s𝟶, s𝑘
depth(S) = depth(s𝟶) + depth(s𝟷) + … + depth(s𝑘)

A stack trace is truncated when it exceeds the maximum depth. Truncation
occurs on node boundaries, not call frames, consequently the maximum depth
is more of a target than a guarantee:

d = maximum stack trace depth
for all S, depth(S) ≤ d + depth(s𝑘)

Because nodes can belong to multiple stack traces, it may be necessary
to clone the tail of a stack trace being truncated to prevent other traces
from being effected.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• inspector/AsyncStackTrace.cpp: Added.

(Inspector::AsyncStackTrace::create):
(Inspector::AsyncStackTrace::AsyncStackTrace):
(Inspector::AsyncStackTrace::~AsyncStackTrace):
(Inspector::AsyncStackTrace::isPending):
(Inspector::AsyncStackTrace::isLocked):
(Inspector::AsyncStackTrace::willDispatchAsyncCall):
(Inspector::AsyncStackTrace::didDispatchAsyncCall):
(Inspector::AsyncStackTrace::didCancelAsyncCall):
(Inspector::AsyncStackTrace::buildInspectorObject):
(Inspector::AsyncStackTrace::truncate):
(Inspector::AsyncStackTrace::remove):

• inspector/AsyncStackTrace.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::InspectorDebuggerAgent::didCancelAsyncCall):
(Inspector::InspectorDebuggerAgent::willDispatchAsyncCall):
(Inspector::InspectorDebuggerAgent::didDispatchAsyncCall):
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::clearAsyncStackTraceData):
(Inspector::InspectorDebuggerAgent::buildAsyncStackTrace): Deleted.
(Inspector::InspectorDebuggerAgent::refAsyncCallData): Deleted.
(Inspector::InspectorDebuggerAgent::derefAsyncCallData): Deleted.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/protocol/Console.json:

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

Text for "Truncated" marker tree element.

• UserInterface/Models/StackTrace.js:

(WebInspector.StackTrace):
(WebInspector.StackTrace.fromPayload):
(WebInspector.StackTrace.prototype.get truncated):
Plumbing for new Console.StackTrace property truncated.

• UserInterface/Views/ThreadTreeElement.css:

(.tree-outline > .item.thread + ol > .item.truncated-call-frames):
(.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
Styles for "Truncated" marker tree element.

• UserInterface/Views/ThreadTreeElement.js:

(WebInspector.ThreadTreeElement.prototype.refresh):
Append "Truncated" marker tree element if necessary.

• Versions/Inspector-iOS-10.3.json:

LayoutTests:

Add truncation test cases and cleanup call frame logging.

• inspector/debugger/async-stack-trace-expected.txt:
• inspector/debugger/async-stack-trace.html:
• inspector/debugger/resources/log-active-stack-trace.js: Added.

(TestPage.registerInitializer.window.getActiveStackTrace):
(TestPage.registerInitializer.logStackTrace.logCallFrame):
(TestPage.registerInitializer.):
(TestPage.registerInitializer.window.logActiveStackTrace):
(TestPage.registerInitializer):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/debugger/async-stack-trace-expected.txt (modified) (6 diffs)
• LayoutTests/inspector/debugger/async-stack-trace.html (modified) (5 diffs)
• LayoutTests/inspector/debugger/resources/log-active-stack-trace.js (added)
• Source/JavaScriptCore/CMakeLists.txt (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (71 diffs)
• Source/JavaScriptCore/inspector/AsyncStackTrace.cpp (added)
• Source/JavaScriptCore/inspector/AsyncStackTrace.h (copied) (copied from trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css) (2 diffs)
• Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp (modified) (8 diffs)
• Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h (modified) (4 diffs)
• Source/JavaScriptCore/inspector/protocol/Console.json (modified) (1 diff)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Models/StackTrace.js (modified) (4 diffs)
• Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.js (modified) (1 diff)
• Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-01-30  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
+        https://bugs.webkit.org/show_bug.cgi?id=165633
+        <rdar://problem/29738502>
+
+        Reviewed by Joseph Pecoraro.
+
+        Add truncation test cases and cleanup call frame logging.
+
+        * inspector/debugger/async-stack-trace-expected.txt:
+        * inspector/debugger/async-stack-trace.html:
+        * inspector/debugger/resources/log-active-stack-trace.js: Added.
+        (TestPage.registerInitializer.window.getActiveStackTrace):
+        (TestPage.registerInitializer.logStackTrace.logCallFrame):
+        (TestPage.registerInitializer.):
+        (TestPage.registerInitializer.window.logActiveStackTrace):
+        (TestPage.registerInitializer):
+
 2017-01-30  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/inspector/debugger/async-stack-trace-expected.txt

@@ -7 +7 @@
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] requestAnimationFrame ----
-1: [F] testRequestAnimationFrame
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- requestAnimationFrame ---
+2: [F] testRequestAnimationFrame
+3: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.SetTimeout
@@ -15 +16 @@
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] setTimeout ----
-1: [F] testSetTimeout
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setTimeout ---
+2: [F] testSetTimeout
+3: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.SetInterval
@@ -23 +25 @@
 CALL STACK:
 0: [F] intervalFired
--- [N] setInterval ----
-1: [F] testSetInterval
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setInterval ---
+2: [F] testSetInterval
+3: [P] Global Code
 PAUSE #2
 CALL STACK:
 0: [F] intervalFired
--- [N] setInterval ----
-1: [F] testSetInterval
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setInterval ---
+2: [F] testSetInterval
+3: [P] Global Code
 PAUSE #3
 CALL STACK:
 0: [F] intervalFired
--- [N] setInterval ----
-1: [F] testSetInterval
-2: [P] Global Code
+ASYNC CALL STACK:
+1: --- setInterval ---
+2: [F] testSetInterval
+3: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.ChainedRequestAnimationFrame
@@ -43 +48 @@
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] requestAnimationFrame ----
-1: [F] testRequestAnimationFrame
--- [N] requestAnimationFrame ----
-2: [F] testChainedRequestAnimationFrame
-3: [P] Global Code
+ASYNC CALL STACK:
+1: --- requestAnimationFrame ---
+2: [F] testRequestAnimationFrame
+3: --- requestAnimationFrame ---
+4: [F] testChainedRequestAnimationFrame
+5: [P] Global Code
 
 -- Running test case: CheckAsyncStackTrace.ReferenceCounting
@@ -53 +59 @@
 CALL STACK:
 0: [F] pauseThenFinishTest
--- [N] setTimeout ----
-1: [F] intervalFired
--- [N] setInterval ----
-2: [F] testReferenceCounting
-3: [P] Global Code
+ASYNC CALL STACK:
+1: --- setTimeout ---
+2: [F] intervalFired
+3: --- setInterval ---
+4: [F] testReferenceCounting
+5: [P] Global Code
 -- Running test setup.
 Save DebuggerManager.asyncStackTraceDepth
@@ -68 +75 @@
 Save DebuggerManager.asyncStackTraceDepth
 
--- Running test case: AsyncStackTrace.SetStackTraceDepth
-PASS: Number of call frames should be equal to the depth setting.
+-- Running test case: AsyncStackTrace.ForceTruncationOnCallStackBoundary
+Set Debugger.asyncStackTraceDepth equal to 4
+PASS: Non-root StackTrace should not be truncated.
+PASS: Non-root StackTrace should not be truncated.
+PASS: StackTrace root should be truncated.
+PASS: StackTrace should be truncated to the nearest call stack.
+CALL STACK:
+0: [F] pauseThenFinishTest
+1: [F] repeat
+ASYNC CALL STACK:
+2: --- requestAnimationFrame ---
+3: [F] repeat
+4: --- requestAnimationFrame ---
+5: [F] repeat
+(remaining call frames truncated)
+-- Running test teardown.
+Restore DebuggerManager.asyncStackTraceDepth
+-- Running test setup.
+Save DebuggerManager.asyncStackTraceDepth
+
+-- Running test case: AsyncStackTrace.ForceTruncationWithinCallStack
+Set Debugger.asyncStackTraceDepth equal to 5
+PASS: Non-root StackTrace should not be truncated.
+PASS: Non-root StackTrace should not be truncated.
+PASS: Non-root StackTrace should not be truncated.
+PASS: StackTrace root should be truncated.
+PASS: StackTrace should be truncated to the nearest call stack.
+CALL STACK:
+0: [F] pauseThenFinishTest
+1: [F] repeat
+ASYNC CALL STACK:
+2: --- requestAnimationFrame ---
+3: [F] repeat
+4: --- requestAnimationFrame ---
+5: [F] repeat
+6: --- requestAnimationFrame ---
+7: [F] repeat
+(remaining call frames truncated)
 -- Running test teardown.
 Restore DebuggerManager.asyncStackTraceDepth

trunk/LayoutTests/inspector/debugger/async-stack-trace.html

@@ -3 +3 @@
 <head>
 <script src="../../http/tests/inspector/resources/inspector-test.js"></script>
+<script src="resources/log-active-stack-trace.js"></script>
 <script>
 const timerDelay = 20;
@@ -49 +50 @@
 }
 
+function repeatingRequestAnimationFrame(repeatCount) {
+    let count = 0;
+    function repeat() {
+        if (count++ === repeatCount) {
+            pauseThenFinishTest();
+            return;
+        }
+        requestAnimationFrame(repeat);
+    }
+    requestAnimationFrame(repeat);
+}
+
 function test()
 {
     let suite = InspectorTest.createAsyncSuite("AsyncStackTrace");
-
-    function activeTargetData() {
-        InspectorTest.assert(WebInspector.debuggerManager.activeCallFrame, "Active call frame should exist.");
-        if (!WebInspector.debuggerManager.activeCallFrame)
-            return null;
-
-        let targetData = WebInspector.debuggerManager.dataForTarget(WebInspector.debuggerManager.activeCallFrame.target);
-        InspectorTest.assert(targetData, "Data for active call frame target should exist.");
-        return targetData;
-    }
-
-    function logCallStack() {
-        function callFrameString(callFrame) {
-            let code = callFrame.nativeCode ? "N" : (callFrame.programCode ? "P" : "F");
-            return `[${code}] ${callFrame.functionName}`;
-        }
-
-        function logCallFrames(callFrames) {
-            for (let callFrame of callFrames) {
-                InspectorTest.log(`${callFrameIndex++}: ${callFrameString(callFrame)}`);
-                // Skip remaining call frames after the test harness entry point.
-                if (callFrame.programCode)
-                    break;
-            }
-        }
-
-        let {callFrames, asyncStackTrace} = activeTargetData();
-        InspectorTest.assert(callFrames);
-        InspectorTest.assert(asyncStackTrace);
-
-        let callFrameIndex = 0;
-        logCallFrames(callFrames);
-
-        while (asyncStackTrace) {
-            let callFrames = asyncStackTrace.callFrames;
-            let topCallFrameIsBoundary = asyncStackTrace.topCallFrameIsBoundary;
-            asyncStackTrace = asyncStackTrace.parentStackTrace;
-            if (!callFrames || !callFrames.length)
-                continue;
-
-            let boundaryLabel = topCallFrameIsBoundary ? callFrameString(callFrames.shift()) : "(async)";
-            InspectorTest.log(`-- ${boundaryLabel} ----`);
-            logCallFrames(callFrames);
-        }
-    }
 
     function addSimpleTestCase(name, expression) {
@@ -105 +73 @@
                 function handlePaused() {
                     InspectorTest.log(`PAUSE #${++pauseCount}`);
-                    InspectorTest.log("CALL STACK:");
-                    logCallStack();
+                    logActiveStackTrace();
                     WebInspector.debuggerManager.resume();
                 }
@@ -147 +114 @@
             WebInspector.debuggerManager.awaitEvent(WebInspector.DebuggerManager.Event.Paused)
             .then((event) => {
-                let stackTrace = activeTargetData().asyncStackTrace;
-                InspectorTest.expectNull(stackTrace, "Async stack trace should be null.");
+                let stackTrace = getActiveStackTrace();
+                let asyncStackTrace = stackTrace.parentStackTrace;
+                InspectorTest.expectNull(asyncStackTrace, "Async stack trace should be null.");
                 WebInspector.debuggerManager.resume().then(resolve, reject);
             });
@@ -157 +125 @@
     });
 
-    suite.addTestCase({
-        name: "AsyncStackTrace.SetStackTraceDepth",
-        setup,
-        teardown,
-        test(resolve, reject) {
-            WebInspector.debuggerManager.awaitEvent(WebInspector.DebuggerManager.Event.Paused)
-            .then((event) => {
-                let stackTrace = activeTargetData().asyncStackTrace;
-                InspectorTest.assert(stackTrace && stackTrace.callFrames);
-                if (!stackTrace || !stackTrace.callFrames)
-                    reject();
+    function addTruncateTestCase(name, asyncStackTraceDepth) {
+        suite.addTestCase({
+            name: `AsyncStackTrace.${name}`,
+            setup,
+            teardown,
+            test(resolve, reject) {
+                // When repeatingRequestAnimationFrame calls rAF, the backend will store a call stack with length 2:
+                // one frame for the caller and one for the asynchronous boundary. As a result, the parity of
+                // Debugger.asyncStackTraceDepth determines whether the trace is truncated on a call stack boundary
+                // (even) or call frame boundary (odd). Since truncation doesn't remove individual call frames,
+                // the depth of the resulting stack trace may exceed the depth setting:
+                //     S = { s𝟶, s𝟷, …, s𝑘 }
+                //     T = truncate(S)
+                //     depth(T) ≤ d + depth(t𝑘)
+                const framesPerCallStack = 2;
+                const expectedStackTraceDepth = asyncStackTraceDepth + (asyncStackTraceDepth % framesPerCallStack);
 
-                InspectorTest.expectEqual(stackTrace.callFrames.length, maxStackDepth, "Number of call frames should be equal to the depth setting.");
-                WebInspector.debuggerManager.resume().then(resolve, reject);
-            });
+                WebInspector.debuggerManager.awaitEvent(WebInspector.DebuggerManager.Event.Paused)
+                .then((event) => {
+                    let stackTrace = getActiveStackTrace();
+                    InspectorTest.assert(stackTrace && stackTrace.callFrames);
+                    if (!stackTrace || !stackTrace.callFrames)
+                        reject();
 
-            const maxStackDepth = 2;
-            const functionCallCount = maxStackDepth * 2;
-            WebInspector.debuggerManager.asyncStackTraceDepth = maxStackDepth;
-            InspectorTest.evaluateInPage(`recursiveCallThenTest(testRequestAnimationFrame, ${functionCallCount})`);
-        }
-    });
+                    let stackTraceDepth = 0;
+                    while (stackTrace.parentStackTrace) {
+                        InspectorTest.expectFalse(stackTrace.truncated, "Non-root StackTrace should not be truncated.");
+                        stackTrace = stackTrace.parentStackTrace;
+                        stackTraceDepth += stackTrace.callFrames.length;
+                    }
+
+                    InspectorTest.expectThat(stackTrace.truncated, "StackTrace root should be truncated.");
+                    InspectorTest.expectEqual(stackTraceDepth, expectedStackTraceDepth, "StackTrace should be truncated to the nearest call stack.");
+
+                    logActiveStackTrace();
+                    WebInspector.debuggerManager.resume().then(resolve, reject);
+                });
+
+                InspectorTest.log(`Set Debugger.asyncStackTraceDepth equal to ${asyncStackTraceDepth}`);
+                WebInspector.debuggerManager.asyncStackTraceDepth = asyncStackTraceDepth;
+
+                let repeatCount = Math.floor(asyncStackTraceDepth / framesPerCallStack) + 1;
+                InspectorTest.evaluateInPage(`repeatingRequestAnimationFrame(${repeatCount})`);
+            }
+        });
+    }
+
+    addTruncateTestCase("ForceTruncationOnCallStackBoundary", 4);
+    addTruncateTestCase("ForceTruncationWithinCallStack", 5);
 
     suite.runTestCasesAndFinish();

trunk/Source/JavaScriptCore/CMakeLists.txt

@@ -515 +515 @@
     heap/WriteBarrierSupport.cpp
 
+    inspector/AsyncStackTrace.cpp
     inspector/ConsoleMessage.cpp
     inspector/ContentSearchUtilities.cpp

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-01-30  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
+        https://bugs.webkit.org/show_bug.cgi?id=165633
+        <rdar://problem/29738502>
+
+        Reviewed by Joseph Pecoraro.
+
+        This patch limits the memory used by the Inspector backend to store async
+        stack trace data.
+
+        Asynchronous stack traces are stored as a disjoint set of parent pointer
+        trees. Tree nodes represent asynchronous operations, and hold a copy of
+        the stack trace at the time the operation was scheduled. Each tree can
+        be regarded as a set of stack traces, stored as singly linked lists that
+        share part of their structure (specifically their tails). Traces belonging
+        to the same tree will at least share a common root. A stack trace begins
+        at a leaf node and follows the chain of parent pointers to the root of
+        of the tree. Leaf nodes always contain pending asynchronous calls.
+
+        When an asynchronous operation is scheduled with requestAnimationFrame,
+        setInterval, etc, a node is created containing the current call stack and
+        some bookkeeping data for the operation. An unique identifier comprised
+        of an operation type and callback identifier is mapped to the node. If
+        scheduling the callback was itself the result of an asynchronous call,
+        the node becomes a child of the node associated with that call, otherwise
+        it becomes the root of a new tree.
+
+        A node is either `pending`, `active`, `dispatched`, or `canceled`. Nodes
+        start out as pending. After a callback for a pending node is dispatched
+        the node is marked as such, unless it is a repeating callback such as
+        setInterval, in which case it remains pending. Once a node is no longer
+        pending it is removed, as long as it has no children. Since nodes are
+        reference counted, it is a property of the stack trace tree that nodes
+        that are no longer pending and have no children pointing to them will be
+        automatically pruned from the tree.
+
+        If an async operation is canceled (e.g. cancelTimeout), the associated
+        node is marked as such. If the callback is not being dispatched at the
+        time, and has no children, it is removed.
+
+        Because async operations can be chained indefinitely, stack traces are
+        limited to a maximum depth. The depth of a stack trace is equal to the
+        sum of the depths of its nodes, with a node's depth equal to the number
+        of frames in its associated call stack. For any stack trace,
+
+            S = { s𝟶, s𝟷, …, s𝑘 }, with endpoints s𝟶, s𝑘
+            depth(S) = depth(s𝟶) + depth(s𝟷) + … + depth(s𝑘)
+
+        A stack trace is truncated when it exceeds the maximum depth. Truncation
+        occurs on node boundaries, not call frames, consequently the maximum depth
+        is more of a target than a guarantee:
+
+            d = maximum stack trace depth
+            for all S, depth(S) ≤ d + depth(s𝑘)
+
+        Because nodes can belong to multiple stack traces, it may be necessary
+        to clone the tail of a stack trace being truncated to prevent other traces
+        from being effected.
+
+        * CMakeLists.txt:
+        * JavaScriptCore.xcodeproj/project.pbxproj:
+        * inspector/AsyncStackTrace.cpp: Added.
+        (Inspector::AsyncStackTrace::create):
+        (Inspector::AsyncStackTrace::AsyncStackTrace):
+        (Inspector::AsyncStackTrace::~AsyncStackTrace):
+        (Inspector::AsyncStackTrace::isPending):
+        (Inspector::AsyncStackTrace::isLocked):
+        (Inspector::AsyncStackTrace::willDispatchAsyncCall):
+        (Inspector::AsyncStackTrace::didDispatchAsyncCall):
+        (Inspector::AsyncStackTrace::didCancelAsyncCall):
+        (Inspector::AsyncStackTrace::buildInspectorObject):
+        (Inspector::AsyncStackTrace::truncate):
+        (Inspector::AsyncStackTrace::remove):
+        * inspector/AsyncStackTrace.h:
+        * inspector/agents/InspectorDebuggerAgent.cpp:
+        (Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
+        (Inspector::InspectorDebuggerAgent::didCancelAsyncCall):
+        (Inspector::InspectorDebuggerAgent::willDispatchAsyncCall):
+        (Inspector::InspectorDebuggerAgent::didDispatchAsyncCall):
+        (Inspector::InspectorDebuggerAgent::didPause):
+        (Inspector::InspectorDebuggerAgent::clearAsyncStackTraceData):
+        (Inspector::InspectorDebuggerAgent::buildAsyncStackTrace): Deleted.
+        (Inspector::InspectorDebuggerAgent::refAsyncCallData): Deleted.
+        (Inspector::InspectorDebuggerAgent::derefAsyncCallData): Deleted.
+        * inspector/agents/InspectorDebuggerAgent.h:
+        * inspector/protocol/Console.json:
+
 2017-01-30  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -1377 +1377 @@
                 65FB5117184EEE7000C12B70 /* ProtoCallFrame.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 65FB5116184EE9BC00C12B70 /* ProtoCallFrame.cpp */; };
                 65FB63A41C8EA09C0020719B /* YarrCanonicalizeUnicode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 65A946141C8E9F6F00A7209A /* YarrCanonicalizeUnicode.cpp */; };
+                6A38CFA91E32B5AB0060206F /* AsyncStackTrace.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 6A38CFA71E32B58B0060206F /* AsyncStackTrace.cpp */; };
+                6A38CFAA1E32B5AB0060206F /* AsyncStackTrace.h in Headers */ = {isa = PBXBuildFile; fileRef = 6A38CFA81E32B58B0060206F /* AsyncStackTrace.h */; };
                 6AD2CB4D19B9140100065719 /* DebuggerEvalEnabler.h in Headers */ = {isa = PBXBuildFile; fileRef = 6AD2CB4C19B9140100065719 /* DebuggerEvalEnabler.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 70113D4B1A8DB093003848C4 /* IteratorOperations.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 70113D491A8DB093003848C4 /* IteratorOperations.cpp */; };
@@ -3840 +3842 @@
                 65FB5115184EE8F800C12B70 /* ProtoCallFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ProtoCallFrame.h; sourceTree = "<group>"; };
                 65FB5116184EE9BC00C12B70 /* ProtoCallFrame.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ProtoCallFrame.cpp; sourceTree = "<group>"; };
+                6A38CFA71E32B58B0060206F /* AsyncStackTrace.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AsyncStackTrace.cpp; sourceTree = "<group>"; };
+                6A38CFA81E32B58B0060206F /* AsyncStackTrace.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AsyncStackTrace.h; sourceTree = "<group>"; };
                 6AD2CB4C19B9140100065719 /* DebuggerEvalEnabler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DebuggerEvalEnabler.h; sourceTree = "<group>"; };
                 6BA93C9590484C5BAD9316EA /* JSScriptFetcher.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSScriptFetcher.h; sourceTree = "<group>"; };
@@ -5030 +5034 @@
                                 0F9327591C20BCBA00CF6564 /* dynbench */,
                                 0FF922CF14F46B130041A24E /* JSCLLIntOffsetsExtractor */,
+                                141211200A48793C00480255 /* minidom */,
                                 0F6183431C45F62A0072450B /* testair */,
+                                14BD59BF0A3E8F9000BAF59C /* testapi */,
+                                0FEC85AD1BDB5CF10080FF74 /* testb3 */,
                                 6511230514046A4C002B101D /* testRegExp */,
                                 932F5BD90822A1C700736975 /* JavaScriptCore.framework */,
                                 932F5BE10822A1C700736975 /* jsc */,
-                                141211200A48793C00480255 /* minidom */,
-                                14BD59BF0A3E8F9000BAF59C /* testapi */,
-                                0FEC85AD1BDB5CF10080FF74 /* testb3 */,
                         );
                         name = Products;
@@ -5257 +5261 @@
                                 0FEC84C11BDACDAC0080FF74 /* B3Commutativity.cpp */,
                                 0FEC84C21BDACDAC0080FF74 /* B3Commutativity.h */,
-                                7919B77F1E03559C005BEED8 /* B3Compile.h */,
-                                795F099C1E03600500BBE37F /* B3Compile.cpp */,
                                 0F338DFF1BF0276C0013C88F /* B3Compilation.cpp */,
                                 0F338E001BF0276C0013C88F /* B3Compilation.h */,
+                                795F099C1E03600500BBE37F /* B3Compile.cpp */,
+                                7919B77F1E03559C005BEED8 /* B3Compile.h */,
                                 0F86AE1F1C5311C5006BE8EC /* B3ComputeDivisionMagic.h */,
                                 0FEC84C31BDACDAC0080FF74 /* B3Const32Value.cpp */,
@@ -6366 +6370 @@
                                 E35E035D1B7AB43E0073AD2A /* InspectorInstrumentationObject.cpp */,
                                 E35E035E1B7AB43E0073AD2A /* InspectorInstrumentationObject.h */,
-                                A7A8AF2B17ADB5F3005AB174 /* Int8Array.h */,
                                 A7A8AF2C17ADB5F3005AB174 /* Int16Array.h */,
                                 A7A8AF2D17ADB5F3005AB174 /* Int32Array.h */,
+                                A7A8AF2B17ADB5F3005AB174 /* Int8Array.h */,
                                 BC9BB95B0E19680600DF8855 /* InternalFunction.cpp */,
                                 BC11667A0E199C05008066DD /* InternalFunction.h */,
@@ -6463 +6467 @@
                                 BC756FC70E2031B200DE7D12 /* JSGlobalObjectFunctions.h */,
                                 79B819921DD25CF500DDC714 /* JSGlobalObjectInlines.h */,
-                                0F2B66C917B6B5AB00A7AE3F /* JSInt8Array.h */,
                                 0F2B66CA17B6B5AB00A7AE3F /* JSInt16Array.h */,
                                 0F2B66CB17B6B5AB00A7AE3F /* JSInt32Array.h */,
+                                0F2B66C917B6B5AB00A7AE3F /* JSInt8Array.h */,
                                 E33F507E1B8429A400413856 /* JSInternalPromise.cpp */,
                                 E33F507F1B8429A400413856 /* JSInternalPromise.h */,
@@ -6553 +6557 @@
                                 53917E7C1B791106000EBD33 /* JSTypedArrayViewPrototype.h */,
                                 6507D2970E871E4A00D7D896 /* JSTypeInfo.h */,
+                                0F2B66D417B6B5AB00A7AE3F /* JSUint16Array.h */,
+                                0F2B66D517B6B5AB00A7AE3F /* JSUint32Array.h */,
                                 0F2B66D217B6B5AB00A7AE3F /* JSUint8Array.h */,
                                 0F2B66D317B6B5AB00A7AE3F /* JSUint8ClampedArray.h */,
-                                0F2B66D417B6B5AB00A7AE3F /* JSUint16Array.h */,
-                                0F2B66D517B6B5AB00A7AE3F /* JSUint32Array.h */,
                                 A7CA3AE117DA41AE006538AF /* JSWeakMap.cpp */,
                                 A7CA3AE217DA41AE006538AF /* JSWeakMap.h */,
@@ -6763 +6767 @@
                                 0F2D4DE319832D91007D4B19 /* TypeSet.cpp */,
                                 0F2D4DE419832D91007D4B19 /* TypeSet.h */,
-                                A7A8AF3017ADB5F3005AB174 /* Uint8Array.h */,
-                                A7A8AF3117ADB5F3005AB174 /* Uint8ClampedArray.h */,
                                 A7A8AF3217ADB5F3005AB174 /* Uint16Array.h */,
                                 866739D113BFDE710023D87C /* Uint16WithFraction.h */,
                                 A7A8AF3317ADB5F3005AB174 /* Uint32Array.h */,
+                                A7A8AF3017ADB5F3005AB174 /* Uint8Array.h */,
+                                A7A8AF3117ADB5F3005AB174 /* Uint8ClampedArray.h */,
                                 0FE050231AA9095600D33B33 /* VarOffset.cpp */,
                                 0FE050241AA9095600D33B33 /* VarOffset.h */,
@@ -7554 +7558 @@
                                 A5BA15E01823409D00A82E69 /* remote */,
                                 A532438E185696CE002ED692 /* scripts */,
+                                6A38CFA71E32B58B0060206F /* AsyncStackTrace.cpp */,
+                                6A38CFA81E32B58B0060206F /* AsyncStackTrace.h */,
                                 A5FD0077189B051000633231 /* ConsoleMessage.cpp */,
                                 A5FD0078189B051000633231 /* ConsoleMessage.h */,
@@ -7909 +7915 @@
                                 5B70CFE21DB69E6600EC23F9 /* AsyncFunctionConstructor.h in Headers */,
                                 5B70CFE01DB69E6600EC23F9 /* AsyncFunctionPrototype.h in Headers */,
+                                6A38CFAA1E32B5AB0060206F /* AsyncStackTrace.h in Headers */,
                                 0F7CF9571DC125900098CC12 /* AtomicsObject.h in Headers */,
                                 A5EA70E719F5B1010098F5EC /* AugmentableInspectorController.h in Headers */,
@@ -7931 +7938 @@
                                 0FEC850C1BDACDAC0080FF74 /* B3Commutativity.h in Headers */,
                                 0F338E0C1BF0276C0013C88F /* B3Compilation.h in Headers */,
+                                7919B7801E03559C005BEED8 /* B3Compile.h in Headers */,
                                 0F86AE201C5311C5006BE8EC /* B3ComputeDivisionMagic.h in Headers */,
                                 0FEC850E1BDACDAC0080FF74 /* B3Const32Value.h in Headers */,
@@ -8030 +8038 @@
                                 C2FCAE1117A9C24E0034C735 /* BytecodeBasicBlock.h in Headers */,
                                 0F21C27F14BEAA8200ADC64B /* BytecodeConventions.h in Headers */,
-                                0F1FB3931E177A7200A9BE50 /* VisitingTimeout.h in Headers */,
                                 969A07230ED1CE3300F1F681 /* BytecodeGenerator.h in Headers */,
                                 E328DAE81D38D005001A2529 /* BytecodeGeneratorification.h in Headers */,
@@ -8056 +8063 @@
                                 0F24E54217EA9F5900ABB217 /* CCallHelpers.h in Headers */,
                                 0F070A471D543A8B006E7232 /* CellContainer.h in Headers */,
-                                ADE8029A1E08F1DE0058DE78 /* WebAssemblyLinkErrorConstructor.h in Headers */,
                                 0F070A481D543A90006E7232 /* CellContainerInlines.h in Headers */,
                                 0F1C3DDA1BBCE09E00E523E4 /* CellState.h in Headers */,
@@ -8094 +8100 @@
                                 A5FD0074189B038C00633231 /* ConsoleTypes.h in Headers */,
                                 0FFC99D1184EC8AD009C10AB /* ConstantMode.h in Headers */,
+                                0F7DF1341E2970D70095951B /* ConstraintVolatility.h in Headers */,
                                 E354622B1B6065D100545386 /* ConstructAbility.h in Headers */,
                                 BC18C3F60E16F5CD00B34460 /* ConstructData.h in Headers */,
@@ -8115 +8122 @@
                                 BC18C3FA0E16F5CD00B34460 /* Debugger.h in Headers */,
                                 BC18C3FB0E16F5CD00B34460 /* DebuggerCallFrame.h in Headers */,
-                                0F7DF1351E2970DC0095951B /* MarkedSpaceInlines.h in Headers */,
                                 6AD2CB4D19B9140100065719 /* DebuggerEvalEnabler.h in Headers */,
                                 A5FC84B21D1DDAD6006B5C46 /* DebuggerLocation.h in Headers */,
@@ -8140 +8146 @@
                                 0F485322187750560083B687 /* DFGArithMode.h in Headers */,
                                 0F05C3B41683CF9200BAF45B /* DFGArrayifySlowPathGenerator.h in Headers */,
-                                0F4F82881E2FFDE00075184C /* JSSegmentedVariableObjectSubspace.h in Headers */,
                                 0F63948515E4811B006A597C /* DFGArrayMode.h in Headers */,
                                 A7D9A29517A0BC7400EE2618 /* DFGAtTailAbstractState.h in Headers */,
@@ -8165 +8170 @@
                                 0F9D36951AE9CC33000D4DFB /* DFGCleanUpPhase.h in Headers */,
                                 A77A424017A0BBFD00A8DB81 /* DFGClobberize.h in Headers */,
-                                AD7438C01E0457A400FD0C2A /* WasmSignature.h in Headers */,
                                 A77A424217A0BBFD00A8DB81 /* DFGClobberSet.h in Headers */,
                                 0F3C1F1B1B868E7900ABB08B /* DFGClobbersExitState.h in Headers */,
@@ -8205 +8209 @@
                                 A7D89CF817A0B8CC00773AD8 /* DFGFlushFormat.h in Headers */,
                                 0F2DD8151AB3D8BE00BBB8E8 /* DFGForAllKills.h in Headers */,
-                                0F4F828C1E31B9760075184C /* StochasticSpaceTimeMutatorScheduler.h in Headers */,
                                 0F69CC89193AC60A0045759E /* DFGFrozenValue.h in Headers */,
                                 86EC9DC61328DF82002B2AD7 /* DFGGenerationInfo.h in Headers */,
@@ -8259 +8262 @@
                                 0F7025AA1714B0FC00382C0E /* DFGOSRExitCompilerCommon.h in Headers */,
                                 0F392C8A1B46188400844728 /* DFGOSRExitFuzz.h in Headers */,
-                                0F7DF13F1E2AFC4D0095951B /* JSStringSubspace.h in Headers */,
                                 0FEFC9AB1681A3B600567F53 /* DFGOSRExitJumpPlaceholder.h in Headers */,
                                 0F235BEE17178E7300690C7F /* DFGOSRExitPreparation.h in Headers */,
@@ -8266 +8268 @@
                                 0F2B9CEB19D0BA7D00B1D1B5 /* DFGPhiChildren.h in Headers */,
                                 A78A977B179738B8009DF744 /* DFGPlan.h in Headers */,
+                                0F1FB3961E1AF7E100A9BE50 /* DFGPlanInlines.h in Headers */,
                                 DC00039319D8BE6F00023EB0 /* DFGPreciseLocalClobberize.h in Headers */,
                                 0FBE0F7516C1DB0B0082C5E8 /* DFGPredictionInjectionPhase.h in Headers */,
@@ -8296 +8299 @@
                                 0FC097A2146B28CC00CF2442 /* DFGThunks.h in Headers */,
                                 0FD8A32817D51F5700CA2C40 /* DFGTierUpCheckInjectionPhase.h in Headers */,
+                                ADFF2F701E319DE3001EA54E /* DFGTierUpEntryTrigger.h in Headers */,
                                 0FD8A32A17D51F5700CA2C40 /* DFGToFTLDeferredCompilationCallback.h in Headers */,
                                 0FD8A32C17D51F5700CA2C40 /* DFGToFTLForOSREntryDeferredCompilationCallback.h in Headers */,
@@ -8313 +8317 @@
                                 0FC97F4218202119002C9B26 /* DFGWatchpointCollectionPhase.h in Headers */,
                                 0FDB2CE8174830A2007B3C1B /* DFGWorklist.h in Headers */,
+                                0F1FB3971E1AF7E300A9BE50 /* DFGWorklistInlines.h in Headers */,
                                 0FE050181AA9091100D33B33 /* DirectArguments.h in Headers */,
                                 0FE050161AA9091100D33B33 /* DirectArgumentsOffset.h in Headers */,
@@ -8419 +8424 @@
                                 FE4BFF2C1AD476E700088F87 /* FunctionOverrides.h in Headers */,
                                 BC18C4050E16F5CD00B34460 /* FunctionPrototype.h in Headers */,
-                                7919B7801E03559C005BEED8 /* B3Compile.h in Headers */,
                                 62D2D3901ADF103F000206C1 /* FunctionRareData.h in Headers */,
                                 FEA0C4031CDD7D1D00481991 /* FunctionWhitelist.h in Headers */,
@@ -8435 +8439 @@
                                 A54E8EB118BFFBBE00556D28 /* GCSegmentedArrayInlines.h in Headers */,
                                 0F86A26F1D6F7B3300CB0C92 /* GCTypeMap.h in Headers */,
-                                0F7DF1381E2970E40095951B /* SubspaceInlines.h in Headers */,
                                 9959E9311BD18272001AA413 /* generate-combined-inspector-json.py in Headers */,
                                 C4703CC0192844960013FBEA /* generate-inspector-protocol-bindings.py in Headers */,
-                                0F7DF1461E2BEF6A0095951B /* MarkedAllocatorInlines.h in Headers */,
                                 99DA00AF1BD5994E00F4575C /* generate-js-builtins.py in Headers */,
                                 A5EA70EC19F5B3EA0098F5EC /* generate_cpp_alternate_backend_dispatcher_header.py in Headers */,
@@ -8473 +8475 @@
                                 7964656A1B952FF0003059EE /* GetPutInfo.h in Headers */,
                                 14AD910E1DCA92940014F9FE /* GlobalCodeBlock.h in Headers */,
-                                79DAE27A1E03C82200B526AA /* WasmExceptionType.h in Headers */,
                                 0F24E54417EA9F5900ABB217 /* GPRInfo.h in Headers */,
                                 142E3134134FF0A600AFADB5 /* Handle.h in Headers */,
@@ -8540 +8541 @@
                                 E35E03601B7AB43E0073AD2A /* InspectorInstrumentationObject.h in Headers */,
                                 E33B3E261B7ABD750048DB2E /* InspectorInstrumentationObject.lut.h in Headers */,
-                                ADE802991E08F1DE0058DE78 /* JSWebAssemblyLinkError.h in Headers */,
                                 A532438C18568335002ED692 /* InspectorProtocolObjects.h in Headers */,
                                 A55D93AC18514F7900400DED /* InspectorProtocolTypes.h in Headers */,
@@ -8570 +8570 @@
                                 A125846F1B45A36000CC7F6C /* IntlNumberFormatPrototype.lut.h in Headers */,
                                 A12BBFF21B044A8B00664B69 /* IntlObject.h in Headers */,
-                                0F1FB3971E1AF7E300A9BE50 /* DFGWorklistInlines.h in Headers */,
                                 708EBE241CE8F35800453146 /* IntlObjectInlines.h in Headers */,
                                 860BD801148EA6F200112B2F /* Intrinsic.h in Headers */,
@@ -8601 +8600 @@
                                 FE99B2491C24C3D300C82159 /* JITNegGenerator.h in Headers */,
                                 0F24E54D17EE274900ABB217 /* JITOperations.h in Headers */,
-                                0F7DF1371E2970E10095951B /* Subspace.h in Headers */,
                                 FE3A06C01C11041A00390FDD /* JITRightShiftGenerator.h in Headers */,
                                 0F766D3115AA8112008F363E /* JITStubRoutine.h in Headers */,
@@ -8647 +8645 @@
                                 978801411471AD920041B016 /* JSDateMath.h in Headers */,
                                 C2A7F688160432D400F76B98 /* JSDestructibleObject.h in Headers */,
+                                0F7DF13C1E2971130095951B /* JSDestructibleObjectSubspace.h in Headers */,
                                 FE384EE61ADDB7AD0055DE2C /* JSDollarVM.h in Headers */,
                                 FE384EE81ADDB7AD0055DE2C /* JSDollarVMPrototype.h in Headers */,
@@ -8656 +8655 @@
                                 0F2B66F017B6B5AB00A7AE3F /* JSFloat64Array.h in Headers */,
                                 BC18C41F0E16F5CD00B34460 /* JSFunction.h in Headers */,
-                                0F660E3A1E0517C10031462C /* MarkingConstraintSet.h in Headers */,
                                 A72028BA1797603D0098028C /* JSFunctionInlines.h in Headers */,
-                                0F660E381E0517BB0031462C /* MarkingConstraint.h in Headers */,
                                 70B7919C1C024A49002481E2 /* JSGeneratorFunction.h in Headers */,
                                 0F2B66F117B6B5AB00A7AE3F /* JSGenericTypedArrayView.h in Headers */,
@@ -8719 +8716 @@
                                 996B731F1BDA08EF00331B84 /* JSPromisePrototype.lut.h in Headers */,
                                 2A05ABD61961DF2400341750 /* JSPropertyNameEnumerator.h in Headers */,
-                                0F7DF13C1E2971130095951B /* JSDestructibleObjectSubspace.h in Headers */,
                                 E3EF88751B66DF23003F26CB /* JSPropertyNameIterator.h in Headers */,
                                 862553D216136E1A009F17D0 /* JSProxy.h in Headers */,
@@ -8726 +8722 @@
                                 BC18C4260E16F5CD00B34460 /* JSRetainPtr.h in Headers */,
                                 14874AE615EBDE4A002E3587 /* JSScope.h in Headers */,
+                                9064337DD4B0402BAF34A592 /* JSScriptFetcher.h in Headers */,
                                 A7C0C4AC168103020017011D /* JSScriptRefPrivate.h in Headers */,
                                 0F919D11157F332C004A4E7D /* JSSegmentedVariableObject.h in Headers */,
+                                0F4F82881E2FFDE00075184C /* JSSegmentedVariableObjectSubspace.h in Headers */,
                                 A7299D9E17D12837005F5FF9 /* JSSet.h in Headers */,
-                                0F7DF1341E2970D70095951B /* ConstraintVolatility.h in Headers */,
                                 A790DD70182F499700588807 /* JSSetIterator.h in Headers */,
+                                BDFCB2BBE90F41349E1B0BED /* JSSourceCode.h in Headers */,
                                 BC18C4270E16F5CD00B34460 /* JSString.h in Headers */,
                                 86E85539111B9968001AF51E /* JSStringBuilder.h in Headers */,
@@ -8739 +8737 @@
                                 BC18C4290E16F5CD00B34460 /* JSStringRefCF.h in Headers */,
                                 1A28D4A8177B71C80007FA3C /* JSStringRefPrivate.h in Headers */,
+                                0F7DF13F1E2AFC4D0095951B /* JSStringSubspace.h in Headers */,
                                 0F919D0D157EE0A2004A4E7D /* JSSymbolTableObject.h in Headers */,
                                 70ECA6061AFDBEA200449739 /* JSTemplateRegistryKey.h in Headers */,
@@ -8767 +8766 @@
                                 796FB43A1DFF8C3F0039C95D /* JSWebAssemblyHelpers.h in Headers */,
                                 AD2FCBE51DB58DAD00B3E736 /* JSWebAssemblyInstance.h in Headers */,
+                                ADE802991E08F1DE0058DE78 /* JSWebAssemblyLinkError.h in Headers */,
                                 AD2FCBE71DB58DAD00B3E736 /* JSWebAssemblyMemory.h in Headers */,
                                 AD2FCC051DB58DAD00B3E736 /* JSWebAssemblyModule.h in Headers */,
@@ -8773 +8773 @@
                                 1442566215EDE98D0066A49B /* JSWithScope.h in Headers */,
                                 86E3C619167BABEE006D760A /* JSWrapperMap.h in Headers */,
-                                0F1FB38F1E173A6700A9BE50 /* SynchronousStopTheWorldMutatorScheduler.h in Headers */,
                                 BC18C42E0E16F5CD00B34460 /* JSWrapperObject.h in Headers */,
                                 BCFD8C930EEB2EE700283848 /* JumpTable.h in Headers */,
@@ -8819 +8818 @@
                                 E32AB2441DCD75F400D7533A /* MacroAssemblerHelpers.h in Headers */,
                                 86C568E111A213EE0007F7F0 /* MacroAssemblerMIPS.h in Headers */,
-                                0F1FB3961E1AF7E100A9BE50 /* DFGPlanInlines.h in Headers */,
                                 FE68C6371B90DE040042BCB3 /* MacroAssemblerPrinter.h in Headers */,
                                 860161E40F3A83C100F84710 /* MacroAssemblerX86.h in Headers */,
@@ -8829 +8827 @@
                                 A700873E17CBE8D300C3E643 /* MapPrototype.h in Headers */,
                                 C2B916C214DA014E00CBAC86 /* MarkedAllocator.h in Headers */,
+                                0F7DF1461E2BEF6A0095951B /* MarkedAllocatorInlines.h in Headers */,
                                 142D6F0913539A2800B02E86 /* MarkedBlock.h in Headers */,
                                 0F7C5FB81D888A0C0044F5E2 /* MarkedBlockInlines.h in Headers */,
                                 141448CB13A176EC00F5BA1A /* MarkedBlockSet.h in Headers */,
                                 14D2F3DB139F4BE200491031 /* MarkedSpace.h in Headers */,
+                                0F7DF1351E2970DC0095951B /* MarkedSpaceInlines.h in Headers */,
+                                0F660E381E0517BB0031462C /* MarkingConstraint.h in Headers */,
+                                0F660E3A1E0517C10031462C /* MarkingConstraintSet.h in Headers */,
                                 142D6F1213539A4100B02E86 /* MarkStack.h in Headers */,
                                 8612E4CD152389EC00C836BE /* MatchResult.h in Headers */,
@@ -8840 +8842 @@
                                 90213E3E123A40C200D422F3 /* MemoryStatistics.h in Headers */,
                                 0FB5467B14F5C7E1002C2989 /* MethodOfGettingAValueProfile.h in Headers */,
-                                ADE8029C1E08F1DE0058DE78 /* WebAssemblyLinkErrorPrototype.h in Headers */,
                                 7C008CE7187631B600955C24 /* Microtask.h in Headers */,
                                 86C568E211A213EE0007F7F0 /* MIPSAssembler.h in Headers */,
@@ -8850 +8851 @@
                                 147341D61DC02EB900AA29BA /* ModuleProgramExecutable.h in Headers */,
                                 A79D3ED9C5064DD0A8466A3A /* ModuleScopeData.h in Headers */,
+                                0F1FB3991E1F65FB00A9BE50 /* MutatorScheduler.h in Headers */,
                                 0FA762071DB9243300B7A2FD /* MutatorState.h in Headers */,
                                 BC02E9110E1839DB000F9297 /* NativeErrorConstructor.h in Headers */,
@@ -8979 +8981 @@
                                 A503FA26188EFFFD00110F14 /* ScriptDebugServer.h in Headers */,
                                 147341CE1DC02D7900AA29BA /* ScriptExecutable.h in Headers */,
+                                CEAE7D7B889B477BA93ABA6C /* ScriptFetcher.h in Headers */,
                                 A55D93A6185012A800400DED /* ScriptFunctionCall.h in Headers */,
                                 A54CF2FA184EAEDA00237F19 /* ScriptObject.h in Headers */,
@@ -8998 +9001 @@
                                 14201D591DECF26A00904BD3 /* SourceCode.h in Headers */,
                                 70B791911C024A13002481E2 /* SourceCodeKey.h in Headers */,
+                                2D342F36F7244096804ADB24 /* SourceOrigin.h in Headers */,
                                 BC18C4630E16F5CD00B34460 /* SourceProvider.h in Headers */,
                                 E49DC16C12EF294E00184A1F /* SourceProviderCache.h in Headers */,
@@ -9012 +9016 @@
                                 14DF04DA16B3996D0016A513 /* StaticPropertyAnalysis.h in Headers */,
                                 14CA958B16AB50DE00938A06 /* StaticPropertyAnalyzer.h in Headers */,
+                                0F4F828C1E31B9760075184C /* StochasticSpaceTimeMutatorScheduler.h in Headers */,
                                 0F7CF9521DC027D90098CC12 /* StopIfNecessaryTimer.h in Headers */,
                                 A730B6121250068F009D25B1 /* StrictEvalActivation.h in Headers */,
@@ -9033 +9038 @@
                                 BCCF0D080EF0AAB900413C8F /* StructureStubInfo.h in Headers */,
                                 BC9041480EB9250900FE26FA /* StructureTransitionTable.h in Headers */,
+                                0F7DF1371E2970E10095951B /* Subspace.h in Headers */,
+                                0F7DF1381E2970E40095951B /* SubspaceInlines.h in Headers */,
                                 0F4A38FA1C8E13DF00190318 /* SuperSampler.h in Headers */,
-                                0F1FB3991E1F65FB00A9BE50 /* MutatorScheduler.h in Headers */,
                                 705B41AC1A6E501E00716757 /* Symbol.h in Headers */,
                                 705B41AE1A6E501E00716757 /* SymbolConstructor.h in Headers */,
@@ -9042 +9048 @@
                                 996B73281BDA08EF00331B84 /* SymbolPrototype.lut.h in Headers */,
                                 BC18C46B0E16F5CD00B34460 /* SymbolTable.h in Headers */,
+                                0F1FB38F1E173A6700A9BE50 /* SynchronousStopTheWorldMutatorScheduler.h in Headers */,
                                 A784A26411D16622005776AC /* SyntaxChecker.h in Headers */,
                                 DC7997831CDE9FA0004D4A09 /* TagRegistersMode.h in Headers */,
@@ -9097 +9104 @@
                                 0FE0502D1AA9095600D33B33 /* VarOffset.h in Headers */,
                                 0F426A491460CBB700131F8F /* VirtualRegister.h in Headers */,
+                                0F1FB3931E177A7200A9BE50 /* VisitingTimeout.h in Headers */,
                                 0F952AA11DF7860900E06FBD /* VisitRaceKey.h in Headers */,
                                 BC18C4200E16F5CD00B34460 /* VM.h in Headers */,
@@ -9105 +9113 @@
                                 AD4B1DFA1DF244E20071AE32 /* WasmBinding.h in Headers */,
                                 53FD04D41D7AB291003287D3 /* WasmCallingConvention.h in Headers */,
+                                79DAE27A1E03C82200B526AA /* WasmExceptionType.h in Headers */,
                                 7BC547D31B6959A100959B58 /* WasmFormat.h in Headers */,
                                 53F40E8B1D5901BB0099A1B6 /* WasmFunctionParser.h in Headers */,
@@ -9115 +9124 @@
                                 531374BD1D5CE67600AF7A0B /* WasmPlan.h in Headers */,
                                 53F40E851D58F9770099A1B6 /* WasmSections.h in Headers */,
+                                AD7438C01E0457A400FD0C2A /* WasmSignature.h in Headers */,
                                 53FF7F991DBFCD9000A26CCC /* WasmValidate.h in Headers */,
                                 FED94F2F171E3E2300BE77A4 /* Watchdog.h in Headers */,
@@ -9142 +9152 @@
                                 AD2FCBF31DB58DAD00B3E736 /* WebAssemblyInstancePrototype.h in Headers */,
                                 AD2FCC191DB59CB200B3E736 /* WebAssemblyInstancePrototype.lut.h in Headers */,
+                                ADE8029A1E08F1DE0058DE78 /* WebAssemblyLinkErrorConstructor.h in Headers */,
+                                ADE8029C1E08F1DE0058DE78 /* WebAssemblyLinkErrorPrototype.h in Headers */,
                                 AD2FCBF51DB58DAD00B3E736 /* WebAssemblyMemoryConstructor.h in Headers */,
                                 AD2FCC1A1DB59CB200B3E736 /* WebAssemblyMemoryConstructor.lut.h in Headers */,
@@ -9173 +9185 @@
                                 86704B8A12DBA33700A9FE7B /* YarrPattern.h in Headers */,
                                 86704B4312DB8A8100A9FE7B /* YarrSyntaxChecker.h in Headers */,
-                                2D342F36F7244096804ADB24 /* SourceOrigin.h in Headers */,
-                                BDFCB2BBE90F41349E1B0BED /* JSSourceCode.h in Headers */,
-                                9064337DD4B0402BAF34A592 /* JSScriptFetcher.h in Headers */,
-                                CEAE7D7B889B477BA93ABA6C /* ScriptFetcher.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;
@@ -9728 +9736 @@
                                 5B70CFE31DB69E6600EC23F9 /* AsyncFunctionConstructor.cpp in Sources */,
                                 5B70CFE11DB69E6600EC23F9 /* AsyncFunctionPrototype.cpp in Sources */,
+                                6A38CFA91E32B5AB0060206F /* AsyncStackTrace.cpp in Sources */,
                                 0F7CF9561DC1258D0098CC12 /* AtomicsObject.cpp in Sources */,
                                 0FEC84FE1BDACDAC0080FF74 /* B3ArgumentRegValue.cpp in Sources */,
@@ -9740 +9749 @@
                                 0FEC850B1BDACDAC0080FF74 /* B3Commutativity.cpp in Sources */,
                                 0F338E0B1BF0276C0013C88F /* B3Compilation.cpp in Sources */,
+                                795F099D1E03600500BBE37F /* B3Compile.cpp in Sources */,
                                 0FEC850D1BDACDAC0080FF74 /* B3Const32Value.cpp in Sources */,
                                 0FEC850F1BDACDAC0080FF74 /* B3Const64Value.cpp in Sources */,
@@ -9801 +9811 @@
                                 14280863107EC11A0013E7B2 /* BooleanConstructor.cpp in Sources */,
                                 14280864107EC11A0013E7B2 /* BooleanObject.cpp in Sources */,
-                                0F4F82871E2FFDDD0075184C /* JSSegmentedVariableObjectSubspace.cpp in Sources */,
-                                ADB6F67D1E15D7600082F384 /* WasmPageCount.cpp in Sources */,
                                 14280865107EC11A0013E7B2 /* BooleanPrototype.cpp in Sources */,
                                 DE26E9071CB5DEFB00D2BE82 /* BuiltinExecutableCreator.cpp in Sources */,
@@ -9847 +9855 @@
                                 147F39C2107EC37600427A48 /* Completion.cpp in Sources */,
                                 0F6FC750196110A800E1D02D /* ComplexGetStatus.cpp in Sources */,
-                                0F1FB38E1E173A6500A9BE50 /* SynchronousStopTheWorldMutatorScheduler.cpp in Sources */,
                                 146B16D812EB5B59001BEC1B /* ConservativeRoots.cpp in Sources */,
                                 A5B6A74D18C6DBA600F11E91 /* ConsoleClient.cpp in Sources */,
@@ -9863 +9870 @@
                                 147F39C5107EC37600427A48 /* DateInstance.cpp in Sources */,
                                 147F39C6107EC37600427A48 /* DatePrototype.cpp in Sources */,
-                                0F660E391E0517BF0031462C /* MarkingConstraintSet.cpp in Sources */,
                                 14280823107EC02C0013E7B2 /* Debugger.cpp in Sources */,
                                 149559EE0DDCDDF700648087 /* DebuggerCallFrame.cpp in Sources */,
@@ -9945 +9951 @@
                                 0FF0F19916B729F6005DF95B /* DFGLongLivedState.cpp in Sources */,
                                 A767B5B517A0B9650063D940 /* DFGLoopPreHeaderCreationPhase.cpp in Sources */,
-                                ADE8029E1E08F2280058DE78 /* WebAssemblyLinkErrorConstructor.cpp in Sources */,
                                 79F8FC1E1B9FED0F00CA66AB /* DFGMaximalFlushInsertionPhase.cpp in Sources */,
                                 0F5874ED194FEB1200AAB2C1 /* DFGMayExit.cpp in Sources */,
@@ -9984 +9989 @@
                                 0F3A1BF91A9ECB7D000DE01A /* DFGPutStackSinkingPhase.cpp in Sources */,
                                 0F2FCCFB18A60070001A27F8 /* DFGSafepoint.cpp in Sources */,
-                                795F099D1E03600500BBE37F /* B3Compile.cpp in Sources */,
                                 86EC9DD21328DF82002B2AD7 /* DFGSpeculativeJIT.cpp in Sources */,
                                 86880F1F14328BB900B08D42 /* DFGSpeculativeJIT32_64.cpp in Sources */,
@@ -9996 +10000 @@
                                 0F9E32631B05AB0400801ED5 /* DFGStoreBarrierInsertionPhase.cpp in Sources */,
                                 0FC20CB51852E2C600C9E954 /* DFGStrengthReductionPhase.cpp in Sources */,
-                                0F7DF13B1E2971110095951B /* JSDestructibleObjectSubspace.cpp in Sources */,
                                 0F893BDB1936E23C001211F4 /* DFGStructureAbstractValue.cpp in Sources */,
                                 0F2FCCFE18A60070001A27F8 /* DFGThreadData.cpp in Sources */,
                                 0FC097A1146B28CA00CF2442 /* DFGThunks.cpp in Sources */,
                                 0FD8A32717D51F5700CA2C40 /* DFGTierUpCheckInjectionPhase.cpp in Sources */,
-                                0F4F828B1E31B9740075184C /* StochasticSpaceTimeMutatorScheduler.cpp in Sources */,
                                 0FD8A32917D51F5700CA2C40 /* DFGToFTLDeferredCompilationCallback.cpp in Sources */,
                                 0FD8A32B17D51F5700CA2C40 /* DFGToFTLForOSREntryDeferredCompilationCallback.cpp in Sources */,
@@ -10208 +10210 @@
                                 1421359B0A677F4F00A8195E /* JSBase.cpp in Sources */,
                                 86FA9E91142BBB2E001773B7 /* JSBoundFunction.cpp in Sources */,
-                                0F7DF1401E2AFC500095951B /* JSStringSubspace.cpp in Sources */,
                                 1440F8AF0A508D200005F061 /* JSCallbackConstructor.cpp in Sources */,
                                 1440F8920A508B100005F061 /* JSCallbackFunction.cpp in Sources */,
@@ -10224 +10225 @@
                                 0F2B66ED17B6B5AB00A7AE3F /* JSDataViewPrototype.cpp in Sources */,
                                 978801401471AD920041B016 /* JSDateMath.cpp in Sources */,
+                                0F7DF13B1E2971110095951B /* JSDestructibleObjectSubspace.cpp in Sources */,
                                 FE384EE51ADDB7AD0055DE2C /* JSDollarVM.cpp in Sources */,
                                 FE384EE71ADDB7AD0055DE2C /* JSDollarVMPrototype.cpp in Sources */,
@@ -10236 +10238 @@
                                 A59455921824744700CC3843 /* JSGlobalObjectDebuggable.cpp in Sources */,
                                 A57D23E91891B0770031C7FA /* JSGlobalObjectDebuggerAgent.cpp in Sources */,
-                                0F7DF1361E2970DF0095951B /* Subspace.cpp in Sources */,
-                                ADE8029B1E08F1DE0058DE78 /* WebAssemblyLinkErrorPrototype.cpp in Sources */,
                                 14E9D17B107EC469004DDA21 /* JSGlobalObjectFunctions.cpp in Sources */,
                                 A51007C0187CC3C600B38879 /* JSGlobalObjectInspectorController.cpp in Sources */,
@@ -10274 +10274 @@
                                 9928FF3B18AC4AEC00B8CF12 /* JSReplayInputs.cpp in Sources */,
                                 14874AE515EBDE4A002E3587 /* JSScope.cpp in Sources */,
+                                14815F5F991C46BEB98D0016 /* JSScriptFetcher.cpp in Sources */,
                                 A7C0C4AD1681067E0017011D /* JSScriptRef.cpp in Sources */,
                                 0F919D10157F3329004A4E7D /* JSSegmentedVariableObject.cpp in Sources */,
+                                0F4F82871E2FFDDD0075184C /* JSSegmentedVariableObjectSubspace.cpp in Sources */,
                                 A7299D9D17D12837005F5FF9 /* JSSet.cpp in Sources */,
                                 A790DD6F182F499700588807 /* JSSetIterator.cpp in Sources */,
+                                FA3AB211C8494524AB390267 /* JSSourceCode.cpp in Sources */,
                                 147F39D5107EC37600427A48 /* JSString.cpp in Sources */,
                                 70EC0EC21AA0D7DA00B6AAFA /* JSStringIterator.cpp in Sources */,
@@ -10283 +10286 @@
                                 1482B74E0A43032800517CFC /* JSStringRef.cpp in Sources */,
                                 146AAB380B66A94400E55F16 /* JSStringRefCF.cpp in Sources */,
+                                0F7DF1401E2AFC500095951B /* JSStringSubspace.cpp in Sources */,
                                 0F919D0C157EE09F004A4E7D /* JSSymbolTableObject.cpp in Sources */,
                                 70ECA6051AFDBEA200449739 /* JSTemplateRegistryKey.cpp in Sources */,
@@ -10341 +10345 @@
                                 142D6F0813539A2800B02E86 /* MarkedBlock.cpp in Sources */,
                                 14D2F3DA139F4BE200491031 /* MarkedSpace.cpp in Sources */,
+                                0F660E371E0517B90031462C /* MarkingConstraint.cpp in Sources */,
+                                0F660E391E0517BF0031462C /* MarkingConstraintSet.cpp in Sources */,
                                 142D6F1113539A4100B02E86 /* MarkStack.cpp in Sources */,
                                 DC69AA661CF7A1F200C6272F /* MatchResult.cpp in Sources */,
@@ -10351 +10357 @@
                                 14AD91181DCA97FD0014F9FE /* ModuleProgramCodeBlock.cpp in Sources */,
                                 147341E41DC2CE9600AA29BA /* ModuleProgramExecutable.cpp in Sources */,
+                                0F1FB3901E173A6B00A9BE50 /* MutatorScheduler.cpp in Sources */,
                                 0FA762061DB9243100B7A2FD /* MutatorState.cpp in Sources */,
                                 14469DE0107EC7E700650446 /* NativeErrorConstructor.cpp in Sources */,
@@ -10462 +10469 @@
                                 0F6DB7EA1D6124B800CDBF8E /* StackFrame.cpp in Sources */,
                                 A7C1EAF117987AB600299DB2 /* StackVisitor.cpp in Sources */,
+                                0F4F828B1E31B9740075184C /* StochasticSpaceTimeMutatorScheduler.cpp in Sources */,
                                 0F7CF9531DC027DB0098CC12 /* StopIfNecessaryTimer.cpp in Sources */,
                                 A730B6131250068F009D25B1 /* StrictEvalActivation.cpp in Sources */,
                                 14469DEB107EC7E700650446 /* StringConstructor.cpp in Sources */,
                                 70EC0EC61AA0D7DA00B6AAFA /* StringIteratorPrototype.cpp in Sources */,
-                                0F1FB3901E173A6B00A9BE50 /* MutatorScheduler.cpp in Sources */,
                                 14469DEC107EC7E700650446 /* StringObject.cpp in Sources */,
                                 14469DED107EC7E700650446 /* StringPrototype.cpp in Sources */,
@@ -10477 +10484 @@
                                 0F766D3815AE4A1C008F363E /* StructureStubClearingWatchpoint.cpp in Sources */,
                                 BCCF0D0C0EF0B8A500413C8F /* StructureStubInfo.cpp in Sources */,
+                                0F7DF1361E2970DF0095951B /* Subspace.cpp in Sources */,
                                 0F4A38F91C8E13DF00190318 /* SuperSampler.cpp in Sources */,
                                 705B41AB1A6E501E00716757 /* Symbol.cpp in Sources */,
@@ -10483 +10491 @@
                                 705B41B11A6E501E00716757 /* SymbolPrototype.cpp in Sources */,
                                 0F919D2815856773004A4E7D /* SymbolTable.cpp in Sources */,
+                                0F1FB38E1E173A6500A9BE50 /* SynchronousStopTheWorldMutatorScheduler.cpp in Sources */,
                                 DC7997841CDE9FA2004D4A09 /* TagRegistersMode.cpp in Sources */,
                                 70ECA6071AFDBEA200449739 /* TemplateRegistry.cpp in Sources */,
@@ -10518 +10527 @@
                                 79EE0BFF1B4AFB85000385C9 /* VariableEnvironment.cpp in Sources */,
                                 0F6C73501AC9F99F00BE1682 /* VariableWriteFireDetail.cpp in Sources */,
-                                0F660E371E0517B90031462C /* MarkingConstraint.cpp in Sources */,
                                 0FE0502C1AA9095600D33B33 /* VarOffset.cpp in Sources */,
                                 0F20C2591A8013AB00DA3229 /* VirtualRegister.cpp in Sources */,
@@ -10531 +10539 @@
                                 79B759741DFA4C600052174C /* WasmMemoryInformation.cpp in Sources */,
                                 53F40E971D5A7BEC0099A1B6 /* WasmModuleParser.cpp in Sources */,
+                                ADB6F67D1E15D7600082F384 /* WasmPageCount.cpp in Sources */,
                                 531374BF1D5CE95000AF7A0B /* WasmPlan.cpp in Sources */,
+                                AD7438C11E0457AA00FD0C2A /* WasmSignature.cpp in Sources */,
                                 53FF7F9B1DBFD2B900A26CCC /* WasmValidate.cpp in Sources */,
                                 FED94F2E171E3E2300BE77A4 /* Watchdog.cpp in Sources */,
                                 0F919D2515853CE0004A4E7D /* Watchpoint.cpp in Sources */,
                                 1ACF7377171CA6FB00C9BB1E /* Weak.cpp in Sources */,
-                                AD7438C11E0457AA00FD0C2A /* WasmSignature.cpp in Sources */,
                                 14E84F9E14EE1ACC00D6D5D4 /* WeakBlock.cpp in Sources */,
                                 14F7256514EE265E00B1652B /* WeakHandleOwner.cpp in Sources */,
@@ -10550 +10559 @@
                                 AD2FCBF01DB58DAD00B3E736 /* WebAssemblyInstanceConstructor.cpp in Sources */,
                                 AD2FCBF21DB58DAD00B3E736 /* WebAssemblyInstancePrototype.cpp in Sources */,
+                                ADE8029E1E08F2280058DE78 /* WebAssemblyLinkErrorConstructor.cpp in Sources */,
+                                ADE8029B1E08F1DE0058DE78 /* WebAssemblyLinkErrorPrototype.cpp in Sources */,
                                 AD2FCBF41DB58DAD00B3E736 /* WebAssemblyMemoryConstructor.cpp in Sources */,
                                 AD2FCBF61DB58DAD00B3E736 /* WebAssemblyMemoryPrototype.cpp in Sources */,
@@ -10569 +10580 @@
                                 86704B8912DBA33700A9FE7B /* YarrPattern.cpp in Sources */,
                                 86704B4212DB8A8100A9FE7B /* YarrSyntaxChecker.cpp in Sources */,
-                                FA3AB211C8494524AB390267 /* JSSourceCode.cpp in Sources */,
-                                14815F5F991C46BEB98D0016 /* JSScriptFetcher.cpp in Sources */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;

trunk/Source/JavaScriptCore/inspector/AsyncStackTrace.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -24 +24 @@
  */
 
-.tree-outline > .item.thread .icon {
-    content: url(../Images/Thread.svg);
-    width: 15px;
-    height: 15px;
-}
+#pragma once
 
-.tree-outline > .item.thread .status-button.resume {
-    width: 11px;
-    height: 11px;
-    vertical-align: middle;
-    fill: hsla(0, 0%, 0%, 0.5);
-    stroke: none;
-    display: none;
-}
+#include "InspectorProtocolObjects.h"
+#include <wtf/Forward.h>
+#include <wtf/RefCounted.h>
 
-.tree-outline > .item.thread .status-button.resume:active {
-    fill: hsla(0, 0%, 0%, 0.7);
-}
+namespace Inspector {
 
-.tree-outline:matches(:focus, .force-focus) > .item.thread.selected .status-button.resume {
-    fill: var(--selected-foreground-color);
-}
+class ScriptCallStack;
 
-.tree-outline > .item.thread.selected .status-button.resume,
-.tree-outline > .item.thread:hover .status-button.resume {
-    display: inline-block;
-}
+class JS_EXPORT_PRIVATE AsyncStackTrace : public RefCounted<AsyncStackTrace> {
+public:
+    enum class State {
+        Pending,
+        Active,
+        Dispatched,
+        Canceled,
+    };
+
+    static RefPtr<AsyncStackTrace> create(RefPtr<ScriptCallStack>, bool singleShot, RefPtr<AsyncStackTrace> parent);
+
+    bool isPending() const;
+    bool isLocked() const;
+
+    void willDispatchAsyncCall(size_t maxDepth);
+    void didDispatchAsyncCall();
+    void didCancelAsyncCall();
+
+    RefPtr<Inspector::Protocol::Console::StackTrace> buildInspectorObject() const;
+
+    ~AsyncStackTrace();
+
+private:
+    AsyncStackTrace(RefPtr<ScriptCallStack>, bool, RefPtr<AsyncStackTrace>);
+
+    void truncate(size_t maxDepth);
+    void remove();
+
+    RefPtr<ScriptCallStack> m_callStack;
+    RefPtr<AsyncStackTrace> m_parent;
+    unsigned m_childCount { 0 };
+    State m_state { State::Pending };
+    bool m_truncated { false };
+    bool m_singleShot { true };
+};
+
+} // namespace Inspector

trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp

@@ -31 +31 @@
 #include "InspectorDebuggerAgent.h"
 
+#include "AsyncStackTrace.h"
 #include "ContentSearchUtilities.h"
 #include "InjectedScript.h"
@@ -213 +214 @@
 }
 
-RefPtr<Inspector::Protocol::Console::StackTrace> InspectorDebuggerAgent::buildAsyncStackTrace(const AsyncCallIdentifier& identifier)
-{
-    RefPtr<Inspector::Protocol::Console::StackTrace> topStackTrace;
-    RefPtr<Inspector::Protocol::Console::StackTrace> previousStackTrace;
-
-    auto iterator = m_asyncCallIdentifierToData.find(identifier);
-    auto end = m_asyncCallIdentifierToData.end();
-    while (iterator != end) {
-        const auto& callData = iterator->value;
-        ASSERT(callData.callStack && callData.callStack->size());
-        if (!callData.callStack || !callData.callStack->size())
-            break;
-
-        RefPtr<Inspector::Protocol::Console::StackTrace> stackTrace = Inspector::Protocol::Console::StackTrace::create()
-            .setCallFrames(callData.callStack->buildInspectorArray())
-            .release();
-
-        if (callData.callStack->at(0).isNative())
-            stackTrace->setTopCallFrameIsBoundary(true);
-        if (!topStackTrace)
-            topStackTrace = stackTrace;
-        if (previousStackTrace)
-            previousStackTrace->setParentStackTrace(stackTrace);
-
-        if (!callData.parentAsyncCallIdentifier)
-            break;
-
-        previousStackTrace = stackTrace;
-        iterator = m_asyncCallIdentifierToData.find(callData.parentAsyncCallIdentifier.value());
-    }
-
-    return topStackTrace;
-}
-
 void InspectorDebuggerAgent::handleConsoleAssert(const String& message)
 {
@@ -269 +236 @@
         return;
 
-    if (m_currentAsyncCallIdentifier)
-        refAsyncCallData(m_currentAsyncCallIdentifier.value());
-
-    m_asyncCallIdentifierToData.set(std::make_pair(asyncCallType, callbackIdentifier), AsyncCallData(callStack, m_currentAsyncCallIdentifier, singleShot));
+    RefPtr<AsyncStackTrace> parentStackTrace;
+    if (m_currentAsyncCallIdentifier) {
+        auto it = m_pendingAsyncCalls.find(m_currentAsyncCallIdentifier.value());
+        ASSERT(it != m_pendingAsyncCalls.end());
+        parentStackTrace = it->value;
+    }
+
+    auto identifier = std::make_pair(asyncCallType, callbackIdentifier);
+    auto asyncStackTrace = AsyncStackTrace::create(WTFMove(callStack), singleShot, WTFMove(parentStackTrace));
+
+    m_pendingAsyncCalls.set(identifier, WTFMove(asyncStackTrace));
 }
 
@@ -280 +254 @@
         return;
 
-    const auto asyncCallIdentifier = std::make_pair(asyncCallType, callbackIdentifier);
-    derefAsyncCallData(asyncCallIdentifier);
+    auto identifier = std::make_pair(asyncCallType, callbackIdentifier);
+    auto it = m_pendingAsyncCalls.find(identifier);
+    if (it == m_pendingAsyncCalls.end())
+        return;
+
+    auto& asyncStackTrace = it->value;
+    asyncStackTrace->didCancelAsyncCall();
+
+    if (m_currentAsyncCallIdentifier && m_currentAsyncCallIdentifier.value() == identifier)
+        return;
+
+    m_pendingAsyncCalls.remove(identifier);
 }
 
@@ -294 +278 @@
     // A call can be scheduled before the Inspector is opened, or while async stack
     // traces are disabled. If no call data exists, do nothing.
-    auto asyncCallIdentifier = std::make_pair(asyncCallType, callbackIdentifier);
-    if (!m_asyncCallIdentifierToData.contains(asyncCallIdentifier))
-        return;
-
-    m_currentAsyncCallIdentifier = WTFMove(asyncCallIdentifier);
-    refAsyncCallData(asyncCallIdentifier);
+    auto identifier = std::make_pair(asyncCallType, callbackIdentifier);
+    auto it = m_pendingAsyncCalls.find(identifier);
+    if (it == m_pendingAsyncCalls.end())
+        return;
+
+    auto& asyncStackTrace = it->value;
+    asyncStackTrace->willDispatchAsyncCall(m_asyncStackTraceDepth);
+
+    m_currentAsyncCallIdentifier = identifier;
 }
 
@@ -310 +297 @@
         return;
 
-    derefAsyncCallData(m_currentAsyncCallIdentifier.value());
+    auto identifier = m_currentAsyncCallIdentifier.value();
+    auto it = m_pendingAsyncCalls.find(identifier);
+    ASSERT(it != m_pendingAsyncCalls.end());
+
+    auto& asyncStackTrace = it->value;
+    asyncStackTrace->didDispatchAsyncCall();
+
     m_currentAsyncCallIdentifier = std::nullopt;
+
+    if (!asyncStackTrace->isPending())
+        m_pendingAsyncCalls.remove(identifier);
 }
 
@@ -1002 +998 @@
 
     RefPtr<Inspector::Protocol::Console::StackTrace> asyncStackTrace;
-    if (m_currentAsyncCallIdentifier)
-        asyncStackTrace = buildAsyncStackTrace(m_currentAsyncCallIdentifier.value());
+    if (m_currentAsyncCallIdentifier) {
+        auto it = m_pendingAsyncCalls.find(m_currentAsyncCallIdentifier.value());
+        if (it != m_pendingAsyncCalls.end())
+            asyncStackTrace = it->value->buildInspectorObject();
+    }
 
     m_frontendDispatcher->paused(currentCallFrames(injectedScript), m_breakReason, m_breakAuxData, asyncStackTrace);
@@ -1139 +1138 @@
 void InspectorDebuggerAgent::clearAsyncStackTraceData()
 {
-    m_asyncCallIdentifierToData.clear();
+    m_pendingAsyncCalls.clear();
     m_currentAsyncCallIdentifier = std::nullopt;
 }
 
-void InspectorDebuggerAgent::refAsyncCallData(const AsyncCallIdentifier& identifier)
-{
-    auto iterator = m_asyncCallIdentifierToData.find(identifier);
-    if (iterator == m_asyncCallIdentifierToData.end())
-        return;
-
-    iterator->value.referenceCount++;
-}
-
-void InspectorDebuggerAgent::derefAsyncCallData(const AsyncCallIdentifier& identifier)
-{
-    auto iterator = m_asyncCallIdentifierToData.find(identifier);
-    if (iterator == m_asyncCallIdentifierToData.end())
-        return;
-
-    auto& asyncCallData = iterator->value;
-    asyncCallData.referenceCount--;
-    if (asyncCallData.referenceCount)
-        return;
-
-    if (asyncCallData.parentAsyncCallIdentifier)
-        derefAsyncCallData(asyncCallData.parentAsyncCallIdentifier.value());
-    m_asyncCallIdentifierToData.remove(identifier);
-}
-
 } // namespace Inspector

trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h

@@ -45 +45 @@
 namespace Inspector {
 
+class AsyncStackTrace;
 class InjectedScript;
 class InjectedScriptManager;
@@ -50 +51 @@
 class InspectorObject;
 class ScriptDebugServer;
-struct AsyncCallData;
 typedef String ErrorString;
 
@@ -165 +165 @@
     typedef std::pair<int, int> AsyncCallIdentifier;
 
-    RefPtr<Inspector::Protocol::Console::StackTrace> buildAsyncStackTrace(const AsyncCallIdentifier&);
-    void refAsyncCallData(const AsyncCallIdentifier&);
-    void derefAsyncCallData(const AsyncCallIdentifier&);
-
     typedef HashMap<JSC::SourceID, Script> ScriptsMap;
     typedef HashMap<String, Vector<JSC::BreakpointID>> BreakpointIdentifierToDebugServerBreakpointIDsMap;
     typedef HashMap<String, RefPtr<InspectorObject>> BreakpointIdentifierToBreakpointMap;
     typedef HashMap<JSC::BreakpointID, String> DebugServerBreakpointIDToBreakpointIdentifier;
-
-    struct AsyncCallData {
-        AsyncCallData(RefPtr<ScriptCallStack> callStack, std::optional<AsyncCallIdentifier> parentAsyncCallIdentifier, bool singleShot)
-            : callStack(callStack)
-            , parentAsyncCallIdentifier(parentAsyncCallIdentifier)
-            , referenceCount(singleShot ? 0 : 1)
-        {
-        }
-
-        AsyncCallData() = default;
-
-        RefPtr<ScriptCallStack> callStack;
-        std::optional<AsyncCallIdentifier> parentAsyncCallIdentifier { std::nullopt };
-        unsigned referenceCount { 0 };
-    };
 
     InjectedScriptManager& m_injectedScriptManager;
@@ -205 +186 @@
     ShouldDispatchResumed m_conditionToDispatchResumed { ShouldDispatchResumed::No };
     bool m_enablePauseWhenIdle { false };
-    HashMap<AsyncCallIdentifier, AsyncCallData> m_asyncCallIdentifierToData;
+    HashMap<AsyncCallIdentifier, RefPtr<AsyncStackTrace>> m_pendingAsyncCalls;
     std::optional<AsyncCallIdentifier> m_currentAsyncCallIdentifier { std::nullopt };
     bool m_enabled { false };

trunk/Source/JavaScriptCore/inspector/protocol/Console.json

@@ -41 +41 @@
                 { "name": "callFrames", "type": "array", "items": { "$ref": "CallFrame" } },
                 { "name": "topCallFrameIsBoundary", "type": "boolean", "optional": true, "description": "Whether the first item in <code>callFrames</code> is the native function that scheduled the asynchronous operation (e.g. setTimeout)." },
+                { "name": "truncated", "type": "boolean", "optional": true, "description": "Whether one or more frames have been truncated from the bottom of the stack." },
                 { "name": "parentStackTrace", "$ref": "StackTrace", "optional": true, "description": "Parent StackTrace." }
             ]

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-01-30  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
+        https://bugs.webkit.org/show_bug.cgi?id=165633
+        <rdar://problem/29738502>
+
+        Reviewed by Joseph Pecoraro.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        Text for "Truncated" marker tree element.
+
+        * UserInterface/Models/StackTrace.js:
+        (WebInspector.StackTrace):
+        (WebInspector.StackTrace.fromPayload):
+        (WebInspector.StackTrace.prototype.get truncated):
+        Plumbing for new Console.StackTrace property `truncated`.
+
+        * UserInterface/Views/ThreadTreeElement.css:
+        (.tree-outline > .item.thread + ol > .item.truncated-call-frames):
+        (.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
+        Styles for "Truncated" marker tree element.
+
+        * UserInterface/Views/ThreadTreeElement.js:
+        (WebInspector.ThreadTreeElement.prototype.refresh):
+        Append "Truncated" marker tree element if necessary.
+
+        * Versions/Inspector-iOS-10.3.json:
+
 2017-01-30  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -126 +126 @@
 localizedStrings["CSP Hash"] = "CSP Hash";
 localizedStrings["Cached"] = "Cached";
+localizedStrings["Call Frames Truncated"] = "Call Frames Truncated";
 localizedStrings["Call Stack"] = "Call Stack";
 localizedStrings["Call Trees"] = "Call Trees";

trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js

@@ -26 +26 @@
 WebInspector.StackTrace = class StackTrace extends WebInspector.Object
 {
-    constructor(callFrames, topCallFrameIsBoundary)
+    constructor(callFrames, topCallFrameIsBoundary, truncated, parentStackTrace)
     {
         super();
@@ -34 +34 @@
         this._callFrames = callFrames;
         this._topCallFrameIsBoundary = topCallFrameIsBoundary || false;
-        this._parentStackTrace = null;
+        this._truncated = truncated || false;
+        this._parentStackTrace = parentStackTrace || null;
     }
 
@@ -46 +47 @@
         while (payload) {
             let callFrames = payload.callFrames.map((x) => WebInspector.CallFrame.fromPayload(target, x));
-            let stackTrace = new WebInspector.StackTrace(callFrames, payload.topCallFrameIsBoundary);
+            let stackTrace = new WebInspector.StackTrace(callFrames, payload.topCallFrameIsBoundary, payload.truncated);
             if (!result)
                 result = stackTrace;
@@ -170 +171 @@
 
     get topCallFrameIsBoundary() { return this._topCallFrameIsBoundary; }
+    get truncated() { return this._truncated; }
     get parentStackTrace() { return this._parentStackTrace; }
 };

trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css

@@ -51 +51 @@
     display: inline-block;
 }
+
+.tree-outline > .item.thread + ol > .item.truncated-call-frames {
+    color: var(--text-color-gray-medium);
+    border-top: dashed 0.5px var(--border-color);
+    margin-left: 31px;
+    margin-right: 6px;
+    padding-left: 0;
+    cursor: default;
+}
+
+.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon {
+    margin-left: 0;
+    content: url(../Images/Function.svg);
+    opacity: 0.6;
+}

trunk/Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.js

@@ -93 +93 @@
                 this.appendChild(new WebInspector.CallFrameTreeElement(currentStackTrace.callFrames[i]));
 
+            if (currentStackTrace.truncated) {
+                let truncatedTreeElement = new WebInspector.GeneralTreeElement("truncated-call-frames", WebInspector.UIString("Call Frames Truncated"));
+                truncatedTreeElement.selectable = false;
+                this.appendChild(truncatedTreeElement);
+            }
+
             currentStackTrace = currentStackTrace.parentStackTrace;
         }

trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json

@@ -588 +588 @@
                 { "name": "callFrames", "type": "array", "items": { "$ref": "CallFrame" } },
                 { "name": "topCallFrameIsBoundary", "type": "boolean", "optional": true, "description": "Whether the first item in <code>callFrames</code> is the native function that scheduled the asynchronous operation (e.g. setTimeout)." },
+                { "name": "truncated", "type": "boolean", "optional": true, "description": "Whether one or more frames have been truncated from the bottom of the stack." },
                 { "name": "parentStackTrace", "$ref": "StackTrace", "optional": true, "description": "Parent StackTrace." }
             ]