Changeset 211399 in webkit

Timestamp:

Jan 30, 2017 6:12:06 PM (7 years ago)

Author:

akling@apple.com

Message:

Fix CMSampleBuffer leak in MediaSampleAVFObjC::createNonDisplayingCopy().
<​https://webkit.org/b/167621>

Reviewed by Andy Estes.

We were failing to adopt the CMSampleBuffer after copying it. Seen on leaks bot.

• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::createNonDisplayingCopy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-30  Andreas Kling  <akling@apple.com>
+
+        Fix CMSampleBuffer leak in MediaSampleAVFObjC::createNonDisplayingCopy().
+        <https://webkit.org/b/167621>
+
+        Reviewed by Andy Estes.
+
+        We were failing to adopt the CMSampleBuffer after copying it. Seen on leaks bot.
+
+        * platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
+        (WebCore::MediaSampleAVFObjC::createNonDisplayingCopy):
+
 2017-01-30  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm

@@ -230 +230 @@
     }
 
-    return MediaSampleAVFObjC::create(newSampleBuffer, m_id);
-}
-
-}
+    return MediaSampleAVFObjC::create(adoptCF(newSampleBuffer).get(), m_id);
+}
+
+}