Changeset 211407 in webkit

Timestamp:

Jan 30, 2017 10:27:37 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] HTTP authentication is not implemented for downloads
​https://bugs.webkit.org/show_bug.cgi?id=167583

Reviewed by Michael Catanzaro.

When a normal load is converted to a download, the HTTP authentication happens before the load is converted, and
the download starts already authenticated. However, downloads started by DownloadManager::startDownload use the
DownloadClient API to do the authentication. We don't implement didReceiveAuthenticationChallenge() in our
download client, what makes the load to be cancelled and then fail silently. We should probably add API to
handle downloads authentication, but we can also forward the authentication to the web view for downloads having
a web view associated. That would cover most of the cases, like downloading from the context menu.

• UIProcess/API/gtk/WebKitDownloadClient.cpp: Add didReceiveAuthenticationChallenge implementation.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitDownloadClient.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] HTTP authentication is not implemented for downloads
+        https://bugs.webkit.org/show_bug.cgi?id=167583
+
+        Reviewed by Michael Catanzaro.
+
+        When a normal load is converted to a download, the HTTP authentication happens before the load is converted, and
+        the download starts already authenticated. However, downloads started by DownloadManager::startDownload use the
+        DownloadClient API to do the authentication. We don't implement didReceiveAuthenticationChallenge() in our
+        download client, what makes the load to be cancelled and then fail silently. We should probably add API to
+        handle downloads authentication, but we can also forward the authentication to the web view for downloads having
+        a web view associated. That would cover most of the cases, like downloading from the context menu.
+
+        * UIProcess/API/gtk/WebKitDownloadClient.cpp: Add didReceiveAuthenticationChallenge implementation.
+
 2017-01-30  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp

@@ -25 +25 @@
 #include "WebKitURIResponsePrivate.h"
 #include "WebKitWebContextPrivate.h"
+#include "WebKitWebViewPrivate.h"
 #include "WebProcessPool.h"
 #include <WebKit/WKString.h>
@@ -45 +46 @@
         GRefPtr<WebKitDownload> download = webkitWebContextGetOrCreateDownload(downloadProxy);
         webkitWebContextDownloadStarted(m_webContext, download.get());
+    }
+
+    void didReceiveAuthenticationChallenge(WebProcessPool*, DownloadProxy* downloadProxy, AuthenticationChallengeProxy* authenticationChallenge) override
+    {
+        GRefPtr<WebKitDownload> download = webkitWebContextGetOrCreateDownload(downloadProxy);
+        if (webkitDownloadIsCancelled(download.get()))
+            return;
+
+        // FIXME: Add API to handle authentication of downloads without a web view associted.
+        if (auto* webView = webkit_download_get_web_view(download.get()))
+            webkitWebViewHandleAuthenticationChallenge(webView, authenticationChallenge);
     }