Changeset 21186 in webkit

Timestamp:

Apr 29, 2007 8:29:00 PM (17 years ago)

Author:

bdash

Message:

2007-04-29 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13544 REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers

Test: fast/repaint/layer-hide-when-needs-layout.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): If we get a layout hint, we count on layout() or updateLayerPositions() to repaint. In the case of a layer going invisible, however, we need to repaint here since neither of the above will do it.

2007-04-29 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=13544 REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers

• fast/repaint/layer-hide-when-needs-layout-expected.checksum: Added.
• fast/repaint/layer-hide-when-needs-layout-expected.png: Added.
• fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
• fast/repaint/layer-hide-when-needs-layout.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/layer-hide-when-needs-layout-expected.checksum (added)
• LayoutTests/fast/repaint/layer-hide-when-needs-layout-expected.png (added)
• LayoutTests/fast/repaint/layer-hide-when-needs-layout-expected.txt (added)
• LayoutTests/fast/repaint/layer-hide-when-needs-layout.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderObject.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-04-29  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Dave Hyatt.
+
+        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=13544
+          REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers
+
+        * fast/repaint/layer-hide-when-needs-layout-expected.checksum: Added.
+        * fast/repaint/layer-hide-when-needs-layout-expected.png: Added.
+        * fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
+        * fast/repaint/layer-hide-when-needs-layout.html: Added.
+
 2007-04-29  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-04-29  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13544
+          REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers
+
+        Test: fast/repaint/layer-hide-when-needs-layout.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::setStyle): If we get a layout hint, we count on
+        layout() or updateLayerPositions() to repaint. In the case of a layer
+        going invisible, however, we need to repaint here since neither of the
+        above will do it.
+
 2007-04-29  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/rendering/RenderObject.cpp

@@ -2140 +2140 @@
     RenderStyle::Diff d = RenderStyle::Equal;
     if (m_style) {
+        d = m_style->diff(style);
+
         // If our z-index changes value or our visibility changes,
         // we need to dirty our stacking context's z-order list.
@@ -2158 +2160 @@
             // keep layer hierarchy visibility bits up to date if visibility changes
             if (m_style->visibility() != style->visibility()) {
-                RenderLayer* l = enclosingLayer();
-                if (style->visibility() == VISIBLE && l)
-                    l->setHasVisibleContent(true);
-                else if (l && l->hasVisibleContent() &&
-                            (this == l->renderer() || l->renderer()->style()->visibility() != VISIBLE))
-                    l->dirtyVisibleContentStatus();
+                if (RenderLayer* l = enclosingLayer()) {
+                    if (style->visibility() == VISIBLE)
+                        l->setHasVisibleContent(true);
+                    else if (l->hasVisibleContent() && (this == l->renderer() || l->renderer()->style()->visibility() != VISIBLE)) {
+                        l->dirtyVisibleContentStatus();
+                        if (d > RenderStyle::RepaintLayer)
+                            repaint();
+                    }
+                }
             }
         }
-
-        d = m_style->diff(style);
 
         // If we have no layer(), just treat a RepaintLayer hint as a normal Repaint.