Changeset 212152 in webkit

Timestamp:

Feb 10, 2017, 2:40:18 PM (8 years ago)

Author:

Simon Fraser

Message:

Tiled layers are sometimes left with some tiles when outside the viewport
​https://bugs.webkit.org/show_bug.cgi?id=168104
Source/WebCore:

rdar://problem/30459055

Reviewed by Tim Horton.

When the coverage rect of a TiledBacking goes from a non-empty rect to an empty rect, we
shouldn't just early return from TileGrid::revalidateTiles(), otherwise we are left with some
tiles. Run through the function as normal, which will remove all the tiles for an empty coverage rect.

Minor logging changes.

Test: tiled-drawing/tile-coverage-iframe-to-zero-coverage.html

• platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::revalidateTiles):

LayoutTests:

Reviewed by Tim Horton.

• tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt: Added.
• tiled-drawing/tile-coverage-iframe-to-zero-coverage.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt (added)
• LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/ca/TileGrid.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-02-09  Simon Fraser  <simon.fraser@apple.com>
+
+        Tiled layers are sometimes left with some tiles when outside the viewport
+        https://bugs.webkit.org/show_bug.cgi?id=168104
+
+        Reviewed by Tim Horton.
+
+        * tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt: Added.
+        * tiled-drawing/tile-coverage-iframe-to-zero-coverage.html: Added.
+
 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-02-09  Simon Fraser  <simon.fraser@apple.com>
+
+        Tiled layers are sometimes left with some tiles when outside the viewport
+        https://bugs.webkit.org/show_bug.cgi?id=168104
+        rdar://problem/30459055
+
+        Reviewed by Tim Horton.
+
+        When the coverage rect of a TiledBacking goes from a non-empty rect to an empty rect, we
+        shouldn't just early return from TileGrid::revalidateTiles(), otherwise we are left with some
+        tiles. Run through the function as normal, which will remove all the tiles for an empty coverage rect.
+        
+        Minor logging changes.
+
+        Test: tiled-drawing/tile-coverage-iframe-to-zero-coverage.html
+
+        * platform/graphics/ca/TileGrid.cpp:
+        (WebCore::TileGrid::revalidateTiles):
+
 2017-02-10  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp

@@ -353 +353 @@
     IntRect bounds = m_controller.bounds();
 
-    LOG_WITH_STREAM(Tiling, stream << "TileGrid " << this << " revalidateTiles: bounds " << bounds << " coverageRect" << coverageRect << " validation: " << validationPolicyAsString(validationPolicy));
-
-    if (coverageRect.isEmpty() || bounds.isEmpty())
-        return;
+    LOG_WITH_STREAM(Tiling, stream << "TileGrid " << this << " (controller " << &m_controller << ") revalidateTiles: bounds " << bounds << " coverageRect" << coverageRect << " validation: " << validationPolicyAsString(validationPolicy));
 
     FloatRect scaledRect(coverageRect);