Changeset 212419 in webkit

Timestamp:

Feb 15, 2017 8:23:23 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

MIPS: add missing implementations of load8SignedExtendTo32()

JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()
​https://bugs.webkit.org/show_bug.cgi?id=168350

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-02-15
Reviewed by Yusuke Suzuki.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::load8SignedExtendTo32):
Add missing implementations

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerMIPS.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-02-15  Guillaume Emont  <guijemont@igalia.com>
+
+        MIPS: add missing implementations of load8SignedExtendTo32()
+
+        JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32()
+        https://bugs.webkit.org/show_bug.cgi?id=168350
+
+        Reviewed by Yusuke Suzuki.
+
+        * assembler/MacroAssemblerMIPS.h:
+        (JSC::MacroAssemblerMIPS::load8SignedExtendTo32):
+        Add missing implementations
+
 2017-02-15  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h

@@ -747 +747 @@
     }
 
+    void load8SignedExtendTo32(ImplicitAddress address, RegisterID dest)
+    {
+        if (address.offset >= -32768 && address.offset <= 32767
+            && !m_fixedWidth)
+            m_assembler.lb(dest, address.base, address.offset);
+        else {
+            /*
+                lui     addrTemp, (offset + 0x8000) >> 16
+                addu    addrTemp, addrTemp, base
+                lb      dest, (offset & 0xffff)(addrTemp)
+              */
+            m_assembler.lui(addrTempRegister, (address.offset + 0x8000) >> 16);
+            m_assembler.addu(addrTempRegister, addrTempRegister, address.base);
+            m_assembler.lb(dest, addrTempRegister, address.offset);
+        }
+    }
+
     void load8SignedExtendTo32(BaseIndex address, RegisterID dest)
     {
@@ -774 +791 @@
         }
     }
+
+    ALWAYS_INLINE void load8SignedExtendTo32(AbsoluteAddress address, RegisterID dest)
+    {
+        load8SignedExtendTo32(address.m_ptr, dest);
+    }
+
+    void load8SignedExtendTo32(const void* address, RegisterID dest)
+    {
+        /*
+            li  addrTemp, address
+            lb  dest, 0(addrTemp)
+        */
+        move(TrustedImmPtr(address), addrTempRegister);
+        m_assembler.lb(dest, addrTempRegister, 0);
+    }
+
 
     void load32(ImplicitAddress address, RegisterID dest)