Changeset 213194 in webkit

Timestamp:

Feb 28, 2017 5:01:49 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167441
<rdar://problem/30770034>

Patch by Antoine Quint <Antoine Quint> on 2017-02-28
Reviewed by Dean Jackson.

This test would sometime fail when calling media.webkitShowPlaybackTargetPicker() due to the requirement
that the media be playable for that call to succeed. So we add an event listener for the "canplay" event
before we proceed to ensure that this call will always succeed. The fact that the media is playing is
irrelevant so we remove the "autoplay" attribute.

• media/modern-media-controls/placard-support/placard-support-airplay.html:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/modern-media-controls/placard-support/placard-support-airplay.html (modified) (3 diffs)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-02-28  Antoine Quint  <graouts@apple.com>
+
+        LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=167441
+        <rdar://problem/30770034>
+
+        Reviewed by Dean Jackson.
+
+        This test would sometime fail when calling media.webkitShowPlaybackTargetPicker() due to the requirement
+        that the media be playable for that call to succeed. So we add an event listener for the "canplay" event
+        before we proceed to ensure that this call will always succeed. The fact that the media is playing is
+        irrelevant so we remove the "autoplay" attribute.
+
+        * media/modern-media-controls/placard-support/placard-support-airplay.html:
+        * platform/mac/TestExpectations:
+
 2017-02-28  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay.html

@@ -16 +16 @@
     
 </style>
-<video src="../../content/test.mp4" controls autoplay></video>
+<video src="../../content/test.mp4" controls></video>
 <div id="host"></div>
 <script type="text/javascript">
@@ -28 +28 @@
 const mediaController = createControls(container, media, null);
 
-(function makeAirPlayAvailable()
+media.addEventListener("canplay", makeAirPlayAvailable);
+
+function makeAirPlayAvailable()
 {
     media.addEventListener("webkitplaybacktargetavailabilitychanged", playbackTargetAvailabilityChangedOnce, true);
     window.internals.setMockMediaPlaybackTargetPickerEnabled(true);
-})();
+}
 
 function playbackTargetAvailabilityChangedOnce(event)
@@ -51 +53 @@
 
     media.removeEventListener('webkitplaybacktargetavailabilitychanged', playbackTargetAvailabilityChangedAgain, true);
-
-    window.setTimeout(enterAirPlay, 100);
+    enterAirPlay();
 }
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1495 +1495 @@
 webkit.org/b/167396 media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ]
 
-webkit.org/b/167441 media/modern-media-controls/placard-support/placard-support-airplay.html [ Pass Timeout ]
-
 webkit.org/b/167442 media/modern-media-controls/airplay-support/airplay-support.html [ Pass Timeout ]