Changeset 213196 in webkit


Ignore:
Timestamp:
Feb 28, 2017 5:08:12 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

LayoutTest media/modern-media-controls/airplay-support/airplay-support.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167442
<rdar://problem/30770374>

Patch by Antoine Quint <Antoine Quint> on 2017-02-28
Reviewed by Dean Jackson.

This test would sometime fail when calling media.webkitShowPlaybackTargetPicker() due to the requirement
that the media be playable for that call to succeed. So we add an event listener for the "canplay" event
before we proceed to ensure that this call will always succeed. The fact that the media is playing is
irrelevant so we remove the "autoplay" attribute.

  • media/modern-media-controls/airplay-support/airplay-support.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r213194 r213196  
     12017-02-28  Antoine Quint  <graouts@apple.com>
     2
     3        LayoutTest media/modern-media-controls/airplay-support/airplay-support.html is a flaky timeout
     4        https://bugs.webkit.org/show_bug.cgi?id=167442
     5        <rdar://problem/30770374>
     6
     7        Reviewed by Dean Jackson.
     8
     9        This test would sometime fail when calling media.webkitShowPlaybackTargetPicker() due to the requirement
     10        that the media be playable for that call to succeed. So we add an event listener for the "canplay" event
     11        before we proceed to ensure that this call will always succeed. The fact that the media is playing is
     12        irrelevant so we remove the "autoplay" attribute.
     13
     14        * media/modern-media-controls/airplay-support/airplay-support.html:
     15        * platform/mac/TestExpectations:
     16
    1172017-02-28  Antoine Quint  <graouts@apple.com>
    218

  • trunk/LayoutTests/media/modern-media-controls/airplay-support/airplay-support.html

    r211136 r213196  
    22<script src="../resources/media-controls-loader.js" type="text/javascript"></script>
    33<body>
    4 <video src="../../content/test.mp4" style="width: 320px; height: 240px;" autoplay></video>
     4<video src="../../content/test.mp4" style="width: 320px; height: 240px;"></video>
    55<div id="host"></div>
    66<script type="text/javascript">
    … …  
    1414const mediaController = createControls(container, media, null);
    1515
    16 (function makeAirPlayAvailable()
     16media.addEventListener("canplay", makeAirPlayAvailable);
     17
     18function makeAirPlayAvailable()
    1719{
    1820    debug("Making AirPlay routes available.");
    1921    media.addEventListener("webkitplaybacktargetavailabilitychanged", playbackTargetAvailabilityChangedOnce, true);
    2022    window.internals.setMockMediaPlaybackTargetPickerEnabled(true);
    21 })();
     23}
    2224
    2325function playbackTargetAvailabilityChangedOnce(event)
    … …  
    4244    shouldBeFalse("mediaController.controls.airplayButton.on");
    4345
    44     window.setTimeout(enterAirPlay, 100);
     46    enterAirPlay();
    4547}
    4648

  • trunk/LayoutTests/platform/mac/TestExpectations

    r213194 r213196  
    14951495webkit.org/b/167396 media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ]
    14961496
    1497 webkit.org/b/167442 media/modern-media-controls/airplay-support/airplay-support.html [ Pass Timeout ]
    1498 
    14991497webkit.org/b/165874 streams/pipe-to.html [ Pass Failure ]
    15001498
Note: See TracChangeset for help on using the changeset viewer.